Skip to content

Commit e791fbc

Browse files
developer-carsonye129348
authored andcommitted
Add test case
Cannot use serverless.cli.log as it causes test case to fail
1 parent 2d66937 commit e791fbc

3 files changed

Lines changed: 12 additions & 1 deletion

File tree

__tests__/fixtures/lambda-layer.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
require('/opt/lambdaLayer.js');
2+
require('test-dep/file');

__tests__/get-dependency-list.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,3 +119,12 @@ test('understands local named dependencies', (t) => {
119119
t.true(list.some(item => item.endsWith('dep-local-named.js')));
120120
t.true(list.some(item => item.endsWith('local/named/index.js')));
121121
});
122+
123+
test('skip dependencies like /opt/lambaLayer.js', (t) => {
124+
const fileName = path.join(__dirname, 'fixtures', 'lambda-layer.js');
125+
126+
const list = getDependencyList(fileName, serverless);
127+
128+
t.true(list.some(item => item.indexOf(`/opt/lambdaLayer.js`) == -1));
129+
t.true(list.some(item => item.match(/test-dep/)));
130+
});

get-dependency-list.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ module.exports = function(filename, serverless) {
2525
function handle(name, basedir, optionalDependencies, peerDependenciesMeta) {
2626
const moduleName = requirePackageName(name.replace(/\\/, '/'));
2727
if (moduleName === null) {
28-
serverless.cli.log(`[serverless-plugin-include-dependencies]: Module not found, skipping ${name}`);
28+
console.log(`[serverless-plugin-include-dependencies]: Module not found, skipping ${name}`);
2929
return null;
3030
}
3131

0 commit comments

Comments
 (0)