Skip to content

Remove redundant commandline.h include in streamingsuperpmi.cpp#129139

Merged
jkotas merged 3 commits into
mainfrom
copilot/fix-code-review-comment
Jun 9, 2026
Merged

Remove redundant commandline.h include in streamingsuperpmi.cpp#129139
jkotas merged 3 commits into
mainfrom
copilot/fix-code-review-comment

Conversation

Copilot AI commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

This addresses the targeted review comment on PR #127295 by making only the requested include-list cleanup. The change removes a duplicate include and leaves behavior untouched.

  • Change

    • In /home/runner/work/runtime/runtime/src/coreclr/tools/superpmi/superpmi/streamingsuperpmi.cpp, removed the second redundant #include "commandline.h".
  • Scope

    • Single-file, surgical edit.
    • No other includes or logic were modified.
#include "spmiutil.h"
#include "fileio.h"
// removed duplicate: #include "commandline.h"

Copilot AI self-assigned this Jun 8, 2026
Copilot AI review requested due to automatic review settings June 8, 2026 21:17
Copilot AI review requested due to automatic review settings June 8, 2026 21:17
Co-authored-by: JulieLeeMSFT <63486087+JulieLeeMSFT@users.noreply.github.com>
Copilot AI requested review from Copilot and removed request for Copilot June 8, 2026 21:23
Copilot AI changed the title [WIP] Fix code based on review comment Remove redundant commandline.h include in streamingsuperpmi.cpp Jun 8, 2026
Copilot AI requested a review from JulieLeeMSFT June 8, 2026 21:24
@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 8, 2026
@jkotas jkotas marked this pull request as ready for review June 8, 2026 21:54
Copilot AI review requested due to automatic review settings June 8, 2026 21:54
@jkotas jkotas enabled auto-merge (squash) June 8, 2026 21:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up the SuperPMI streaming tool’s include list by removing a redundant #include "commandline.h" from streamingsuperpmi.cpp, leaving the remaining (needed) include in place and not changing runtime behavior.

Changes:

  • Removed a duplicate #include "commandline.h" from src/coreclr/tools/superpmi/superpmi/streamingsuperpmi.cpp.

@jkotas jkotas merged commit 03bdf0c into main Jun 9, 2026
110 of 112 checks passed
@jkotas jkotas deleted the copilot/fix-code-review-comment branch June 9, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants