From 26c5502c4bbbd224564e83cc2dcdd8275f5de291 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Mon, 18 May 2026 17:42:36 +0900 Subject: [PATCH 1/2] Remove stale test analyzer suppressions Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../tests/Common/Microsoft.Extensions.Logging.Tests.csproj | 2 -- .../tests/Microsoft.Win32.SystemEvents.Tests.csproj | 2 -- .../System.DirectoryServices.AccountManagement.Tests.csproj | 2 -- .../System.Formats.Asn1/tests/System.Formats.Asn1.Tests.csproj | 2 -- .../tests/System.IO.MemoryMappedFiles.Tests.csproj | 2 -- .../UnitTests/System.Net.Http.WinHttpHandler.Unit.Tests.csproj | 1 - .../FunctionalTests/System.Net.Http.Functional.Tests.csproj | 1 - .../tests/UnitTests/System.Net.Http.Unit.Tests.csproj | 2 -- .../tests/Functional/System.Net.Mail.Functional.Tests.csproj | 1 - .../System.Net.NameResolution.Functional.Tests.csproj | 2 -- .../System.Net.NetworkInformation.Functional.Tests.csproj | 3 --- .../FunctionalTests/System.Net.Ping.Functional.Tests.csproj | 2 -- .../System.Net.Primitives.Functional.Tests.csproj | 3 --- .../tests/FunctionalTests/System.Net.Security.Tests.csproj | 1 - .../tests/UnitTests/System.Net.Security.Unit.Tests.csproj | 2 -- .../tests/FunctionalTests/System.Net.Sockets.Tests.csproj | 3 --- .../tests/misc/System.Xml.Linq.Misc.Tests.csproj | 2 -- .../Invariant/Invariant.Tests.csproj | 2 -- .../tests/System.Security.AccessControl.Tests.csproj | 2 -- .../tests/System.Security.Cryptography.Cng.Tests.csproj | 1 - .../tests/System.Security.Cryptography.Cose.Tests.csproj | 2 -- .../tests/System.Security.Cryptography.Csp.Tests.csproj | 1 - .../System.Threading/tests/System.Threading.Tests.csproj | 2 -- 23 files changed, 43 deletions(-) diff --git a/src/libraries/Microsoft.Extensions.Logging/tests/Common/Microsoft.Extensions.Logging.Tests.csproj b/src/libraries/Microsoft.Extensions.Logging/tests/Common/Microsoft.Extensions.Logging.Tests.csproj index 4bcf292b30240e..fbd4bfeda5a158 100644 --- a/src/libraries/Microsoft.Extensions.Logging/tests/Common/Microsoft.Extensions.Logging.Tests.csproj +++ b/src/libraries/Microsoft.Extensions.Logging/tests/Common/Microsoft.Extensions.Logging.Tests.csproj @@ -4,8 +4,6 @@ $(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent);$(NetFrameworkCurrent) true $(NoWarn);NU1511 - - false diff --git a/src/libraries/Microsoft.Win32.SystemEvents/tests/Microsoft.Win32.SystemEvents.Tests.csproj b/src/libraries/Microsoft.Win32.SystemEvents/tests/Microsoft.Win32.SystemEvents.Tests.csproj index dcb1317785c220..b853f5a2c9b655 100644 --- a/src/libraries/Microsoft.Win32.SystemEvents/tests/Microsoft.Win32.SystemEvents.Tests.csproj +++ b/src/libraries/Microsoft.Win32.SystemEvents/tests/Microsoft.Win32.SystemEvents.Tests.csproj @@ -3,8 +3,6 @@ $(NetCoreAppCurrent)-windows;$(NetFrameworkCurrent) true true - - false $(NetCoreAppCurrent)-windows;$(NetFrameworkCurrent) - - false diff --git a/src/libraries/System.Formats.Asn1/tests/System.Formats.Asn1.Tests.csproj b/src/libraries/System.Formats.Asn1/tests/System.Formats.Asn1.Tests.csproj index 8f556ae859d52e..ff25cf528f73e9 100644 --- a/src/libraries/System.Formats.Asn1/tests/System.Formats.Asn1.Tests.csproj +++ b/src/libraries/System.Formats.Asn1/tests/System.Formats.Asn1.Tests.csproj @@ -2,8 +2,6 @@ $(NetCoreAppCurrent);$(NetFrameworkCurrent) true - - false diff --git a/src/libraries/System.IO.MemoryMappedFiles/tests/System.IO.MemoryMappedFiles.Tests.csproj b/src/libraries/System.IO.MemoryMappedFiles/tests/System.IO.MemoryMappedFiles.Tests.csproj index 9817ac25c3d25c..15406d7bdf6227 100644 --- a/src/libraries/System.IO.MemoryMappedFiles/tests/System.IO.MemoryMappedFiles.Tests.csproj +++ b/src/libraries/System.IO.MemoryMappedFiles/tests/System.IO.MemoryMappedFiles.Tests.csproj @@ -3,8 +3,6 @@ true true $(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-unix;$(NetCoreAppCurrent)-browser - - false diff --git a/src/libraries/System.Net.Http.WinHttpHandler/tests/UnitTests/System.Net.Http.WinHttpHandler.Unit.Tests.csproj b/src/libraries/System.Net.Http.WinHttpHandler/tests/UnitTests/System.Net.Http.WinHttpHandler.Unit.Tests.csproj index 7b194c4d5d7efe..10c5a92561a0e1 100644 --- a/src/libraries/System.Net.Http.WinHttpHandler/tests/UnitTests/System.Net.Http.WinHttpHandler.Unit.Tests.csproj +++ b/src/libraries/System.Net.Http.WinHttpHandler/tests/UnitTests/System.Net.Http.WinHttpHandler.Unit.Tests.csproj @@ -7,7 +7,6 @@ $(DefineConstants);UNITTEST false - false diff --git a/src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj b/src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj index ffb36587a3da42..b699cc0dafd7fd 100644 --- a/src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj +++ b/src/libraries/System.Net.Http/tests/FunctionalTests/System.Net.Http.Functional.Tests.csproj @@ -12,7 +12,6 @@ true false - false diff --git a/src/libraries/System.Net.Http/tests/UnitTests/System.Net.Http.Unit.Tests.csproj b/src/libraries/System.Net.Http/tests/UnitTests/System.Net.Http.Unit.Tests.csproj index 289c7e4503ac15..be119816ef4532 100755 --- a/src/libraries/System.Net.Http/tests/UnitTests/System.Net.Http.Unit.Tests.csproj +++ b/src/libraries/System.Net.Http/tests/UnitTests/System.Net.Http.Unit.Tests.csproj @@ -4,8 +4,6 @@ true true $(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-unix;$(NetCoreAppCurrent)-browser;$(NetCoreAppCurrent)-osx;$(NetCoreAppCurrent)-maccatalyst;$(NetCoreAppCurrent)-ios;$(NetCoreAppCurrent)-tvos;$(NetCoreAppCurrent)-android - - false diff --git a/src/libraries/System.Net.Mail/tests/Functional/System.Net.Mail.Functional.Tests.csproj b/src/libraries/System.Net.Mail/tests/Functional/System.Net.Mail.Functional.Tests.csproj index f76076f49562b9..74c4b3dd6d1474 100644 --- a/src/libraries/System.Net.Mail/tests/Functional/System.Net.Mail.Functional.Tests.csproj +++ b/src/libraries/System.Net.Mail/tests/Functional/System.Net.Mail.Functional.Tests.csproj @@ -6,7 +6,6 @@ true true - false false diff --git a/src/libraries/System.Net.NameResolution/tests/FunctionalTests/System.Net.NameResolution.Functional.Tests.csproj b/src/libraries/System.Net.NameResolution/tests/FunctionalTests/System.Net.NameResolution.Functional.Tests.csproj index 214d0412473c7e..9741c993ccdba5 100644 --- a/src/libraries/System.Net.NameResolution/tests/FunctionalTests/System.Net.NameResolution.Functional.Tests.csproj +++ b/src/libraries/System.Net.NameResolution/tests/FunctionalTests/System.Net.NameResolution.Functional.Tests.csproj @@ -5,8 +5,6 @@ true true true - - false diff --git a/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/System.Net.NetworkInformation.Functional.Tests.csproj b/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/System.Net.NetworkInformation.Functional.Tests.csproj index 9ea75ff5d43175..afefb7a4fdeb67 100644 --- a/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/System.Net.NetworkInformation.Functional.Tests.csproj +++ b/src/libraries/System.Net.NetworkInformation/tests/FunctionalTests/System.Net.NetworkInformation.Functional.Tests.csproj @@ -6,9 +6,6 @@ true $(DefineConstants);NETWORKINFORMATION_TEST true - - false - false diff --git a/src/libraries/System.Net.Ping/tests/FunctionalTests/System.Net.Ping.Functional.Tests.csproj b/src/libraries/System.Net.Ping/tests/FunctionalTests/System.Net.Ping.Functional.Tests.csproj index a709b409e67158..abbe3153d0dd7c 100644 --- a/src/libraries/System.Net.Ping/tests/FunctionalTests/System.Net.Ping.Functional.Tests.csproj +++ b/src/libraries/System.Net.Ping/tests/FunctionalTests/System.Net.Ping.Functional.Tests.csproj @@ -4,8 +4,6 @@ true true true - - false diff --git a/src/libraries/System.Net.Primitives/tests/FunctionalTests/System.Net.Primitives.Functional.Tests.csproj b/src/libraries/System.Net.Primitives/tests/FunctionalTests/System.Net.Primitives.Functional.Tests.csproj index 77c0f80f8e5fc7..89ce40cdd2b1f2 100644 --- a/src/libraries/System.Net.Primitives/tests/FunctionalTests/System.Net.Primitives.Functional.Tests.csproj +++ b/src/libraries/System.Net.Primitives/tests/FunctionalTests/System.Net.Primitives.Functional.Tests.csproj @@ -3,9 +3,6 @@ true $(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-unix;$(NetCoreAppCurrent)-browser true - - false - false diff --git a/src/libraries/System.Net.Security/tests/FunctionalTests/System.Net.Security.Tests.csproj b/src/libraries/System.Net.Security/tests/FunctionalTests/System.Net.Security.Tests.csproj index 8345b73ce1d01d..e8c82b958c5b6b 100644 --- a/src/libraries/System.Net.Security/tests/FunctionalTests/System.Net.Security.Tests.csproj +++ b/src/libraries/System.Net.Security/tests/FunctionalTests/System.Net.Security.Tests.csproj @@ -7,7 +7,6 @@ true true - false false diff --git a/src/libraries/System.Net.Security/tests/UnitTests/System.Net.Security.Unit.Tests.csproj b/src/libraries/System.Net.Security/tests/UnitTests/System.Net.Security.Unit.Tests.csproj index ac48ac09355cd8..e5a8d164c8758f 100644 --- a/src/libraries/System.Net.Security/tests/UnitTests/System.Net.Security.Unit.Tests.csproj +++ b/src/libraries/System.Net.Security/tests/UnitTests/System.Net.Security.Unit.Tests.csproj @@ -12,8 +12,6 @@ $(NoWarn);3021 $(NetCoreAppCurrent)-windows;$(NetCoreAppCurrent)-unix;$(NetCoreAppCurrent)-browser;$(NetCoreAppCurrent)-osx;$(NetCoreAppCurrent)-ios;$(NetCoreAppCurrent)-android true - - false diff --git a/src/libraries/System.Net.Sockets/tests/FunctionalTests/System.Net.Sockets.Tests.csproj b/src/libraries/System.Net.Sockets/tests/FunctionalTests/System.Net.Sockets.Tests.csproj index 713f94260af165..6fdc8aa36a6974 100644 --- a/src/libraries/System.Net.Sockets/tests/FunctionalTests/System.Net.Sockets.Tests.csproj +++ b/src/libraries/System.Net.Sockets/tests/FunctionalTests/System.Net.Sockets.Tests.csproj @@ -6,9 +6,6 @@ true true true - - false - false diff --git a/src/libraries/System.Private.Xml.Linq/tests/misc/System.Xml.Linq.Misc.Tests.csproj b/src/libraries/System.Private.Xml.Linq/tests/misc/System.Xml.Linq.Misc.Tests.csproj index 3039a738284bb1..98ae2f27de78db 100644 --- a/src/libraries/System.Private.Xml.Linq/tests/misc/System.Xml.Linq.Misc.Tests.csproj +++ b/src/libraries/System.Private.Xml.Linq/tests/misc/System.Xml.Linq.Misc.Tests.csproj @@ -1,8 +1,6 @@ $(NetCoreAppCurrent) - - false diff --git a/src/libraries/System.Runtime/tests/System.Globalization.Tests/Invariant/Invariant.Tests.csproj b/src/libraries/System.Runtime/tests/System.Globalization.Tests/Invariant/Invariant.Tests.csproj index 10ee95f5fd23b9..7d444810c694cd 100644 --- a/src/libraries/System.Runtime/tests/System.Globalization.Tests/Invariant/Invariant.Tests.csproj +++ b/src/libraries/System.Runtime/tests/System.Globalization.Tests/Invariant/Invariant.Tests.csproj @@ -5,8 +5,6 @@ true true false - - false diff --git a/src/libraries/System.Security.AccessControl/tests/System.Security.AccessControl.Tests.csproj b/src/libraries/System.Security.AccessControl/tests/System.Security.AccessControl.Tests.csproj index 3083c95610dd86..05fd95a165f749 100644 --- a/src/libraries/System.Security.AccessControl/tests/System.Security.AccessControl.Tests.csproj +++ b/src/libraries/System.Security.AccessControl/tests/System.Security.AccessControl.Tests.csproj @@ -1,8 +1,6 @@ $(NetCoreAppCurrent)-windows - - false diff --git a/src/libraries/System.Security.Cryptography.Cng/tests/System.Security.Cryptography.Cng.Tests.csproj b/src/libraries/System.Security.Cryptography.Cng/tests/System.Security.Cryptography.Cng.Tests.csproj index ff89dfd4f689ea..cd5d165337e029 100644 --- a/src/libraries/System.Security.Cryptography.Cng/tests/System.Security.Cryptography.Cng.Tests.csproj +++ b/src/libraries/System.Security.Cryptography.Cng/tests/System.Security.Cryptography.Cng.Tests.csproj @@ -4,7 +4,6 @@ $(NetCoreAppCurrent)-windows false - false diff --git a/src/libraries/System.Security.Cryptography.Cose/tests/System.Security.Cryptography.Cose.Tests.csproj b/src/libraries/System.Security.Cryptography.Cose/tests/System.Security.Cryptography.Cose.Tests.csproj index 5dd8220ae0084d..c7bd4df0c7f3d6 100644 --- a/src/libraries/System.Security.Cryptography.Cose/tests/System.Security.Cryptography.Cose.Tests.csproj +++ b/src/libraries/System.Security.Cryptography.Cose/tests/System.Security.Cryptography.Cose.Tests.csproj @@ -5,8 +5,6 @@ true $(DefineConstants);EXCLUDE_PEM_ENCODING_FROM_TEST_DATA $(NoWarn);SYSLIB5006 - - false diff --git a/src/libraries/System.Security.Cryptography.Csp/tests/System.Security.Cryptography.Csp.Tests.csproj b/src/libraries/System.Security.Cryptography.Csp/tests/System.Security.Cryptography.Csp.Tests.csproj index f17e8530253482..93d7c38ad37dc4 100644 --- a/src/libraries/System.Security.Cryptography.Csp/tests/System.Security.Cryptography.Csp.Tests.csproj +++ b/src/libraries/System.Security.Cryptography.Csp/tests/System.Security.Cryptography.Csp.Tests.csproj @@ -7,7 +7,6 @@ false false - false diff --git a/src/libraries/System.Threading/tests/System.Threading.Tests.csproj b/src/libraries/System.Threading/tests/System.Threading.Tests.csproj index 9d6cc61f7dce1a..cb21b19ae3a8c9 100644 --- a/src/libraries/System.Threading/tests/System.Threading.Tests.csproj +++ b/src/libraries/System.Threading/tests/System.Threading.Tests.csproj @@ -4,8 +4,6 @@ true $(NetCoreAppCurrent) true - - false <_WasmPThreadPoolUnusedSize>10 From 95e6fdb9adc54f590b565293244fbfcf751d920b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Mon, 18 May 2026 04:14:12 -0700 Subject: [PATCH 2/2] Refactor CheckResumeFlag to use tlsResumed property --- .../tests/FunctionalTests/SslStreamAllowTlsResumeTests.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamAllowTlsResumeTests.cs b/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamAllowTlsResumeTests.cs index 34cb3b50901d12..140a486a178bca 100644 --- a/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamAllowTlsResumeTests.cs +++ b/src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamAllowTlsResumeTests.cs @@ -24,11 +24,15 @@ public class SslStreamTlsResumeTests "_connectionInfo", BindingFlags.Instance | BindingFlags.NonPublic); + private static PropertyInfo tlsResumed = + typeof(SslStream).Assembly.GetType("System.Net.Security.SslConnectionInfo") + .GetProperty("TlsResumed"); + private bool CheckResumeFlag(SslStream ssl) { // This works only on Debug build where SslStream has extra property so we can validate. object info = connectionInfo.GetValue(ssl); - return (bool)info.GetType().GetProperty("TlsResumed").GetValue(info); + return (bool)tlsResumed.GetValue(info); } [ConditionalTheory]