Skip to content

Fix HFA tests with interpreter #123818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janvorli merged 1 commit into from
Feb 2, 2026
Merged

Fix HFA tests with interpreter #123818

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/coreclr/vm/callstubgenerator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3194,13 +3194,14 @@ void CallStubGenerator::ProcessArgument(ArgIteratorType *pArgIt, ArgLocDesc& arg
m_s1 = argLocDesc.m_byteStackIndex;
m_s2 = m_s1 + argLocDesc.m_byteStackSize - 1;
}
else if ((argLocDesc.m_byteStackIndex == m_s2 + 1) && (argLocDesc.m_byteStackSize >= TARGET_POINTER_SIZE)
else if ((argLocDesc.m_byteStackIndex == m_s2 + 1) && (argLocDesc.m_byteStackSize >= TARGET_POINTER_SIZE) && IS_ALIGNED(m_s2 - m_s1 + 1, INTERP_STACK_SLOT_SIZE)
#ifdef ENREGISTERED_PARAMTYPE_MAXSIZE
&& (!pArgIt || !pArgIt->IsArgPassedByRef())
#endif // ENREGISTERED_PARAMTYPE_MAXSIZE
Comment thread
janvorli marked this conversation as resolved.
)
{
// Extend an existing range, but only if the argument is at least pointer size large.
// Extend an existing range, but only if the argument is at least pointer size large and
// the existing range end was aligned to interpreter stack slot size.
// The only case when this is not true is on Apple ARM64 OSes where primitive type smaller
// than 8 bytes are passed on the stack in a packed manner. We process such arguments one by
// one to avoid explosion of the number of pRoutines.
Expand Down
Loading