Skip to content

JIT/jit64 nullable valuetype tests (343) silently disabled by PR #120992 — no consolidating csproj #129105

@AndyAyersMS

Description

@AndyAyersMS

Note

This issue was generated by GitHub Copilot.

Summary

PR #120992 ("Consolidate some jit64 tests into less assemblies", merged 2025-10-24) deleted the per-test .csproj files under src/tests/JIT/jit64/valuetypes/nullable/box-unbox/ and .../nullable/castclass/ and modified the source files to add namespace declarations and [OuterLoop] attributes — preparation for merging the tests into consolidated assemblies. However, no consolidating .csproj was added for these two subtrees, so the tests no longer build and no longer run.

Net effect: 343 JIT regression tests are silently disabled (no build artifact, never executed in CI).

Affected files

193 source files under src/tests/JIT/jit64/valuetypes/nullable/box-unbox/:

Subdir .cs files .csproj files
box-unbox/ 43 0
enum/ 3 0
generics/ 43 0
interface/ 18 0
null/ 43 0
value/ 43 0

150 source files under src/tests/JIT/jit64/valuetypes/nullable/castclass/:

Subdir .cs files .csproj files
castclass/ 43 0
enum/ 3 0
generics/ 43 0
interface/ 18 0
null/ 43 0

(No .csproj or .ilproj anywhere under either subtree.)

Evidence

Sample modified file (box-unbox001.cs) shows the intended consolidation pattern: namespace box_unbox001; was added so the NullableTest class names wouldn't collide when merged. The [Fact] [OuterLoop] public static int TestEntryPoint() is still there — these are real, intended-to-run tests.

Suggested fix

Add two consolidating .csproj files (or one per subtree, mirroring the rtchecks.csproj style):

  • src/tests/JIT/jit64/valuetypes/nullable/box-unbox/box-unbox.csproj enumerating the 193 .cs files
  • src/tests/JIT/jit64/valuetypes/nullable/castclass/castclass.csproj enumerating the 150 .cs files

Both will also need to <Compile Include> the shared src/tests/JIT/jit64/valuetypes/nullable/structdef.cs (which defines Helper, ExitCode).

cc @jkoritzinsky (author of #120992)

Context

Discovered while sweeping the JIT test tree for wasm R2R failures (#128234) — noticed that several directories had .cs files with no enclosing project.

Metadata

Metadata

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMItest-bugProblem in test source code (most likely)

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions