Skip to content

Commit e77a105

Browse files
Copilotjkotas
andauthored
Delete MapViewOfFile/test1 PAL test (uses removed FILE_FLAG_NO_BUFFERING) (#129089)
`FILE_FLAG_NO_BUFFERING` was removed from the PAL headers, causing `MapViewOfFile/test1` to fail to compile on all non-Windows platforms. - Deleted `filemapping_memmgt/MapViewOfFile/test1/MapViewOfFile.cpp` and its directory - Removed the test entry from `CMakeLists.txt`, `compilableTests.txt`, `paltestlist.txt`, and `wasm/index.html` --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
1 parent 252fdb0 commit e77a105

5 files changed

Lines changed: 0 additions & 248 deletions

File tree

src/coreclr/pal/tests/palsuite/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,6 @@ add_executable_clr(paltests
177177
# filemapping_memmgt/GetProcAddress/test1/testlib.cpp
178178
filemapping_memmgt/GetProcAddress/test2/test2.cpp
179179
# filemapping_memmgt/GetProcAddress/test2/testlib.cpp
180-
filemapping_memmgt/MapViewOfFile/test1/MapViewOfFile.cpp
181180
filemapping_memmgt/MapViewOfFile/test2/MapViewOfFile.cpp
182181
filemapping_memmgt/MapViewOfFile/test3/MapViewOfFile.cpp
183182
filemapping_memmgt/MapViewOfFile/test4/mapviewoffile.cpp

src/coreclr/pal/tests/palsuite/compilableTests.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,6 @@ filemapping_memmgt/GetModuleFileNameW/test1/paltest_getmodulefilenamew_test1
113113
filemapping_memmgt/GetModuleFileNameW/test2/paltest_getmodulefilenamew_test2
114114
filemapping_memmgt/GetProcAddress/test1/paltest_getprocaddress_test1
115115
filemapping_memmgt/GetProcAddress/test2/paltest_getprocaddress_test2
116-
filemapping_memmgt/MapViewOfFile/test1/paltest_mapviewoffile_test1
117116
filemapping_memmgt/MapViewOfFile/test2/paltest_mapviewoffile_test2
118117
filemapping_memmgt/MapViewOfFile/test3/paltest_mapviewoffile_test3
119118
filemapping_memmgt/MapViewOfFile/test4/paltest_mapviewoffile_test4

src/coreclr/pal/tests/palsuite/filemapping_memmgt/MapViewOfFile/test1/MapViewOfFile.cpp

Lines changed: 0 additions & 244 deletions
This file was deleted.

src/coreclr/pal/tests/palsuite/paltestlist.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ filemapping_memmgt/CreateFileMappingW/test9/paltest_createfilemappingw_test9
104104
filemapping_memmgt/FreeLibrary/test2/paltest_freelibrary_test2
105105
filemapping_memmgt/GetModuleFileNameA/test2/paltest_getmodulefilenamea_test2
106106
filemapping_memmgt/GetModuleFileNameW/test2/paltest_getmodulefilenamew_test2
107-
filemapping_memmgt/MapViewOfFile/test1/paltest_mapviewoffile_test1
108107
filemapping_memmgt/MapViewOfFile/test2/paltest_mapviewoffile_test2
109108
filemapping_memmgt/MapViewOfFile/test3/paltest_mapviewoffile_test3
110109
filemapping_memmgt/MapViewOfFile/test4/paltest_mapviewoffile_test4

src/coreclr/pal/tests/palsuite/wasm/index.html

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ <h1>PAL Tests WASM</h1>
1313
"exception_handling/RaiseException", // 3 tests, we don't have stack unwinding available from C native code
1414
"file_io/WriteFile/test5/paltest_writefile_test5", // infinite loop
1515
"file_io/SetFilePointer/test7/paltest_setfilepointer_test7", // tries to allocate 4GB of memory in MEMFS when run with chromedriver
16-
"filemapping_memmgt/MapViewOfFile/test1/paltest_mapviewoffile_test1", // infinite loop and then chrome crashes
1716
"filemapping_memmgt/ProbeMemory/ProbeMemory_neg1/paltest_probememory_probememory_neg1",
1817
"miscellaneous/InterlockedCompareExchange/test2/paltest_interlockedcompareexchange_test2", // MT test
1918
"miscellaneous/InterlockedDecrement/test2/paltest_interlockeddecrement_test2", // MT test

0 commit comments

Comments
 (0)