Move event creation logic into SafeFileHandle.RentSyncWaitHandle

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/661f3798-57f4-4862-aef4-5bbca78c8924

Co-authored-by: adamsitnik <6011991+adamsitnik@users.noreply.github.com>

Author: Copilot

src/libraries/System.Private.CoreLib/src/Microsoft/Win32/SafeHandles/SafeFileHandle.OverlappedValueTaskSource.Windows.cs

@@ -21,8 +21,30 @@ public sealed partial class SafeFileHandle : SafeHandleZeroOrMinusOneIsInvalid
         internal OverlappedValueTaskSource GetOverlappedValueTaskSource() =>
             Interlocked.Exchange(ref _reusableOverlappedValueTaskSource, null) ?? new OverlappedValueTaskSource(this);
 
-        internal nint RentSyncWaitHandle() =>
-            Interlocked.Exchange(ref _reusableWaitHandle, -1);
+        internal nint RentSyncWaitHandle()
+        {
+            nint handle = Interlocked.Exchange(ref _reusableWaitHandle, -1);
+            if (handle != -1)
+            {
+                return handle;
+            }
+
+            using SafeWaitHandle safeHandle = Interop.Kernel32.CreateEventEx(
+                IntPtr.Zero,
+                null,
+                Interop.Kernel32.CREATE_EVENT_MANUAL_RESET,
+                (uint)(Interop.Kernel32.SYNCHRONIZE | Interop.Kernel32.EVENT_MODIFY_STATE));
+
+            if (safeHandle.IsInvalid)
+            {
+                throw Win32Marshal.GetExceptionForLastWin32Error();
+            }
+
+            handle = safeHandle.DangerousGetHandle();
+            safeHandle.SetHandleAsInvalid();
+
+            return handle;
+        }
 
         internal void ReturnSyncWaitHandle(nint waitHandle)
         {

src/libraries/System.Private.CoreLib/src/System/IO/RandomAccess.Windows.cs

@@ -67,7 +67,7 @@ _ when IsEndOfFile(errorCode, handle, fileOffset) => 0,
 
         private static unsafe int ReadSyncUsingAsyncHandle(SafeFileHandle handle, Span<byte> buffer, long fileOffset)
         {
-            IntPtr eventHandle = GetSyncOverlappedEvent(handle);
+            IntPtr eventHandle = handle.RentSyncWaitHandle();
             NativeOverlapped* overlapped = null;
 
             try
@@ -144,7 +144,7 @@ private static unsafe void WriteSyncUsingAsyncHandle(SafeFileHandle handle, Read
                 return;
             }
 
-            IntPtr eventHandle = GetSyncOverlappedEvent(handle);
+            IntPtr eventHandle = handle.RentSyncWaitHandle();
             NativeOverlapped* overlapped = null;
 
             try
@@ -686,31 +686,6 @@ private static async ValueTask WriteGatherAtOffsetMultipleSyscallsAsync(SafeFile
             }
         }
 
-        private static IntPtr GetSyncOverlappedEvent(SafeFileHandle safeFileHandle)
-        {
-            nint handle = safeFileHandle.RentSyncWaitHandle();
-            if (handle != -1)
-            {
-                return handle;
-            }
-
-            using SafeWaitHandle safeHandle = Interop.Kernel32.CreateEventEx(
-                IntPtr.Zero,
-                null,
-                Interop.Kernel32.CREATE_EVENT_MANUAL_RESET,
-                (uint)(Interop.Kernel32.SYNCHRONIZE | Interop.Kernel32.EVENT_MODIFY_STATE));
-
-            if (safeHandle.IsInvalid)
-            {
-                throw Win32Marshal.GetExceptionForLastWin32Error();
-            }
-
-            handle = safeHandle.DangerousGetHandle();
-            safeHandle.SetHandleAsInvalid();
-
-            return handle;
-        }
-
         private static unsafe NativeOverlapped* AllocNativeOverlappedWithEventHandle(SafeFileHandle handle, long fileOffset, IntPtr eventHandle)
         {
             NativeOverlapped* result = (NativeOverlapped*)NativeMemory.AllocZeroed((nuint)sizeof(NativeOverlapped));