Skip to content

Commit 815fa21

Browse files
akoeplingerlewing
andcommitted
Update EmsdkPackageVersion to use version from dependency flow (#128261)
It got hardcoded a while ago to workaround a build problem. --------- Co-authored-by: Larry Ewing <lewing@microsoft.com> (cherry picked from commit 58f1b03)
1 parent 8ccd798 commit 815fa21

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

eng/Versions.props

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,8 +164,10 @@
164164
<MicrosoftNativeQuicMsQuicSchannelVersion>2.4.18</MicrosoftNativeQuicMsQuicSchannelVersion>
165165
<SystemNetMsQuicTransportVersion>9.0.0-alpha.1.24167.3</SystemNetMsQuicTransportVersion>
166166
<!-- emscripten / Node -->
167+
<!-- we're using MicrosoftDotNetApiCompatTaskPackageVersion since the emscripten workload package ID contains a changing version. This one uses sdk-style feature band version numbers. -->
167168
<MicrosoftNETRuntimeEmscriptenVersion>$(MicrosoftDotNetApiCompatTaskPackageVersion)</MicrosoftNETRuntimeEmscriptenVersion>
168-
<EmsdkPackageVersion>10.0.0</EmsdkPackageVersion>
169+
<!-- we're using MicrosoftNETCoreAppRefPackageVersion since the emsdk package ID contains a changing version. This one uses runtime version numbers. -->
170+
<EmsdkPackageVersion>$(MicrosoftNETCoreAppRefPackageVersion)</EmsdkPackageVersion>
169171
<NodePackageVersion>$(runtimewinx64MicrosoftNETCoreRuntimeWasmNodeTransportPackageVersion)</NodePackageVersion>
170172
<!-- The package path for python in src/mono/mono.proj needs to be updated if this changes-->
171173
<EmsdkVersion>3.1.56</EmsdkVersion>

0 commit comments

Comments
 (0)