Skip to content

Commit 780e9ef

Browse files
Copilotjakobbotsch
andauthored
Add JIT-EE method placement guidance to jit.instructions.md
Co-authored-by: jakobbotsch <7887810+jakobbotsch@users.noreply.github.com>
1 parent 1547c9a commit 780e9ef

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

.github/instructions/jit.instructions.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,4 @@ applyTo: "src/coreclr/jit/**"
77
## Code Review Guidelines
88

99
- **Do not routinely request new targeted tests for pure refactors, mechanical cleanups, or other non-behavioral JIT codebase improvements.** JIT changes alter global codegen and are often validated by existing end-to-end suites and differential testing, so additional per-PR regression tests may not be needed for changes that do not affect observable behavior. However, targeted tests are appropriate and should be encouraged for bug fixes, changes with a clear repro, observable behavior changes, and previously untested edge cases that are not already covered by existing tests.
10+
- **Do not request that new JIT-EE (JIT-VM) interface methods be added at a specific position or in a particular ordering.** New JIT-EE methods can be added anywhere in the interface with any ordering without issues, so do not ask for them to be placed at the end, near similar signatures, or in any other particular location.

0 commit comments

Comments
 (0)