Skip to content

Commit 209ffcc

Browse files
Milos KotlarCopilot
andcommitted
Re-apply detection->pat_pool manual lock patch; clarify area-skill paths
- Lock files: gh aw compile only wires pat_pool into the 'agent' job's needs, not 'detection', even though the detection job reads needs.pat_pool.outputs.pat_number. Without it the COPILOT_GITHUB_TOKEN case() collapses to an empty token and threat detection fails. Re-add '- pat_pool' to detection.needs in all three locks with the same documented MANUAL PATCH block used on main (gh-aw issue #30232). - area-skills.instructions.md: clarify that table skill paths are relative to .github/skills/ and mark the NativeAOT entry as a repo-root path, so an agent cannot misread them as nonexistent repo-root-relative skill paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 1658fa9 commit 209ffcc

4 files changed

Lines changed: 63 additions & 5 deletions

File tree

.github/workflows/ci-failure-fix.lock.yml

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/ci-failure-scan-feedback.lock.yml

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/ci-failure-scan.lock.yml

Lines changed: 18 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/shared/area-skills.instructions.md

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,26 @@ need to route a failure, a review, or a change to the right area knowledge
66
should reference this table instead of re-declaring their own copy, so the
77
mapping stays consistent as skills are added or renamed.
88

9-
Skills live under `.github/skills/<name>/SKILL.md`. Area-owner handles are
10-
**not** listed here; resolve owners from
11-
[`docs/area-owners.md`](../../../docs/area-owners.md) by the issue's `area-*`
12-
label.
9+
Skill paths in the table below are relative to `.github/skills/`, so
10+
`mobile-platforms/SKILL.md` means `.github/skills/mobile-platforms/SKILL.md`.
11+
The one non-skill entry (NativeAOT) is given as a repo-root-relative path and is
12+
called out as such. Area-owner handles are **not** listed here; resolve owners
13+
from [`docs/area-owners.md`](../../../docs/area-owners.md) by the issue's
14+
`area-*` label.
1315

1416
<a id="area-skill-table"></a>
1517

1618
## Area → skill table
1719

20+
Skill paths are relative to `.github/skills/`.
21+
1822
| Area / pipeline | Skill(s) | What the skill covers |
1923
|---|---|---|
2024
| Mobile (ios / tvos / maccatalyst / android / wasm / wasi) | `mobile-platforms/SKILL.md` | Mobile/wasm test, csproj, and platform-condition knowledge. |
2125
| JIT / GC / PGO stress (codegen) | `jit-regression-test/SKILL.md`; `ci-pipeline-monitor/SKILL.md` | JIT codegen, assertion triage, regression-test extraction. |
2226
| `System.Net.*` | `system-net-review/SKILL.md` | Networking stack review and conventions. |
2327
| `Microsoft.Extensions.*` | `extensions-review/SKILL.md` | Extensions (DI, config, logging, hosting, caching) review. |
24-
| NativeAOT outer loop | `eng/testing/tests.*aot*.targets` + the test `.csproj` | NativeAOT test wiring (no dedicated skill; read the targets). |
28+
| NativeAOT outer loop | repo-root `eng/testing/tests.*aot*.targets` + the test `.csproj` | NativeAOT test wiring (no dedicated skill; read the targets). |
2529
| Generic / unmapped | `ci-pipeline-monitor/SKILL.md` | Cross-cutting CI pipeline monitoring and triage. |
2630

2731
When more than one skill is listed, load them in order; the first carries the

0 commit comments

Comments
 (0)