Commit 7340c9a
Clarify NegotiateAuthentication.IsAuthenticated post-failure behavior (#12724)
* Clarify NegotiateAuthentication.IsAuthenticated post-failure behavior
The IsAuthenticated property returns true after the authentication exchange has finished, including in many post-negotiation failure cases (verified across the Windows, Unix, and ManagedSpnego PAL implementations in dotnet/runtime). The previous summary (successfully completed and the session was established) implied that a true value means successful authentication, which is misleading.
Update the summary, value, and remarks to clarify that callers must inspect the NegotiateAuthenticationStatusCode returned by GetOutgoingBlob to determine actual success.
Also remove a misleading `(see IsAuthenticated)` reference on TargetName that reinforced the same misconception.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>1 parent 65991f8 commit 7340c9a
1 file changed
Lines changed: 14 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
287 | 287 | | |
288 | 288 | | |
289 | 289 | | |
290 | | - | |
291 | | - | |
292 | | - | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
293 | 303 | | |
294 | 304 | | |
295 | 305 | | |
| |||
544 | 554 | | |
545 | 555 | | |
546 | 556 | | |
547 | | - | |
| 557 | + | |
548 | 558 | | |
549 | 559 | | |
550 | 560 | | |
| |||
0 commit comments