Skip to content

Last flow detection not working properly when last backflow is from a different branch than the one we're forward flowing to #6390

Description

@dkurepa

In dotnet/dotnet#7141, we weren't using the correct direction algorithm because we re not detecting that the last backflow was coming from a different branch than the one we were forward flowing to.
This detection happens in

if (!headBranchExisted && !await vmr.IsAncestorCommit(lastBackflow.VmrSha, currentVmrSha))
but it failed because in a local flow, the head branch always exists.

I can't remember why we added it at the time of writing this, but I know there was a bug where an existing FF PR couldn't get an opposite direction flow if the PR already existed.

Apparently that caused this bug now

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions