zh-hant translation via DeepL returns zh-hans

[Raffael16]

With resource files
*.zh-Hans.resx
*.zh-Hant.resx

the translation via DeepL (https://api-free.deepl.com/v2/translate)
always gives me simplified chinese translations for both languages (source e.g. english).

When I do a manual API-call via Powershell, I get different results for
"target_lang" = "ZH-HANS"
"target_lang" = "ZH-HANT"

I would expect, that the resource localization is passed to DeepL, giving me different results (characters) for those languages.

[tom-englert]

The DeepL translator was a community contribution, so I'm not deeply involved. However it looks like this assumption is outdated:

ResXResourceManager/src/ResXManager.Translators/DeepLTranslator.cs

Lines 121 to 125 in dc6d956

	private static string DeepLLangCode(CultureInfo cultureInfo)
	{
	var iso1 = cultureInfo.TwoLetterISOLanguageName;
	return iso1;
	}

Can you check what is the correct way to specify languages in the DeepL-API?

[Raffael16]

According to the API documentation (v2), available languages can be retrieved via
https://api.deepl.com/v2/languages?type=target
This returns a list that includes all the two letter codes as well as some longer codes to differentiate:
ZH Chinese (simplified)
ZH-HANS Chinese (simplified)
ZH-HANT Chinese (traditional)
ZU Zulu

So, for the given case, it should be sufficient to just use Culture.Name to get the correct translation. But a problem arrises is you have a subculture that is not supported by Deepl.

en (without subculture), en-GB and en-US work without problems, but something like en-CA gives Bad Request (400).

If this is acceptable, DeepLLangCode() should just return Culture.Name. If not, there might be the need for some fallback mechanism. How is this handled for other translation providers?

[tom-englert]

E.g. like this:

https://github.com/dotnet/ResXResourceManager/blob/master/src%2FResXManager.Translators%2FGoogleTranslatorLite.cs#L61-L74

[Raffael16]

Ok, then maybe just add whats needed here.

ResXResourceManager-5be0131-Enable DeepL translations for Traditional Chinese (zh-Hant).patch

[tom-englert]

Can you provide a PR, please?