Missing unimpaired mapping [p

[BlueDrink9]

Describe your request

This has already been implemented by evil-collection, but even with evil-collection unpinned I still haven't received the new behavior. Since Doom handles its own implementation of unimpaired, I thought it might be worth raising an issue.

I'm greatly missing the keybinding [p for a linewise paste on the previous line, without having to move the cursor there or create a new line.

From unimpaired.txt:

These are experimental:

*>p*    Paste after linewise, increasing indent.
*>P*    Paste before linewise, increasing indent.
*<p*    Paste after linewise, decreasing indent.
*<P*    Paste before linewise, decreasing indent.
*=p*    Paste after linewise, reindenting.
*=P*    Paste before linewise, reindenting.

|]p|, |[p|, |[P|, and |]P| have also been remapped to force linewise pasting,
while preserving their usual indent matching behavior.

Briefly explain its use-case

From the middle of a line, paste without having to create a new line for it

[adolfocorreia]

As a suggestion/workaround, I have this in my config.el:

;; Provide paste above ([p) and below (]p) unimpaired mappings in evil-mode.
;; Reference: evil-unimpaired.el / Spacemacs
(defun evil-unimpaired-paste-above ()
  (interactive)
  (evil-insert-newline-above)
  (evil-paste-after 1 evil-this-register))
(defun evil-unimpaired-paste-below ()
  (interactive)
  (evil-insert-newline-below)
  (evil-paste-after 1 evil-this-register))
(after! evil
        (map!
         :n "[p" #'evil-unimpaired-paste-above
         :n "]p" #'evil-unimpaired-paste-below))

[BlueDrink9]

Yeah, that's the obvious solution. It just seems odd to replicate evil-collection within Doom in the first place, but if that's the route we're going down, may as well do it properly.

I should open a PR if I get time

[archiif]

(setq evil-collection-want-unimpaired-p t)

Then, restart Doom.

[anihm136]

On a slightly unrelated note, I realised that the evil-collection implementation of linewise pasting does not exactly show the same behavior as unimpaired, which results in newlines being added above/below the pasted lines pretty frequently. To fix that, I came up with these functions which do exactly what unimpaired does in vim. They work well for me, consider giving it a try if you feel the same way

(defun +ani/evil-unimpaired-paste-above ()
  (interactive)
  (let ((register (if evil-this-register
                      evil-this-register
                    ?\")))
    (when (not (member 'evil-yank-line-handler (get-text-property 0 'yank-handler (evil-get-register register))))
      (evil-insert-newline-above))
    (evil-paste-before 1 register)))

(defun +ani/evil-unimpaired-paste-below ()
  (interactive)
  (let ((register (if evil-this-register
                      evil-this-register
                    ?\")))
    (when (not (member 'evil-yank-line-handler (get-text-property 0 'yank-handler (evil-get-register register))))
      (evil-insert-newline-below))
    (evil-paste-after 1 register)))

[BlueDrink9]

(setq evil-collection-want-unimpaired-p t)

Then, restart Doom.

This is what I have atm, but there are a handful of unimpaired things that override default doom mappings, which is annoying. I would much rather a setting that controls whether doom mappings override base unimpaired, I.e. have base unimpaired for most things and let doom override what it wants.