evil-mc and orgmode new line

[felixmueh]

What did you expect to happen?
...
while using evil-mc and having multiple cursors active things like opening a new line with o in normal mode or jumping to the end of the line with A in normal mode or pressing RET in insert mode should happen to all cursors.

What actually happened?
...
Only the main cursor opens a new line / moves to the end of the line.

Additional details:
Bug persists in doom sandbox

Steps to reproduce:

1. Enable ormode
2. Enable multi-mc
3. Create multiple cursors
4. Press A to move to end of line or press o to open a new line or press RET in insert mode to open a new line.

System information:

SYSTEM  type       gnu/linux
        config     x86_64-pc-linux-gnu
        shell      /usr/bin/fish
        uname      Linux 5.9.14-arch1-1 #1 SMP PREEMPT Sat, 12 Dec 2020 14:37:12 +0000 x86_64
        path       (/usr/local/sbin /usr/local/bin /usr/bin /usr/bin/site_perl /usr/bin/vendor_perl /usr/bin/core_perl /usr/lib/emacs/27.1/x86_64-pc-linux-gnu)
EMACS   dir        ~/.emacs.d/
        version    27.1
        build      Aug 28, 2020
        buildopts  --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=gtk3 --with-xft --with-wide-int --with-modules --with-cairo --with-harfbuzz 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fno-plt' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now
        features   XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 GMP
        traits     (gui server-running)
DOOM    dir        ~/bassconf/doom/.doom.d/
        version    2.0.9
        font       #<font-spec nil nil monospace nil nil nil nil nil 14 nil nil nil nil>
        theme      doom-solarized-dark
        build      HEAD -> develop 0c9256411 2020-12-15 04:14:40 -0500
        elc-files  0
        modules    (:completion (company +tng) ivy :ui doom doom-quit hl-todo modeline nav-flash ophints (popup +defaults) treemacs vc-gutter vi-tilde-fringe workspaces :editor (evil +everywhere) file-templates fold multiple-cursors snippets :emacs dired electric vc undo :term eshell :checkers syntax :tools debugger (eval +overlay) lookup lsp magit pdf :lang (cc +lsp) csharp data emacs-lisp (haskell +lsp) (java +meghanada) javascript latex markdown (org +present) (python +lsp) (sh +fish) :config (default +bindings +smartparens))
        packages   ((arduino-mode :recipe (:host github :repo bookest/arduino-mode)) (peep-dired) (company-jedi) (rainbow-mode))
        unpin      (n/a)
        elpa       (n/a)

[helpotters]

Any updates on this? Is this just an upstream issue with evil-mc?

[hlissner]

Sorry for the late response; I haven't had time to look into deeply into this and likely won't get around to this soon, but:

The issue is that evil-mc takes a whitelist approach to what commands can be mirrored to its active cursors. Its whitelist is kept in the variable evil-mc-custom-known-commands. I presume whatever command is bound to o (in normal mode) or RET (in insert mode) needs to be added to that whitelist.

[ml729]

hlissner's solution works. The problem was some normal mode keys are replaced with evil-org functions (e.g. 'o' is bound to evil-org-open-below), which evil-mc did not have support for by default. So you can add them yourself in your config, e.g.

(setq evil-mc-evil-org-functions '((evil-org-insert-line . ((:default . evil-mc-execute-default-call-with-count)))
    (evil-org-append-line . ((:default . evil-mc-execute-default-call-with-count)))
    (evil-org-open-below . ((:default . evil-mc-execute-default-call-with-count)))
    (evil-org-open-above . ((:default . evil-mc-execute-default-call-with-count)))))
(dolist (x evil-mc-evil-org-functions) (add-to-list 'evil-mc-custom-known-commands x))

(I submitted a pull request to evil-mc to add support for these by default.)

[ml729]

For the issue with RET, you need to take an extra step because in Doom's evil-org-mode map, RET is bound to lambda function (cmd! (org-return electric-indent-mode)) so you can't just add its name to the whitelist.
So the hack-y way around is to name it and rebind RET to the named version, e.g.

(fset 'doom-insert-org-return (cmd! (org-return electric-indent-mode)))
(map! :map evil-org-mode-map
      :i "RET" #'doom-insert-org-return
      :i [return] #'doom-insert-org-return)

and then you can add doom-insert-org-return to the whitelist, as in the above post.