Skip to content

Unnecessary quotation marks? #21

Description

@ScottFreeCode

On Windows, this is passing '""' as the first argument to start to avoid start interpreting a quoted filename as the title of a console window. As it turns out, this seems to be automatically escaped just like the filename itself: if I run opener cmd, I get a cmd window with the title \\ (I guess the quotes disappear but the attempt to escape them does not), whereas if I change '""' to just '' or "" I get a cmd window with no title as expected. This does not appear to affect running any actual file/url one way or the other (opener "some file" still works right), so it doesn't really matter as far as functionality, but I wanted to point it out as far as theoretical correctness goes. File under "fun fact" I guess.

(It also seems that instead of a blank window title, an actual window title could be given; but I'm not sure that's useful, between the fact that there are better ways to open a console from Node and the fact that a blank window title would be odd but not confusing whereas any name hardcoded in opener could be irrelevant in whatever hypothetical usage did cause cmd to be opened through opener.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions