Namespace the `theme` localStorage key (django.admin.theme) to avoid clashing with main project localStorage

[mkst]

Code of Conduct

• I agree to follow Django's Code of Conduct

Feature Description

Rename the localStorage key for the /admin page from theme to django.admin.theme

Problem

We use the theme localStorage for our site, decomp.me. We expect the value to be a json string (e.g. "auto", "light" or "dark", etc). When visiting the /admin panel, our localStorage value is stomped on and instead auto is set (no quotes). We have worked around the fact that this is not JSON (and so we fallback to "auto"), but this still stomps on our users preferences.

Request or proposal

proposal

Additional Details

No response

Implementation Suggestions

I have a branch with the change: https://github.com/django/django/compare/main...mkst:django:namespace-admin-theme-key?expand=1

[github-actions]

Thank you mkst for sharing your idea! We have a lot of them so please be patient. You can see the current queue here.

Community instructions

For commenters, please use the emoji reactions on the issue to express support, and/or concern easily. Please use the comments to ask questions or contribute knowledge about the idea. It is unhelpful to post comments of "I'd love this" or "What's the state of this?"

Reaction Guide

• 👍 This is something I would use
• 👎 This is something that would cause problems for me or Django
• 😕 I’m indifferent to this
• 🎉 This is an easy win

[knyghty]

It will cause some minor annoyance for users after the upgrade but it probably makes sense to namespace not just this but our other use(s) of local storage

[codingjoe]

If we introduce a prefix strategy, we could try to make it consistent. The language and session cookie come to mind here.

That aside, I am not a big fan of the feature as a whole. IMHO, the added complexity of setting themes per app and overriding the OS default is bloat. Adding to this is that the current implementation isn't based on color-scheme.

Bottom line, I'd prefer to remove the toggle.

[jacobtylerwalls]

This sounds like a bug fix?