From c90f170ac682b447ce7ea4164bdbb08d87e35db5 Mon Sep 17 00:00:00 2001 From: marcustyphoon Date: Sat, 3 Jan 2026 00:32:33 -0800 Subject: [PATCH 1/2] data: Fix previous commit --- src/assets/modifierdata/necromancer.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/assets/modifierdata/necromancer.yaml b/src/assets/modifierdata/necromancer.yaml index 94b92ee49..ed061e833 100644 --- a/src/assets/modifierdata/necromancer.yaml +++ b/src/assets/modifierdata/necromancer.yaml @@ -28,7 +28,7 @@ amountData: label: '% of non-shroud' default: 0 - defaultInput: 100 + defaultInput: ??? quantityEntered: 100 modifiers: attributes: From 60d3d379c24124c69254521d50622008c3f42b5e Mon Sep 17 00:00:00 2001 From: marcustyphoon Date: Sat, 3 Jan 2026 00:33:18 -0800 Subject: [PATCH 2/2] implement --- locales/en/translation.json | 2 +- src/assets/modifierdata/necromancer.yaml | 15 ++++++++++----- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/locales/en/translation.json b/locales/en/translation.json index cb1ce5975..879926b9d 100644 --- a/locales/en/translation.json +++ b/locales/en/translation.json @@ -1178,7 +1178,7 @@ "traitNote_Leeching venoms siphons applied by allies use allies' power stats, so they are not implemented.": "Leeching venoms siphons applied by allies use allies' power stats, so they are not implemented.", "traitNote_Natural Fortitude Unleashed Ambush lifesteal damage may be omitted in arcdps area stats or parsed arcdps logs.": "Natural Fortitude Unleashed Ambush lifesteal damage may be omitted in arcdps area stats or parsed arcdps logs.", "traitNote_Non-100% Chaotic Potency with-staff values combined with Toxic Maintenance Oil/Enhanced Lucent Oil result in inconsistent boon duration between weapon sets, which will be averaged.": "Non-100% Chaotic Potency with-staff values combined with Toxic Maintenance Oil/Enhanced Lucent Oil result in inconsistent boon duration between weapon sets, which will be averaged.", - "traitNote_Signet of Spite non-100% uptime (i.e. on any build that uses shroud rotation) is currently simulated poorly (as a fractional affect both in and out of shroud).\n\nNightmare Weapon stacks on allies are affected by ally lifesteal damage/all damage modifiers like Soul Barbs, Relic of Atrocity, Lead Attacks, and numerous revenant traits.": "Signet of Spite non-100% uptime (i.e. on any build that uses shroud rotation) is currently simulated poorly (as a fractional affect both in and out of shroud).\n\nNightmare Weapon stacks on allies are affected by ally lifesteal damage/all damage modifiers like Soul Barbs, Relic of Atrocity, Lead Attacks, and numerous revenant traits.", + "traitNote_Signet of Spite is automatically applied only to non-shroud damage; for its uptime, enter the percentage of the *time when not in shroud* that it is active (i.e. 100%, if it's never cast). However, for Signet of Vampirism uptime, enter the percentage of the *total combat time* that it is active (100 - percent of time spent in shroud, if it's never cast).\n\nNightmare Weapon stacks on allies are affected by ally lifesteal damage/all damage modifiers like Soul Barbs, Relic of Atrocity, Lead Attacks, and numerous revenant traits.": "Signet of Spite is automatically applied only to non-shroud damage; for its uptime, enter the percentage of the *time when not in shroud* that it is active (i.e. 100%, if it's never cast). However, for Signet of Vampirism uptime, enter the percentage of the *total combat time* that it is active (100 - percent of time spent in shroud, if it's never cast).\n\nNightmare Weapon stacks on allies are affected by ally lifesteal damage/all damage modifiers like Soul Barbs, Relic of Atrocity, Lead Attacks, and numerous revenant traits.", "traitNote_The durations of transferred self conditions (cannon backfire + generosity sigil) aren't simulated correctly.": "The durations of transferred self conditions (cannon backfire + generosity sigil) aren't simulated correctly.", "traitNote_The durations of transferred self conditions (plague sending, dagger 4, staff 4) aren't simulated correctly.": "The durations of transferred self conditions (plague sending, dagger 4, staff 4) aren't simulated correctly.", "traitNote_Vampiric Slash lifesteal damage may not be shown in arcdps area stats or parsed arcdps logs.": "Vampiric Slash lifesteal damage may not be shown in arcdps area stats or parsed arcdps logs.", diff --git a/src/assets/modifierdata/necromancer.yaml b/src/assets/modifierdata/necromancer.yaml index ed061e833..7b13675a5 100644 --- a/src/assets/modifierdata/necromancer.yaml +++ b/src/assets/modifierdata/necromancer.yaml @@ -1,7 +1,9 @@ - section: Skills note: >- - Signet of Spite non-100% uptime (i.e. on any build that uses shroud rotation) is currently simulated poorly - (as a fractional affect both in and out of shroud). + Signet of Spite is automatically applied only to non-shroud damage; for its uptime, enter the percentage + of the *time when not in shroud* that it is active (i.e. 100%, if it's never cast). However, for Signet of + Vampirism uptime, enter the percentage of the *total combat time* that it is active (100 - percent of time + spent in shroud, if it's never cast). Nightmare Weapon stacks on allies are affected by ally lifesteal damage/all damage modifiers like Soul @@ -21,21 +23,24 @@ Flat DPS: 1 temporaryBuff: true - # kind of inaccurate; shouldn't apply in shroud and shouldn't affect "alternative power" + # doesn't apply in shroud and thus shouldn't affect "alternative power" + # offsetting buff values do this + # users must enter percent-of-time-not-in-shroud rather than percent of combat time - id: signet-of-spite text: Signet of Spite subText: when not in shroud amountData: label: '% of non-shroud' - default: 0 - defaultInput: ??? + default: 100 quantityEntered: 100 modifiers: attributes: Power: [180, buff] + Alternative Power: [-180, buff] gw2id: 10622 temporaryBuff: activeOutOfCombat + # users must enter percent of combat time - id: signet-of-vampirism text: Signet of Vampirism subText: passive