Skip to content

Commit c83e2d6

Browse files
committed
chore: drop server-internal terminology from public-facing artifacts
Public docstrings, comments, and test method names previously leaked server-side implementation hints (the V3 form / model-level / form- level distinction, V35 short-form tag) that exposed engine details beyond the API contract. Rephrase them to describe externally observable server behaviour only — 'the server returns 422 for ...' in place of 'the server's V3 form rejects (model-level/form-level)' — and rename the V35 test method to a name that describes the test's behaviour rather than a server-internal version label.
1 parent 70a08ad commit c83e2d6

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

tests/resources/voice-in-trunks.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -293,13 +293,13 @@ describe('TrunkConfiguration serialization', () => {
293293
});
294294

295295
it('disable patch sends enabled_sip_registration:false + host + use_did_in_ruri:false together', async () => {
296-
// The disable flow is a multi-field PATCH because the server's V3
297-
// form rejects (422) any request that flips
296+
// The disable flow is a multi-field PATCH because the server
297+
// returns 422 for any request that flips
298298
// `enabled_sip_registration` to false without simultaneously
299-
// providing a non-blank `host` (model-level presence) and
300-
// `use_did_in_ruri: false` (form-level). Lock those three fields
301-
// in the same request body — nock's body matcher rejects the
302-
// request if any of them is missing or has the wrong value.
299+
// providing a non-blank `host` and `use_did_in_ruri: false`.
300+
// Lock those three fields in the same request body — nock's body
301+
// matcher rejects the request if any of them is missing or has
302+
// the wrong value.
303303
const client = setupClient('voice_in_trunks/disable_sip_registration.yaml');
304304
const result = await client.voiceInTrunks().update({
305305
id: '57a939dd-1600-41a6-80b1-f624e22a1f4c',

0 commit comments

Comments
 (0)