refactor(core): align websocket runtime logger contract

Author: devstd2211

ACTIVE_REFACTOR_PLAN.md

@@ -41,21 +41,16 @@ Historical detail is archived elsewhere and should not be copied here.
 9. Do not run separate test-only cleanup campaigns.
 
 ## Latest Completed
-- 2026-05-28: completed `packages/core/src/interfaces/IRuntimeSources.ts runtime source contract consolidation follow-up`.
-- 2026-05-28: completed `packages/core/src/interfaces/ITradingBotServices.ts trading bot service contract consolidation follow-up`.
-- 2026-05-28: completed `packages/core/src/interfaces/IBotInitializerServices.ts initializer service contract consolidation follow-up`.
-- Canonical narrow runtime slices now live in the consumer-facing interface files, and `IRuntimeSources.ts` reuses them instead of repeating inline `Pick` contracts.
-- The initializer runtime contract now makes exchange, market-data, execution, session, and resilience ownership explicit while preserving adapter compatibility with the broader runtime source state.
-- Functional/source guardrails now pin the shared runtime contract layer, and related runtime-source tests now read exchange ownership from the top-level runtime source contract.
+- 2026-05-28: completed `packages/core/src/interfaces/IWebSocketEventHandlerServices.ts websocket handler contract consolidation follow-up`.
+- The websocket handler contract now follows the same ownership model as the other runtime slices by exposing `coreServices.logger` instead of a standalone logger field.
+- Adapter and functional guardrail coverage now pin the narrowed websocket runtime boundary so consumers keep reusing the shared core logger through the grouped contract.
 
 ## Latest Verification
-- 2026-05-28: `npm test -- --runInBand runtime-contracts.functional.test.ts runtime-service-adapters.functional.test.ts bot-initializer.test.ts services/bot-initializer.functional.test.ts bot-factory.test.ts services/bot-factory.service.test.ts services/bot-factory.error-handling.test.ts` (7 suites, 97 tests)
-- 2026-05-28: `npm test -- --runInBand position-monitor` (4 suites, 54 tests)
-- 2026-05-28: `npm run build`
+- 2026-05-28: `npm test -- --runInBand runtime-service-adapters.functional.test.ts services/websocket-event-handler.functional.test.ts` (2 suites, 7 tests)
 
 ## Next Step
 - Continue with the next active component from `REFACTOR_COMPONENT_CHECKLIST.md`.
-- Start with `packages/core/src/interfaces/IWebSocketEventHandlerServices.ts websocket handler contract consolidation follow-up`.
+- Start with `packages/core/src/factories/create-runtime-bundle.ts runtime bundle assembly boundary follow-up`.
 - Keep the next batch component-sized: each active item should be a real runtime/initializer/websocket boundary slice, not a single-line alias or naming-only task.
 
 ## Archive

NEXT_SESSION_PROMPT.md

@@ -14,9 +14,9 @@ Work directly on local `main`. Do not create worktrees. If the current branch is
 
 ## Current Batch
 Start with these three active queue items:
-1. `packages/core/src/interfaces/IWebSocketEventHandlerServices.ts websocket handler contract consolidation follow-up`
-2. `packages/core/src/factories/create-runtime-bundle.ts runtime bundle assembly boundary follow-up`
-3. `packages/core/src/bot-factory.ts runtime bundle handoff boundary follow-up`
+1. `packages/core/src/factories/create-runtime-bundle.ts runtime bundle assembly boundary follow-up`
+2. `packages/core/src/bot-factory.ts runtime bundle handoff boundary follow-up`
+3. `packages/core/src/factories/create-trading-bot-runtime.ts runtime factory boundary follow-up`
 
 If one of these turns out to be too small, merge it with the next adjacent runtime,
 initializer, or websocket boundary item from `REFACTOR_COMPONENT_CHECKLIST.md` and keep
@@ -53,13 +53,12 @@ After all three slices are complete:
 5. Commit the batch after tests, smoke, build, and docs updates pass.
 
 ## Last Completed
+- 2026-05-28: completed `packages/core/src/interfaces/IWebSocketEventHandlerServices.ts websocket handler contract consolidation follow-up`.
 - 2026-05-28: completed `packages/core/src/interfaces/IRuntimeSources.ts runtime source contract consolidation follow-up`.
 - 2026-05-28: completed `packages/core/src/interfaces/ITradingBotServices.ts trading bot service contract consolidation follow-up`.
 - 2026-05-28: completed `packages/core/src/interfaces/IBotInitializerServices.ts initializer service contract consolidation follow-up`.
+- The websocket runtime contract now reuses `coreServices.logger` instead of flattening logger ownership, keeping the grouped runtime boundary consistent across TradingBot, BotInitializer, and WebSocketEventHandlerManager.
 - Canonical narrow runtime slices now live in the consumer-facing interface files, and `IRuntimeSources.ts` now reuses them instead of repeating inline runtime `Pick` contracts.
-- Adapter compatibility remains intact for the broader bot factory runtime source while initializer/runtime tests now read exchange ownership from the top-level runtime source contract.
 
 ## Last Verification
-- `npm test -- --runInBand runtime-contracts.functional.test.ts runtime-service-adapters.functional.test.ts bot-initializer.test.ts services/bot-initializer.functional.test.ts bot-factory.test.ts services/bot-factory.service.test.ts services/bot-factory.error-handling.test.ts`
-- `npm test -- --runInBand position-monitor`
-- `npm run build`
+- `npm test -- --runInBand runtime-service-adapters.functional.test.ts services/websocket-event-handler.functional.test.ts`

REFACTOR_COMPONENT_CHECKLIST.md

@@ -15,7 +15,6 @@ Legend:
 - `func` = functional test exists
 
 ## Active Components
-- [ ] `packages/core/src/interfaces/IWebSocketEventHandlerServices.ts websocket handler contract consolidation follow-up`
 - [ ] `packages/core/src/factories/create-runtime-bundle.ts runtime bundle assembly boundary follow-up`
 - [ ] `packages/core/src/bot-factory.ts runtime bundle handoff boundary follow-up`
 - [ ] `packages/core/src/factories/create-trading-bot-runtime.ts runtime factory boundary follow-up`

REFACTOR_COMPONENT_CHECKLIST_ARCHIVE.md

@@ -3,6 +3,7 @@
 Archived completed items moved out of REFACTOR_COMPONENT_CHECKLIST.md to keep the active queue short.
 
 ## Completed History
+- [x] `packages/core/src/interfaces/IWebSocketEventHandlerServices.ts websocket handler contract consolidation follow-up` | prod: yes | tests: yes | func: yes
 - [x] `packages/core/src/interfaces/IRuntimeSources.ts runtime source contract consolidation follow-up` | prod: yes | tests: yes | func: yes
 - [x] `packages/core/src/interfaces/ITradingBotServices.ts trading bot service contract consolidation follow-up` | prod: yes | tests: yes | func: yes
 - [x] `packages/core/src/interfaces/IBotInitializerServices.ts initializer service contract consolidation follow-up` | prod: yes | tests: yes | func: yes

packages/core/src/__tests__/runtime-service-adapters.functional.test.ts

@@ -80,10 +80,13 @@ describe('runtime dependency adapter boundary', () => {
       expect(initializerServices.monitoringServices).not.toBe(services.monitoringServices);
       expect('bybitService' in initializerServices.marketDataServices).toBe(false);
 
+      expect(eventHandlerServices.coreServices.logger).toBe(services.coreServices.logger);
       expect(eventHandlerServices.marketDataServices.publicWebSocket).toBe(services.marketDataServices.publicWebSocket);
       expect(eventHandlerServices.executionServices.positionMonitor).toBe(services.executionServices.positionMonitor);
+      expect(eventHandlerServices.coreServices).not.toBe(services.coreServices);
       expect(eventHandlerServices.marketDataServices).not.toBe(services.marketDataServices);
       expect(eventHandlerServices.executionServices).not.toBe(services.executionServices);
+      expect('logger' in eventHandlerServices).toBe(false);
       expect('bybitService' in eventHandlerServices.marketDataServices).toBe(false);
       expect('positionExitingService' in eventHandlerServices.executionServices).toBe(false);
       expect('orderStateMachine' in eventHandlerServices.executionServices).toBe(false);

packages/core/src/__tests__/services/websocket-event-handler.functional.test.ts

@@ -60,4 +60,16 @@ describe('WebSocketEventHandlerManager functional boundary', () => {
     expect(stopLossSpy).toHaveBeenCalledTimes(1);
     expect(positionUpdateSpy).toHaveBeenCalledTimes(1);
   });
+
+  test('reuses the shared core logger through the websocket boundary contract', () => {
+    const { config, services } = createInitializerHarness();
+    const runtimeDependencies = createTradingBotRuntimeDependencies(services);
+    const manager = new WebSocketEventHandlerManager(runtimeDependencies.eventHandlerServices, config);
+
+    expect(runtimeDependencies.eventHandlerServices.coreServices.logger).toBe(
+      services.coreServices.logger,
+    );
+    expect('logger' in runtimeDependencies.eventHandlerServices).toBe(false);
+    expect(manager).toBeInstanceOf(WebSocketEventHandlerManager);
+  });
 });

packages/core/src/interfaces/IWebSocketEventHandlerServices.ts

@@ -10,7 +10,7 @@ import type { ImbalanceAnalysis } from '../types/legacy';
 import type { IMarketDataServices } from './IMarketDataServices';
 import type { IExecutionServices } from './IExecutionServices';
 import type { IEventHandlerServices } from './IEventHandlerServices';
-import type { LoggerService } from '../services/logger.service';
+import type { ICoreServices } from './ICoreServices';
 
 export type IWebSocketEventHandlerExecutionServices = Pick<
   IExecutionServices,
@@ -23,7 +23,7 @@ export type IWebSocketEventHandlerMarketDataServices = Pick<
 >;
 
 export interface IWebSocketEventHandlerServices {
-  logger: LoggerService;
+  coreServices: Pick<ICoreServices, 'logger'>;
   eventHandlerServices: IEventHandlerServices;
   executionServices: IWebSocketEventHandlerExecutionServices;
   marketDataServices: IWebSocketEventHandlerMarketDataServices;

packages/core/src/services/runtime-service-adapters.ts

@@ -136,7 +136,9 @@ export const createBotInitializerServices = (
 export const createWebSocketEventHandlerServices = (
   runtimeSource: IWebSocketEventHandlerRuntimeSource,
 ): IWebSocketEventHandlerServices => ({
-  logger: runtimeSource.coreServices.logger,
+  coreServices: {
+    logger: runtimeSource.coreServices.logger,
+  },
   eventHandlerServices: runtimeSource.eventHandlerServices,
   executionServices: createWebSocketEventHandlerExecutionServices(runtimeSource),
   marketDataServices: createWebSocketEventHandlerMarketDataServices(runtimeSource),

packages/core/src/services/websocket-event-handler-manager.ts

@@ -34,7 +34,7 @@ import { ICONS } from '../cli/cli-runtime';
  * keeping the bot class focused on orchestration.
  */
 export class WebSocketEventHandlerManager {
-  private logger: IWebSocketEventHandlerServices['logger'];
+  private logger: IWebSocketEventHandlerServices['coreServices']['logger'];
   private lastOrderbookAnalysis: number = 0;
   private whaleDetector: RealTimeWhaleDetector;
 
@@ -46,9 +46,9 @@ export class WebSocketEventHandlerManager {
   }> = [];
 
   constructor(private services: IWebSocketEventHandlerServices, private config: Config) {
-    this.logger = services.logger;
+    this.logger = services.coreServices.logger;
     this.whaleDetector = new RealTimeWhaleDetector({
-      logger: services.logger,
+      logger: services.coreServices.logger,
       tradingOrchestrator: services.executionServices.tradingOrchestrator,
     }, config);
   }