Apply improvements to worked solution READMEs#159
Merged
Conversation
- Compiler Intrinsics 1: Fix incorrect data type to read `__m128i` rather than `__m128_i` - Dependency Chains 2: Add missing data type to local variable - Vectorization 2: Fix incorrect max value for 16-bit integers - Huge Pages 1: Addresses a typo - now uses "huge pages" rather than "huge tables" - Loop Interchange 1: Matrix index fix - Memory Alignment 1: Use consistent naming for utility function - SW Memory Prefetching: Fix loops in code to handle the general case where `lookups.size()` may be smaller than our `prefetch_step`. This isn't the case in any of the lab test data, so has no effect in practice, but this change is for robustness and correctness.
dendibakh
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small set of changes to address a few minor issues in some of the READMEs:
__m128irather than__m128_ilookups.size()may be smaller than ourprefetch_step. This isn't the case in any of the lab test data, so has no effect in practice, but this change is for robustness and correctness.