client: Allow force-disable of DEX account. (#3580)

If a DEX server goes offline permanently, users are stuck unable to
disable the account because active orders can't be cancelled. Add a
force option to ToggleAccountStatus that revokes unfilled orders to
allow disabling. Matches with on-chain swaps in progress continue
to settle independently.

The UI automatically retries with force when the initial disable
fails due to active orders.

Author: JoeGruffins

client/core/account.go

@@ -47,8 +47,10 @@ func (c *Core) disconnectDEX(dc *dexConnection) {
 }
 
 // ToggleAccountStatus is used to disable or enable an account by given host and
-// application password.
-func (c *Core) ToggleAccountStatus(pw []byte, host string, disable bool) error {
+// application password. If force is true and disable is true, active orders
+// will be revoked to allow disabling. Matches with on-chain swaps in progress
+// will continue to settle (refund/redeem) independently.
+func (c *Core) ToggleAccountStatus(pw []byte, host string, disable, force bool) error {
 	// Validate password.
 	crypter, err := c.encryptionKey(pw)
 	if err != nil {
@@ -69,7 +71,15 @@ func (c *Core) ToggleAccountStatus(pw []byte, host string, disable bool) error {
 	if disable {
 		// Check active orders or bonds.
 		if dc.hasActiveOrders() {
-			return errors.New("cannot disable account with active orders")
+			if !force {
+				return errors.New("cannot disable account with active orders")
+			}
+			c.log.Warnf("Force-disabling account on %s with active orders. Revoking unfilled orders.", host)
+			dc.tradeMtx.RLock()
+			for _, trade := range dc.trades {
+				trade.revoke()
+			}
+			dc.tradeMtx.RUnlock()
 		}
 
 		if dc.hasUnspentBond() {

client/core/account_test.go

@@ -132,7 +132,7 @@ func TestToggleAccountStatus(t *testing.T) {
 		}
 		tCore.connMtx.Unlock()
 
-		err := tCore.ToggleAccountStatus(tPW, test.host, test.wantDisable)
+		err := tCore.ToggleAccountStatus(tPW, test.host, test.wantDisable, false)
 		if test.wantErr {
 			if err == nil {
 				t.Fatalf("expected error for test %v", test.name)

client/webserver/api.go

@@ -887,7 +887,7 @@ func (s *WebServer) apiToggleAccountStatus(w http.ResponseWriter, r *http.Reques
 		return
 	}
 	// Disable account.
-	err = s.core.ToggleAccountStatus(appPW, form.Host, form.Disable)
+	err = s.core.ToggleAccountStatus(appPW, form.Host, form.Disable, form.Force)
 	if err != nil {
 		s.writeAPIError(w, fmt.Errorf("error updating account status: %w", err))
 		return

client/webserver/live_test.go

@@ -771,7 +771,7 @@ func (c *TCore) AccountExport(pw []byte, host string) (*core.Account, []*db.Bond
 func (c *TCore) AccountImport(pw []byte, account *core.Account, bond []*db.Bond) error {
 	return nil
 }
-func (c *TCore) ToggleAccountStatus(pw []byte, host string, disable bool) error { return nil }
+func (c *TCore) ToggleAccountStatus(pw []byte, host string, disable, force bool) error { return nil }
 
 func (c *TCore) TxHistory(uint32, *asset.TxHistoryRequest) (*asset.TxHistoryResponse, error) {
 	return nil, nil

client/webserver/site/src/js/dexsettings.ts

@@ -315,16 +315,22 @@ export default class DexSettingsPage extends BasePage {
 
   // toggleAccountStatus enables or disables the account associated with the
   // provided host.
-  async toggleAccountStatus (disable:boolean) {
+  async toggleAccountStatus (disable:boolean, force?: boolean): Promise<void> {
     const page = this.page
     Doc.hide(page.errMsg)
     let host: string|null = this.host
     if (disable) host = page.disableAccountHost.textContent
-    const req = { host, disable: disable }
+    const req = { host, disable: disable, force: force || false }
     const loaded = app().loading(this.body)
     const res = await postJSON('/api/toggleaccountstatus', req)
     loaded()
     if (!app().checkResponse(res)) {
+      // If disabling fails because of active orders, retry with force
+      // to revoke unfilled orders. The user already confirmed the
+      // disable via the form.
+      if (disable && !force && res.msg && res.msg.includes('active orders')) {
+        return this.toggleAccountStatus(true, true)
+      }
       if (disable) {
         page.disableAccountErr.textContent = res.msg
         Doc.show(page.disableAccountErr)

client/webserver/types.go

@@ -137,6 +137,7 @@ type updateAccountStatusForm struct {
 	Pass    encode.PassBytes `json:"pw"`
 	Host    string           `json:"host"`
 	Disable bool             `json:"disable"`
+	Force   bool             `json:"force"`
 }
 
 type deleteRecordsForm struct {

client/webserver/webserver.go

@@ -147,7 +147,7 @@ type clientCore interface {
 	MaxSell(host string, base, quote uint32) (*core.MaxOrderEstimate, error)
 	AccountExport(pw []byte, host string) (*core.Account, []*db.Bond, error)
 	AccountImport(pw []byte, account *core.Account, bonds []*db.Bond) error
-	ToggleAccountStatus(pw []byte, host string, disable bool) error
+	ToggleAccountStatus(pw []byte, host string, disable, force bool) error
 	IsInitialized() bool
 	ExportSeed(pw []byte) (string, error)
 	PreOrder(*core.TradeForm) (*core.OrderEstimate, error)

client/webserver/webserver_test.go

@@ -250,7 +250,7 @@ func (c *TCore) AccountExport(pw []byte, host string) (*core.Account, []*db.Bond
 func (c *TCore) AccountImport(pw []byte, account *core.Account, bonds []*db.Bond) error {
 	return nil
 }
-func (c *TCore) ToggleAccountStatus(pw []byte, host string, disable bool) error { return nil }
+func (c *TCore) ToggleAccountStatus(pw []byte, host string, disable, force bool) error { return nil }
 
 func (c *TCore) ExportSeed(pw []byte) (string, error) {
 	return "seed words here", nil