refactor: it's always either observer_ctx or active_ctx, not both created together

knst · knst · commit 98399b43662c · 2026-03-25T01:49:58.000+07:00
diff --git a/src/init.cpp b/src/init.cpp
@@ -2420,7 +2420,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)
         {
             const CBlockIndex* tip = WITH_LOCK(::cs_main, return chainman.ActiveTip());
             const bool ibd = chainman.ActiveChainstate().IsInitialBlockDownload();
-            if (node.observer_ctx && !node.active_ctx) {
+            if (node.observer_ctx) {
                 node.observer_ctx->InitializeCurrentBlockTip(tip, ibd);
             }
             // Note: active_ctx initialization is deferred until after nodeman->Init()

Original file line number	Diff line number	Diff line change
`@@ -2420,7 +2420,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info)`
`2420`	`2420`	`{`
`2421`	`2421`	`const CBlockIndex* tip = WITH_LOCK(::cs_main, return chainman.ActiveTip());`
`2422`	`2422`	`const bool ibd = chainman.ActiveChainstate().IsInitialBlockDownload();`
`2423`		`- if (node.observer_ctx && !node.active_ctx) {`
	`2423`	`+ if (node.observer_ctx) {`
`2424`	`2424`	`node.observer_ctx->InitializeCurrentBlockTip(tip, ibd);`
`2425`	`2425`	`}`
`2426`	`2426`	`// Note: active_ctx initialization is deferred until after nodeman->Init()`