From 8d7187d4324b9bba30cbde68fef75e00c048d28a Mon Sep 17 00:00:00 2001
From: Zan Baldwin <hello@zanbaldwin.com>
Date: Wed, 16 Sep 2026 14:19:07 +0200
Subject: [PATCH] =?UTF-8?q?bugfix(multi):=20=F0=9F=90=9B=20keep=20the=20ex?=
 =?UTF-8?q?plicit=20strategy=20on=20Multi::fromEmbedded()?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The inherited IPv6 implementation rebuilt the instance without the strategy, so a non-default strategy packed the address but the result reported as version 6.
---
 CHANGELOG.md                |  1 +
 docs/04-helpers.md          |  1 +
 src/Version/Multi.php       | 10 ++++++++++
 tests/Version/MultiTest.php |  9 +++++++++
 4 files changed, 21 insertions(+)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index a2f2a9d..5198dd5 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -33,6 +33,7 @@
 - Add `fromInteger()` and `tryFromInteger()` on the new `Contracts\Factory4Interface` (IPv4 and Multi).
 - Arbitrary-precision `fromIntegerString()` and `tryFromIntegerString()` on all classes.
 - Fix: `Multi::fromProtocol()` now rejects a binary string of the wrong length instead of passing it through.
+- Fix: `Multi::fromEmbedded()` now keeps the strategy it is given instead of falling back to the default.
 
 ### Output
 
diff --git a/docs/04-helpers.md b/docs/04-helpers.md
index 798154b..3a7f34e 100644
--- a/docs/04-helpers.md
+++ b/docs/04-helpers.md
@@ -228,6 +228,7 @@ an IPv6 address.
 
 ```php
 <?php
+use Darsyn\IP\Strategy\Derived;
 use Darsyn\IP\Strategy\Mapped;
 use Darsyn\IP\Version\IPv6;
 use Darsyn\IP\Version\Multi;
diff --git a/src/Version/Multi.php b/src/Version/Multi.php
index 083b8ed..8d5432e 100644
--- a/src/Version/Multi.php
+++ b/src/Version/Multi.php
@@ -207,6 +207,16 @@ public static function isValid(string $ip, ?EmbeddingStrategyInterface $strategy
         return null !== static::tryFromProtocol($ip, $strategy);
     }
 
+    /**
+     * @throws \Darsyn\IP\Exception\InvalidIpAddressException
+     * @throws \Darsyn\IP\Exception\WrongVersionException
+     * @return static
+     */
+    public static function fromEmbedded(string $ip, ?EmbeddingStrategyInterface $strategy = null)
+    {
+        return static::tryFromProtocol($ip, $strategy) ?? static::fromBinary($ip, $strategy);
+    }
+
     protected function __construct(string $ip, ?EmbeddingStrategyInterface $strategy = null)
     {
         // Fallback to default in case this instance was created from static in
diff --git a/tests/Version/MultiTest.php b/tests/Version/MultiTest.php
index 7d33c15..f4047fc 100644
--- a/tests/Version/MultiTest.php
+++ b/tests/Version/MultiTest.php
@@ -928,6 +928,15 @@ public function testFromBinaryUsesExplicitStrategy(): void
         $this->assertSame('2002:0c22:384e:0000:0000:0000:0000:0000', $ip->toExpandedAddress());
     }
 
+    /** @test */
+    #[PHPUnit\Test]
+    public function testFromEmbeddedUsesExplicitStrategy(): void
+    {
+        $ip = IP::fromEmbedded('127.0.0.1', new Strategy\Derived());
+        $this->assertSame('2002:7f00:1::', $ip->toCompactedAddress());
+        $this->assertSame('127.0.0.1', $ip->toDotAddress());
+    }
+
     /**
      * @test
      * @dataProvider \Darsyn\IP\Tests\DataProvider\Multi::getValidBinarySequences()