Commit baf1a3c
committed
Apply Qodo /improve pass 2: case-insensitive device-path matching
Windows HID device paths are case-insensitive and casing can vary across
enumerations; match paths with OrdinalIgnoreCase in both ConnectByPathAsync and
the bootloader wait (consistent with the serial-filter comparison). Real device
paths never differ only by case, so this cannot mis-target.
Declined the redundant path re-validation suggestion (importance 2): the
enumerated device is already matched by targetDevicePath in
WaitForBootloaderDeviceAsync, so re-checking before connect adds nothing.
Tests: +1 (case-insensitive match).
Claude-Session: https://claude.ai/code/session_01V5TeJuikExLKXzxvYcQNxB1 parent 3683475 commit baf1a3c
3 files changed
Lines changed: 19 additions & 2 deletions
File tree
- src
- Daqifi.Core.Tests/Communication/Transport
- Daqifi.Core
- Communication/Transport
- Firmware
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
127 | 141 | | |
128 | 142 | | |
129 | 143 | | |
| |||
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
126 | 129 | | |
127 | | - | |
| 130 | + | |
128 | 131 | | |
129 | 132 | | |
130 | 133 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1113 | 1113 | | |
1114 | 1114 | | |
1115 | 1115 | | |
1116 | | - | |
| 1116 | + | |
1117 | 1117 | | |
1118 | 1118 | | |
1119 | 1119 | | |
| |||
0 commit comments