Improve error handling in FeedParser example

Author: danmactough

README.md

@@ -74,11 +74,14 @@ async function main() {
   if (res.status !== 200) throw new Error('Bad status code');
 
   var feedparser = new FeedParser([options]);
-  feedparser.on('error', function (error) { throw error; });
   res.body.pipe(feedparser);
 
-  for await (var item of feedparser) {
-    console.log(item.title);
+  try {
+    for await (var item of feedparser) {
+      console.log(item.title);
+    }
+  } catch (err) {
+    console.error(err);
   }
 }
 

test/examples.js

@@ -14,4 +14,20 @@ describe('examples', function () {
 
     assert.equal(items.length, 4);
   });
+
+  it('should surface errors via try/catch when using async iterator', async function () {
+    var feedparser = new FeedParser();
+    var feed = __dirname + '/feeds/notafeed.html';
+    fs.createReadStream(feed).pipe(feedparser);
+
+    var caught = null;
+    try {
+      for await (const item of feedparser) {} // eslint-disable-line no-unused-vars
+    } catch (err) {
+      caught = err;
+    }
+
+    assert.ok(caught instanceof Error);
+    assert.equal(caught.message, 'Not a feed');
+  });
 });