Skip to content

Commit 3c96af4

Browse files
djscruggsclaude
andcommitted
Mark the overflow test as fixme rather than skip.
`test.fixme` reports the deferred "has no horizontal overflow" check as a known-broken test to re-enable, instead of a silent skip, so the CSS rework that removes the `overflow-x: hidden` band-aid is visible in the runner output as outstanding work. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent e6d2325 commit 3c96af4

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

test/e2e/wallet-chooser.spec.js

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,15 +48,17 @@ for(const state of STATES) {
4848
// not just the resulting scrollbar — so the `overflow-x: hidden`
4949
// band-aid in the 1p dialog CSS cannot make it a false pass.
5050
//
51-
// SKIPPED for now: this currently fails because the dialog still
51+
// FIXME for now: this currently fails because the dialog still
5252
// relies on that band-aid to hide a real overflow (the headers and
5353
// separators bleed their border edge-to-edge with a negative side
5454
// margin that overhangs the border-box flex layout). The fix is
5555
// deferred until the styles are reworked against code we own — after
5656
// the components we use are pulled out of `vue-web-request-mediator`
57-
// and that dependency is removed. Enable this test as part of that
58-
// CSS work; it is the guard that proves the band-aid can be removed.
59-
test.skip('has no horizontal overflow', async ({page}) => {
57+
// and that dependency is removed. `fixme` (not `skip`) so the runner
58+
// reports it as a known-broken test to re-enable, not a silent skip.
59+
// Drop the `.fixme` as part of that CSS work; it is the guard that
60+
// proves the band-aid can be removed.
61+
test.fixme('has no horizontal overflow', async ({page}) => {
6062
const offenders = await page.evaluate(() => {
6163
const out = [];
6264
for(const el of document.querySelectorAll('.wrm-modal-1p *')) {

0 commit comments

Comments
 (0)