Skip to content

Commit 90b189c

Browse files
cpaczekclaude
andcommitted
fix: use pnpm publish in release workflow to resolve workspace deps
npm publish doesn't resolve workspace:* dependencies, causing silent publish failures. Switch to pnpm publish and remove continue-on-error so failures are visible. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 0dc18b5 commit 90b189c

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

.github/workflows/release.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ jobs:
3838
run: pnpm lint
3939

4040
- name: Publish @vibe-interviewing/scenarios
41-
continue-on-error: true
4241
working-directory: packages/scenarios
4342
run: |
4443
PACKAGE_NAME=$(node -p "require('./package.json').name")
@@ -47,15 +46,15 @@ jobs:
4746
4847
if [ "$LOCAL_VERSION" != "$PUBLISHED_VERSION" ]; then
4948
echo "Publishing $PACKAGE_NAME@$LOCAL_VERSION (registry has $PUBLISHED_VERSION)"
50-
npm publish --provenance --access public
49+
pnpm publish --provenance --access public --no-git-checks
5150
else
5251
echo "Skipping $PACKAGE_NAME — version $LOCAL_VERSION already published"
5352
fi
5453
env:
5554
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
55+
NPM_CONFIG_PROVENANCE: true
5656

5757
- name: Publish @vibe-interviewing/core
58-
continue-on-error: true
5958
working-directory: packages/core
6059
run: |
6160
PACKAGE_NAME=$(node -p "require('./package.json').name")
@@ -64,15 +63,15 @@ jobs:
6463
6564
if [ "$LOCAL_VERSION" != "$PUBLISHED_VERSION" ]; then
6665
echo "Publishing $PACKAGE_NAME@$LOCAL_VERSION (registry has $PUBLISHED_VERSION)"
67-
npm publish --provenance --access public
66+
pnpm publish --provenance --access public --no-git-checks
6867
else
6968
echo "Skipping $PACKAGE_NAME — version $LOCAL_VERSION already published"
7069
fi
7170
env:
7271
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
72+
NPM_CONFIG_PROVENANCE: true
7373

7474
- name: Publish vibe-interviewing
75-
continue-on-error: true
7675
working-directory: packages/cli
7776
run: |
7877
PACKAGE_NAME=$(node -p "require('./package.json').name")
@@ -81,9 +80,10 @@ jobs:
8180
8281
if [ "$LOCAL_VERSION" != "$PUBLISHED_VERSION" ]; then
8382
echo "Publishing $PACKAGE_NAME@$LOCAL_VERSION (registry has $PUBLISHED_VERSION)"
84-
npm publish --provenance --access public
83+
pnpm publish --provenance --access public --no-git-checks
8584
else
8685
echo "Skipping $PACKAGE_NAME — version $LOCAL_VERSION already published"
8786
fi
8887
env:
8988
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
89+
NPM_CONFIG_PROVENANCE: true

0 commit comments

Comments
 (0)