feat(affiliate): add sell and buy token symbols to trader activity

Author: kernelwhisperer

apps/api/src/app/routes/affiliate/trader-activity/_address/traderActivity.schemas.ts

@@ -39,6 +39,8 @@ export const traderActivityRowSchema = {
     trader_address: { type: 'string' },
     sell_token: { type: 'string' },
     buy_token: { type: 'string' },
+    sell_token_symbol: { type: 'string' },
+    buy_token_symbol: { type: 'string' },
     executed_sell_amount: { type: 'string' },
     executed_buy_amount: { type: 'string' },
     usd_value: { type: 'number' },

libs/services/src/AffiliateStatsService/AffiliateStatsService.ts

@@ -21,6 +21,8 @@ export interface TraderActivityDuneRow<T = number> {
   trader_address: string
   sell_token: string
   buy_token: string
+  sell_token_symbol?: string
+  buy_token_symbol?: string
   executed_sell_amount: string
   executed_buy_amount: string
   usd_value: T
@@ -40,6 +42,8 @@ export interface TraderActivityRow<T = number> {
   trader_address: string
   sell_token: string
   buy_token: string
+  sell_token_symbol?: string
+  buy_token_symbol?: string
   executed_sell_amount: string
   executed_buy_amount: string
   usd_value: T

libs/services/src/AffiliateStatsService/AffiliateStatsService.types.ts

@@ -10,8 +10,13 @@ export type NumericValue = number | string
 
 export type TraderStatsRowRaw = TraderStatsRow<NumericValue>
 
-export type TraderActivityRowRaw = Omit<TraderActivityDuneRow<NumericValue>, 'chain_id'> & {
+export type TraderActivityRowRaw = Omit<
+  TraderActivityDuneRow<NumericValue>,
+  'chain_id' | 'sell_token_symbol' | 'buy_token_symbol'
+> & {
   blockchain: string
+  sell_token_symbol?: string | null
+  buy_token_symbol?: string | null
 }
 
 export type AffiliateStatsRowRaw = AffiliateStatsRow<NumericValue>

libs/services/src/AffiliateStatsService/AffiliateStatsService.utils.ts

@@ -52,6 +52,8 @@ export function isTraderActivityRowRaw(data: unknown): data is TraderActivityRow
     isString(data.trader_address) &&
     isString(data.sell_token) &&
     isString(data.buy_token) &&
+    (data.sell_token_symbol == null || isString(data.sell_token_symbol)) &&
+    (data.buy_token_symbol == null || isString(data.buy_token_symbol)) &&
     isNumeric(data.executed_sell_amount) &&
     isNumeric(data.executed_buy_amount) &&
     isNumeric(data.usd_value) &&
@@ -107,6 +109,8 @@ export function normalizeTraderActivityRow(row: TraderActivityRowRaw): TraderAct
     trader_address: row.trader_address,
     sell_token: row.sell_token,
     buy_token: row.buy_token,
+    sell_token_symbol: row.sell_token_symbol || undefined,
+    buy_token_symbol: row.buy_token_symbol || undefined,
     executed_sell_amount: toDecimalString(row.executed_sell_amount, 'executed_sell_amount'),
     executed_buy_amount: toDecimalString(row.executed_buy_amount, 'executed_buy_amount'),
     usd_value: toNumber(row.usd_value, 'usd_value'),

libs/services/src/AffiliateStatsService/AffiliateStatsServiceImpl.spec.ts

@@ -90,6 +90,8 @@ function createTraderActivityRowRaw(overrides: Partial<TraderActivityRowRaw> = {
     trader_address: '0xabc',
     sell_token: '0xsell-dune',
     buy_token: '0xbuy-dune',
+    sell_token_symbol: 'SELL',
+    buy_token_symbol: 'BUY',
     executed_sell_amount: '0.04667962868331909',
     executed_buy_amount: '0.00000123',
     usd_value: '123.45',
@@ -146,6 +148,8 @@ describe('AffiliateStatsServiceImpl', () => {
         trader_address: row.trader_address,
         sell_token: row.sell_token,
         buy_token: row.buy_token,
+        sell_token_symbol: row.sell_token_symbol,
+        buy_token_symbol: row.buy_token_symbol,
         executed_sell_amount: '0.04667962868331909',
         executed_buy_amount: '0.00000123',
         usd_value: 123.45,