Merge pull request #1341 from jkroepke/s3-dualstack

bgilbert · web-flow · commit 53fad9fefc7c · 2022-03-30T11:46:57.000-04:00
internal/resource: enable DualStack for S3 connections
diff --git a/internal/resource/url.go b/internal/resource/url.go
@@ -464,7 +464,7 @@ func (f *Fetcher) fetchFromS3WithCreds(ctx context.Context, dest s3target, input
 		return err
 	}
 
-	awsConfig := aws.NewConfig().WithHTTPClient(httpClient)
+	awsConfig := aws.NewConfig().WithHTTPClient(httpClient).WithUseDualStack(true)
 	s3Client := s3.New(sess, awsConfig)
 	downloader := s3manager.NewDownloaderWithClient(s3Client)
 	if _, err := downloader.DownloadWithContext(ctx, dest, input); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -464,7 +464,7 @@ func (f *Fetcher) fetchFromS3WithCreds(ctx context.Context, dest s3target, input`
`464`	`464`	`return err`
`465`	`465`	`}`
`466`	`466`
`467`		`- awsConfig := aws.NewConfig().WithHTTPClient(httpClient)`
	`467`	`+ awsConfig := aws.NewConfig().WithHTTPClient(httpClient).WithUseDualStack(true)`
`468`	`468`	`s3Client := s3.New(sess, awsConfig)`
`469`	`469`	`downloader := s3manager.NewDownloaderWithClient(s3Client)`
`470`	`470`	`if _, err := downloader.DownloadWithContext(ctx, dest, input); err != nil {`