From ad41e2fb6f96e5d6d225489d9d83464fc946cb84 Mon Sep 17 00:00:00 2001 From: William Schmitt Date: Fri, 18 Sep 2026 17:01:10 -0700 Subject: [PATCH] Use ComputeSDK recording option for Browserbase sessions The @computesdk/browserbase adapter maps `recording` to Browserbase's `browserSettings.recordSession`. These configs passed `recordSession` directly, which the adapter drops, so sessions were still created with Browserbase's default of recordSession: true. `enableNativeSelectPolyfill` is left in place. It is a real (undocumented) Browserbase browserSettings field that defaults to true, but the adapter has no mapping for it, so it is currently a no-op here and will start taking effect if the adapter gains passthrough. Co-Authored-By: Claude Opus 5 (1M context) --- benchmarks/browser/providers.ts | 2 +- benchmarks/browser/throughput-providers.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/benchmarks/browser/providers.ts b/benchmarks/browser/providers.ts index 504d45731..5a06f4ed1 100644 --- a/benchmarks/browser/providers.ts +++ b/benchmarks/browser/providers.ts @@ -23,7 +23,7 @@ export const browserProviders: BrowserProviderConfig[] = [ sessionCreateOptions: { region: 'us-east-1', stealth: false, - recordSession: false, + recording: false, enableNativeSelectPolyfill: false, }, }, diff --git a/benchmarks/browser/throughput-providers.ts b/benchmarks/browser/throughput-providers.ts index ad6a7a828..8c1e02b72 100644 --- a/benchmarks/browser/throughput-providers.ts +++ b/benchmarks/browser/throughput-providers.ts @@ -29,7 +29,7 @@ export const throughputProviders: ThroughputProviderConfig[] = [ proxies: false, headless: true, viewport: VIEWPORT, - recordSession: false, + recording: false, enableNativeSelectPolyfill: false, }, },