Fix Docker build missing protobuf well-known types#32
Merged
Conversation
The protobuf-compiler package alone doesn't include well-known .proto files (like google/protobuf/empty.proto). Add libprotobuf-dev to provide them. Also add a Docker build smoke test to CI so Dockerfile breakage is caught before release. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes Docker builds failing during protobuf generation by ensuring the protobuf well-known type .proto files are available in the builder image, and adds CI coverage to prevent future Dockerfile regressions.
Changes:
- Install
libprotobuf-devin the Docker build stage somake protocan resolve well-known types (e.g.,google/protobuf/empty.proto). - Add a CI
docker-buildsmoke test job that builds thedevice-sourceandproxyDocker targets on every push/PR.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Dockerfile |
Adds libprotobuf-dev to provide protobuf well-known type .proto files during make proto in the builder stage. |
.github/workflows/ci.yml |
Adds a docker-build job that builds both Docker targets to catch Docker build breakage in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
libprotobuf-devto the apt install line —protobuf-compileralone doesn't include well-known.protofiles likegoogle/protobuf/empty.proto, causingmake prototo fail during Docker buildsdocker-buildsmoke test job that builds both Docker targets (device-sourceandproxy) on every push/PR, so Dockerfile breakage is caught before releaseFixes https://github.com/compscidr/sair/actions/runs/23303376825
Test plan
docker-buildjob passes on this PR🤖 Generated with Claude Code