Commit dc3af1c
[OPIK-7435] [FE] Fix Google Translate removeChild crash on onboarding email step (#7562)
* [OPIK-7435] [FE] Fix Google Translate removeChild crash on onboarding email step
The mobile ConnectStep submit button renders a state-dependent label
(Email setup instructions -> Sending... -> Instructions sent!) as a bare text
sibling of the button icon. Under browser translation Google Translate wraps
that text node in a <font> element; submitting the email reconciles the button
(icon + label swap) against a re-parented node and throws
"NotFoundError: Failed to execute 'removeChild' on 'Node'". Wrap the label in a
<span> so React swaps a stable wrapper element instead of the bare text node;
the label stays fully translatable. See react/react#11538.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
* [OPIK-7435] [FE] Add frontend rule: browser-translation-safe dynamic text
Document the Google Translate removeChild crash class in the opik-frontend
skill (Critical Gotchas) so new dynamic/animated text wraps interpolated
strings in an element instead of rendering bare text nodes.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 6c61906 commit dc3af1c
2 files changed
Lines changed: 24 additions & 5 deletions
File tree
- .agents/skills/opik-frontend
- apps/opik-frontend/src/v2/pages/GetStartedPage/MobileOnboarding
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
55 | 65 | | |
56 | 66 | | |
57 | 67 | | |
| |||
Lines changed: 14 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
164 | | - | |
165 | | - | |
166 | | - | |
167 | | - | |
168 | | - | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
169 | 178 | | |
170 | 179 | | |
171 | 180 | | |
| |||
0 commit comments