Fix ModelSkin unit tests

Author: codereader

radiantcore/decl/DeclarationFolderParser.cpp

@@ -52,7 +52,7 @@ void DeclarationFolderParser::parse(std::istream& stream, const vfs::FileInfo& f
 
         const auto& blockNode = static_cast<const parser::DefBlockSyntax&>(*node);
 
-        // Convert the incoming block to a DeclarationBlockSyntax
+        // Convert the incoming block to a DeclarationBlockSource
         auto blockSyntax = createBlock(blockNode, fileInfo, modDir);
 
         // Move the block in the correct bucket

radiantcore/skins/Doom3ModelSkin.cpp

@@ -85,6 +85,7 @@ void Skin::foreachMatchingModel(const std::function<void(const std::string&)>& f
 
 const std::vector<decl::ISkin::Remapping>& Skin::getAllRemappings()
 {
+    ensureParsed();
     return _current->remaps;
 }
 

test/Skin.cpp

@@ -524,7 +524,7 @@ TEST_F(ModelSkinTest, ReloadDeclsRefreshesModelsUsingSignal)
 
     // Inject a new block syntax into the existing skin declaration
     auto skin = GlobalModelSkinCache().findSkin("tile_skin");
-    decl::DeclarationBlockSyntax syntax;
+    decl::DeclarationBlockSource syntax;
 
     syntax.name = skin->getDeclName();
     syntax.typeName = "skin";