Fix: Allow adding new users to team even if user not in user table (#69)

karthiknatarajan · web-flow · commit 567c4482b910 · 2026-03-03T16:29:06.000+05:30
diff --git a/app/controller/tenant/membership.go b/app/controller/tenant/membership.go
@@ -32,7 +32,7 @@ func (c *Controller) CreateTenantMembership(ctx context.Context, tenant *types.T
 
 	principal, err := c.userCtrl.FindUserByEmail(ctx, in.Email)
 	if err != nil {
-		if !errors.IsNotFound(err) {
+		if !store.IsNotFound(err) {
 			return err
 		}
 	}
diff --git a/store/errors.go b/store/errors.go
@@ -18,3 +18,7 @@ var (
 		"spaces or repos")
 	ErrPreConditionFailed = errors.New("precondition failed")
 )
+
+func IsNotFound(err error) bool {
+	return errors.Is(err, ErrResourceNotFound)
+}

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ func (c Controller) CreateTenantMembership(ctx context.Context, tenant types.T`
`32`	`32`
`33`	`33`	`principal, err := c.userCtrl.FindUserByEmail(ctx, in.Email)`
`34`	`34`	`if err != nil {`
`35`		`- if !errors.IsNotFound(err) {`
	`35`	`+ if !store.IsNotFound(err) {`
`36`	`36`	`return err`
`37`	`37`	`}`
`38`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -18,3 +18,7 @@ var (`
`18`	`18`	`"spaces or repos")`
`19`	`19`	`ErrPreConditionFailed = errors.New("precondition failed")`
`20`	`20`	`)`
	`21`	`+`
	`22`	`+func IsNotFound(err error) bool {`
	`23`	`+ return errors.Is(err, ErrResourceNotFound)`
	`24`	`+}`