Skip to content

Commit a1cd492

Browse files
committed
address jet's comments
1 parent d39dbf7 commit a1cd492

1 file changed

Lines changed: 14 additions & 20 deletions

File tree

test/integration.js

Lines changed: 14 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,16 @@ jobs.define(jobType, function(job, done) {
2020
done();
2121
});
2222

23+
function failOnError(err) {
24+
if (err) {
25+
throw err;
26+
}
27+
}
28+
2329
describe("mongo persistence", function() {
2430
beforeEach(function(done) {
2531
mongo.collection('agendaJobs').remove({}, function(err) {
26-
if (err) {
27-
throw err;
28-
}
32+
failOnError(err);
2933
jobs.start();
3034
done();
3135
});
@@ -40,14 +44,10 @@ describe("mongo persistence", function() {
4044
.create(jobType, {})
4145
.schedule('in 10 minutes')
4246
.save(function(err) {
43-
if (err) {
44-
return done(err);
45-
}
47+
failOnError(err);
4648

4749
mongo.collection('agendaJobs').find().toArray(function(err, arr) {
48-
if (err) {
49-
throw err;
50-
}
50+
failOnError(err);
5151
expect(arr).to.have.length(1);
5252
done();
5353
});
@@ -59,26 +59,20 @@ describe("mongo persistence", function() {
5959
.create(jobType, {})
6060
.schedule('now')
6161
.save(function(err) {
62-
if (err) {
63-
return done(err);
64-
}
62+
failOnError(err);
6563

6664
mongo.collection('agendaJobs').find().toArray(function(err, arr) {
67-
if (err) {
68-
throw err;
69-
}
65+
failOnError(err);
7066
expect(arr).to.have.length(1);
7167
});
7268

73-
setTimeout(function() {
69+
jobs.on('complete', function() {
7470
mongo.collection('agendaJobs').find().toArray(function(err, arr) {
75-
if (err) {
76-
throw err;
77-
}
71+
failOnError(err);
7872
expect(arr).to.have.length(0);
7973
done();
8074
});
81-
}, 1000);
75+
});
8276
});
8377
});
8478
});

0 commit comments

Comments
 (0)