Importing CellML units that use offset

[hsorby]

Currently units that make use of the CellML 1.0/1.1 offset concept are ignored, and not warned about.
I think the parser might want to deal with this scenario better.
Maybe introducing a conversion component to convert the offset using an equation?

[jmdowrick]

Yes please!

[nickerso]

if the parser is silently ignoring content from the document being parsed, then yes - that is a bug to be fixed. I'd suggest separating the "automatic" fixing of documents being parsed to better handle parsing of CellML 1.x models into a different issue to avoid complicating the bug fix.

[hsorby]

This issue will look to provide a warning in the parser to indicate that a units offset was ignored.
Further work will be handled in a separate issue, if desired/required.

[agarny]

Seems reasonable to me.

[nickerso]

what is the current level of similar issues created in the parser? I have a feeling that we might have discussed this before, but this sounds more like an error than a warning...

[hsorby]

Other messages of this ilk are warnings.
To what I remember, because this is parsing (or importing) in a permissive state the user understands that somethings will not port over.
Things that don’t port over a warning is issued to indicate that something that the parser did should be taken into account.
I don’t see it as an error because it is not something that has gone wrong with the permissive parsing.
I see it as a warning for the user to check how the offset units will now work in the model.