Copy sibling fields to avoid changing parent unit (bugfix) (#2497)

Bugfix: copy sibling fields to avoid changing parent unit

This would lead to funny bugs like flags of the parent unit being
modified when sibiling unit is modified

Author: Hook25

checkbox-ng/plainbox/impl/session/state.py

@@ -27,25 +27,26 @@
 import logging
 import re
 import shutil
-
 from contextlib import suppress
+from copy import copy
 
 from plainbox.abc import IJobResult
 from plainbox.i18n import gettext as _
 from plainbox.impl import deprecated
-from plainbox.impl.depmgr import DependencyDuplicateError
-from plainbox.impl.depmgr import DependencyError
-from plainbox.impl.depmgr import DependencySolver
+from plainbox.impl.depmgr import (
+    DependencyDuplicateError,
+    DependencyError,
+    DependencySolver,
+)
 from plainbox.impl.secure.qualifiers import select_units
-from plainbox.impl.session.jobs import JobState
-from plainbox.impl.session.jobs import UndesiredJobReadinessInhibitor
+from plainbox.impl.session.jobs import JobState, UndesiredJobReadinessInhibitor
 from plainbox.impl.session.system_information import (
     collect as collect_system_information,
 )
 from plainbox.impl.unit.job import JobDefinition
-from plainbox.impl.unit.unit_with_id import UnitWithId
 from plainbox.impl.unit.testplan import TestPlanUnitSupport
 from plainbox.impl.unit.unit import on_ubuntucore
+from plainbox.impl.unit.unit_with_id import UnitWithId
 from plainbox.suspend_consts import Suspend
 from plainbox.vendor import morris
 
@@ -1217,7 +1218,7 @@ def _add_job_siblings_unit(self, new_job, recompute, via):
             if suspend_flag not in new_job.get_flag_set():
                 continue
             data = {
-                key: value
+                key: copy(value)
                 for key, value in new_job._data.items()
                 if not key.endswith("siblings")
             }