integration/rpctest: remove redundant boolean from harness setup

Previously the [Harness.SetUp] procedure was taking a boolean to
generate a test chain and a integer for the required number of mature
outputs, but internally, the test chain was being generated only if the
number of mature outputs was different than zero and the boolean was
true, this means that we can remove the boolean and pass zero when we
don't want to create the test chain.

After the change, all the tests still passing.

Author: allocz

integration/bip0009_test.go

@@ -136,7 +136,7 @@ func testBIP0009(t *testing.T, forkKey string, deploymentID uint32) {
 	if err != nil {
 		t.Fatalf("unable to create primary harness: %v", err)
 	}
-	if err := r.SetUp(false, 0); err != nil {
+	if err := r.SetUp(0); err != nil {
 		t.Fatalf("unable to setup test chain: %v", err)
 	}
 	defer r.TearDown()
@@ -389,7 +389,7 @@ func TestBIP0009Mining(t *testing.T) {
 	if err != nil {
 		t.Fatalf("unable to create primary harness: %v", err)
 	}
-	if err := r.SetUp(true, 0); err != nil {
+	if err := r.SetUp(0); err != nil {
 		t.Fatalf("unable to setup test chain: %v", err)
 	}
 	defer r.TearDown()

integration/chain_test.go

@@ -30,7 +30,7 @@ func TestGetTxSpendingPrevOut(t *testing.T) {
 	require.NoError(t, err)
 
 	// Setup the node.
-	require.NoError(t, r.SetUp(true, 100))
+	require.NoError(t, r.SetUp(100))
 	t.Cleanup(func() {
 		require.NoError(t, r.TearDown())
 	})

integration/csv_fork_test.go

@@ -115,7 +115,7 @@ func TestBIP0113Activation(t *testing.T) {
 	if err != nil {
 		t.Fatal("unable to create primary harness: ", err)
 	}
-	if err := r.SetUp(true, 1); err != nil {
+	if err := r.SetUp(1); err != nil {
 		t.Fatalf("unable to setup test chain: %v", err)
 	}
 	defer r.TearDown()
@@ -412,7 +412,7 @@ func TestBIP0068AndBIP0112Activation(t *testing.T) {
 	if err != nil {
 		t.Fatal("unable to create primary harness: ", err)
 	}
-	if err := r.SetUp(true, 1); err != nil {
+	if err := r.SetUp(1); err != nil {
 		t.Fatalf("unable to setup test chain: %v", err)
 	}
 	defer r.TearDown()

integration/debugstream_test.go

@@ -36,7 +36,7 @@ func TestDebugStream(t *testing.T) {
 		DebugStreamHandler: debHandler,
 	})
 	require.NoError(t, err)
-	h.SetUp(false, 0)
+	h.SetUp(0)
 
 	err = h.TearDown()
 	require.NoError(t, err)

integration/getchaintips_test.go

@@ -151,7 +151,7 @@ func TestGetChainTips(t *testing.T) {
 	if err != nil {
 		t.Fatal("TestGetChainTips fail. Unable to create primary harness: ", err)
 	}
-	if err := r.SetUp(true, 0); err != nil {
+	if err := r.SetUp(0); err != nil {
 		t.Fatalf("TestGetChainTips fail. Unable to setup test chain: %v", err)
 	}
 	defer r.TearDown()

integration/invalidate_reconsider_block_test.go

@@ -16,7 +16,7 @@ func TestInvalidateAndReconsiderBlock(t *testing.T) {
 		t.Fatalf("TestInvalidateAndReconsiderBlock fail."+
 			"Unable to create primary harness: %v", err)
 	}
-	if err := r.SetUp(true, 0); err != nil {
+	if err := r.SetUp(0); err != nil {
 		t.Fatalf("TestInvalidateAndReconsiderBlock fail. "+
 			"Unable to setup test chain: %v", err)
 	}

integration/p2a_test.go

@@ -41,7 +41,7 @@ func TestPayToAnchorSimple(t *testing.T) {
 
 	// Initialize the test harness with mining enabled to confirm
 	// transactions.
-	err = harness.SetUp(true, 25)
+	err = harness.SetUp(25)
 	if err != nil {
 		t.Fatalf("unable to setup test harness: %v", err)
 	}

integration/prune_test.go

@@ -23,7 +23,7 @@ func TestPrune(t *testing.T) {
 	r, err := rpctest.New(rpctest.HarnessOpts{ExtraArgs: btcdCfg})
 	require.NoError(t, err)
 
-	if err := r.SetUp(false, 0); err != nil {
+	if err := r.SetUp(0); err != nil {
 		require.NoError(t, err)
 	}
 	t.Cleanup(func() { r.TearDown() })

integration/rawtx_test.go

@@ -31,7 +31,7 @@ func TestTestMempoolAccept(t *testing.T) {
 	require.NoError(t, err)
 
 	// Setup the node.
-	require.NoError(t, r.SetUp(true, 100))
+	require.NoError(t, r.SetUp(100))
 	t.Cleanup(func() {
 		require.NoError(t, r.TearDown())
 	})

integration/reorg_test.go

@@ -34,12 +34,12 @@ func TestReorgFromForkPoint(t *testing.T) {
 
 	longer, err := rpctest.New()
 	require.NoError(t, err)
-	require.NoError(t, longer.SetUp(false, 0))
+	require.NoError(t, longer.SetUp(0))
 	t.Cleanup(func() { require.NoError(t, longer.TearDown()) })
 
 	shorter, err := rpctest.New()
 	require.NoError(t, err)
-	require.NoError(t, shorter.SetUp(false, 0))
+	require.NoError(t, shorter.SetUp(0))
 	t.Cleanup(func() { require.NoError(t, shorter.TearDown()) })
 
 	// Mine the shared chain on the longer node before connecting so that