bugfix: theme change problem

 Removed:
  - BUILD_STATIC option and the entire "Platform-specific" static linking block

Author: broccoli-97

CMakeLists.txt

@@ -11,7 +11,6 @@ set(CMAKE_AUTOMOC ON)
 set(CMAKE_AUTORCC ON)
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 
-option(BUILD_STATIC "Build a fully static executable" OFF)
 option(BUILD_TESTING "Build unit tests" OFF)
 option(ENABLE_CLANG_TIDY "Run clang-tidy during compilation" OFF)
 
@@ -31,7 +30,7 @@ find_package(Qt6 REQUIRED COMPONENTS Widgets Svg PrintSupport)
 
 # ---- Library (all sources except main.cpp) -----------------------------------
 
-add_library(ymind_lib STATIC
+add_library(ymind_lib OBJECT
     # Core – application infrastructure
     src/core/AppSettings.h        src/core/AppSettings.cpp
     src/core/Commands.h           src/core/Commands.cpp
@@ -88,12 +87,6 @@ endif()
 target_sources(ymind PRIVATE src/main.cpp)
 target_link_libraries(ymind PRIVATE ymind_lib)
 
-# ---- Platform-specific -------------------------------------------------------
-
-if(BUILD_STATIC AND WIN32)
-    target_link_options(ymind PRIVATE -static -static-libgcc -static-libstdc++)
-endif()
-
 # ---- Install -----------------------------------------------------------------
 
 install(TARGETS ymind DESTINATION bin)

src/ui/ThemeManager.cpp

@@ -11,7 +11,6 @@
 #include <QGraphicsItem>
 #include <QGraphicsView>
 #include <QPainter>
-#include <QPalette>
 #include <QStandardPaths>
 #include <QTimer>
 #include <cmath>
@@ -101,100 +100,20 @@ static QString generateCloseIcon(bool dark) {
     return path;
 }
 
-// ---------------------------------------------------------------------------
-// Build a QPalette that matches the stylesheet so unstyled widgets also
-// follow the chosen theme.  Without this, Qt6 on Windows picks up the
-// system dark/light palette and unstyled widgets ignore the stylesheet.
-// ---------------------------------------------------------------------------
-static QPalette buildPalette(bool dark) {
-    QPalette pal;
-    if (dark) {
-        QColor windowBg("#2D2D30");
-        QColor windowFg("#D4D4D4");
-        QColor baseBg("#252526");
-        QColor highlight("#094771");
-        QColor highlightText("#FFFFFF");
-        QColor buttonBg("#3C3C3C");
-        QColor disabledFg("#5A5A5A");
-
-        pal.setColor(QPalette::Window,          windowBg);
-        pal.setColor(QPalette::WindowText,      windowFg);
-        pal.setColor(QPalette::Base,            baseBg);
-        pal.setColor(QPalette::AlternateBase,   windowBg);
-        pal.setColor(QPalette::Text,            windowFg);
-        pal.setColor(QPalette::Button,          buttonBg);
-        pal.setColor(QPalette::ButtonText,      windowFg);
-        pal.setColor(QPalette::BrightText,      Qt::white);
-        pal.setColor(QPalette::Highlight,       highlight);
-        pal.setColor(QPalette::HighlightedText, highlightText);
-        pal.setColor(QPalette::ToolTipBase,     windowBg);
-        pal.setColor(QPalette::ToolTipText,     windowFg);
-        pal.setColor(QPalette::PlaceholderText, disabledFg);
-        pal.setColor(QPalette::Light,           QColor("#3F3F46"));
-        pal.setColor(QPalette::Midlight,        QColor("#353535"));
-        pal.setColor(QPalette::Mid,             QColor("#2D2D30"));
-        pal.setColor(QPalette::Dark,            QColor("#1E1E1E"));
-        pal.setColor(QPalette::Shadow,          QColor("#111111"));
-
-        // Disabled state
-        pal.setColor(QPalette::Disabled, QPalette::WindowText,  disabledFg);
-        pal.setColor(QPalette::Disabled, QPalette::Text,        disabledFg);
-        pal.setColor(QPalette::Disabled, QPalette::ButtonText,  disabledFg);
-    } else {
-        QColor windowBg("#FFFFFF");
-        QColor windowFg("#1E1E1E");
-        QColor baseBg("#FFFFFF");
-        QColor highlight("#CCE4F7");
-        QColor highlightText("#1E1E1E");
-        QColor buttonBg("#E1E4E8");
-        QColor disabledFg("#B0B0B0");
-
-        pal.setColor(QPalette::Window,          windowBg);
-        pal.setColor(QPalette::WindowText,      windowFg);
-        pal.setColor(QPalette::Base,            baseBg);
-        pal.setColor(QPalette::AlternateBase,   QColor("#F8F8F8"));
-        pal.setColor(QPalette::Text,            windowFg);
-        pal.setColor(QPalette::Button,          buttonBg);
-        pal.setColor(QPalette::ButtonText,      windowFg);
-        pal.setColor(QPalette::BrightText,      Qt::black);
-        pal.setColor(QPalette::Highlight,       highlight);
-        pal.setColor(QPalette::HighlightedText, highlightText);
-        pal.setColor(QPalette::ToolTipBase,     QColor("#F5F5F5"));
-        pal.setColor(QPalette::ToolTipText,     windowFg);
-        pal.setColor(QPalette::PlaceholderText, disabledFg);
-        pal.setColor(QPalette::Light,           QColor("#FFFFFF"));
-        pal.setColor(QPalette::Midlight,        QColor("#F0F0F0"));
-        pal.setColor(QPalette::Mid,             QColor("#D0D0D0"));
-        pal.setColor(QPalette::Dark,            QColor("#A0A0A0"));
-        pal.setColor(QPalette::Shadow,          QColor("#808080"));
-
-        // Disabled state
-        pal.setColor(QPalette::Disabled, QPalette::WindowText,  disabledFg);
-        pal.setColor(QPalette::Disabled, QPalette::Text,        disabledFg);
-        pal.setColor(QPalette::Disabled, QPalette::ButtonText,  disabledFg);
-    }
-    return pal;
-}
-
 // ---------------------------------------------------------------------------
 // Apply theme to application and invalidate caches on all scenes
 // ---------------------------------------------------------------------------
 void ThemeManager::applyTheme(const QList<TabState>& tabs) {
     bool dark = (AppSettings::instance().theme() == AppTheme::Dark);
 
-    QString stylesheet =
-        dark ? QString(StyleSheetGenerator::darkStyleSheet())
-             : QString(StyleSheetGenerator::lightStyleSheet());
+    QString stylesheet = dark ? QString(StyleSheetGenerator::darkStyleSheet())
+                              : QString(StyleSheetGenerator::lightStyleSheet());
 
     // Generate a close-button icon matching the theme and inject into stylesheet
     QString iconPath = generateCloseIcon(dark);
     iconPath.replace("\\", "/"); // Qt URL paths require forward slashes
     stylesheet += QString("\nQTabBar::close-button { image: url(%1); }").arg(iconPath);
 
-    // Set palette BEFORE stylesheet so Qt's palette and CSS are in sync.
-    // This is critical on Windows where Qt6 auto-detects system dark mode
-    // and applies a system palette that overrides unstyled widget colors.
-    qApp->setPalette(buildPalette(dark));
     qApp->setStyleSheet(stylesheet);
 
     // Invalidate caches on ALL open scenes