From e027eaa65cf96eed407fa259dddfa33ba8ec0789 Mon Sep 17 00:00:00 2001 From: "Gareth.Y" <91742523+linjiaye929@users.noreply.github.com> Date: Thu, 19 Nov 2026 12:16:21 +0800 Subject: [PATCH] Reject non-object inputs when validating saved evaluation parameters --- py/src/braintrust/parameters.py | 4 +++- py/src/braintrust/test_parameters.py | 16 ++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/py/src/braintrust/parameters.py b/py/src/braintrust/parameters.py index 180cf34af..9de895dc4 100644 --- a/py/src/braintrust/parameters.py +++ b/py/src/braintrust/parameters.py @@ -87,6 +87,8 @@ def from_function_row(cls, row: dict[str, Any]) -> "RemoteEvalParameters": ) def validate(self, data: Any) -> bool: + if not isinstance(data, Mapping): + return False try: validate_json_schema(data, self.schema) return True @@ -283,7 +285,7 @@ def _apply_defaults_to_json_schema_instance(instance: Any, schema: Mapping[str, return instance -def validate_json_schema(parameters: dict[str, Any], schema: ParametersSchema) -> dict[str, Any]: +def validate_json_schema(parameters: Mapping[str, Any], schema: ParametersSchema) -> dict[str, Any]: candidate = dict(parameters) _apply_defaults_to_json_schema_instance(candidate, schema) diff --git a/py/src/braintrust/test_parameters.py b/py/src/braintrust/test_parameters.py index d96d45aea..d68c4285c 100644 --- a/py/src/braintrust/test_parameters.py +++ b/py/src/braintrust/test_parameters.py @@ -674,3 +674,19 @@ def schema(cls): assert serialized["judge_model"]["type"] == "model" for name in ("template", "main", "judge_model"): assert "description" not in serialized[name] + + +@pytest.mark.parametrize("value", [None, 5, True, "", [], [["limit", 2]]]) +def test_remote_parameters_validate_rejects_non_object_without_coercion(value): + parameters = RemoteEvalParameters( + id=None, + project_id=None, + name="test", + slug="test", + version=None, + schema={"type": "object", "properties": {"limit": {"type": "integer"}}}, + data={}, + ) + assert parameters.validate(value) is False + assert parameters.validate({"limit": 2}) is True + assert parameters.validate({"limit": "wrong"}) is False