A recent commit jf-tech/omniparser@1b4997b introduced a snapshot filename containing ;. While itself is fine, i.e. running tests is all good, we ran into issues when the module being imported by 3rd party, hitting an error:
extensions/omniv21/fileformat/flatfile/fixedlength/.snapshots/TestReadAndMatchHeaderFooterBasedEnvelope-empty_buf;_single_line_header-footer_match: malformed file path "extensions/omniv21/fileformat/flatfile/fixedlength/.snapshots/TestReadAndMatchHeaderFooterBasedEnvelope-empty_buf;_single_line_header-footer_match": invalid char ';'
Turns out ; isn't allowed in module filepath: https://cs.opensource.google/go/x/mod/+/master:module/module.go;l=285;drc=02c991387e35f9e4c0a9b7ce137717055f8d716d
Your library already does many of the special character replacement during snapshot file creation. Wondering if ; semicolon can be added?
Cheers!
A recent commit jf-tech/omniparser@1b4997b introduced a snapshot filename containing
;. While itself is fine, i.e. running tests is all good, we ran into issues when the module being imported by 3rd party, hitting an error:Turns out
;isn't allowed in module filepath: https://cs.opensource.google/go/x/mod/+/master:module/module.go;l=285;drc=02c991387e35f9e4c0a9b7ce137717055f8d716dYour library already does many of the special character replacement during snapshot file creation. Wondering if
;semicolon can be added?Cheers!