cli: Enable debug logs to console

The current handling of loglevels in the snagrecover and snagflash CLIs
does not properly apply the requested loglevel to the stdout handler.
Correct this.

Signed-off-by: Romain Gantois <romain.gantois@bootlin.com>

Author: rgantois

src/snagfactory/board.py

@@ -194,8 +194,8 @@ def run_recovery(config, soc_family, log_queue):
 		datefmt="%H:%M:%S",
 	)
 	log_handler.setFormatter(log_formatter)
+	log_handler.setLevel(logging.INFO)
 	logger.addHandler(log_handler)
-	logger.setLevel(logging.INFO)
 
 	recovery = snagrecover.utils.get_recovery(soc_family)
 

src/snagfactory/fastboot.py

@@ -42,8 +42,8 @@ def run_fastboot_task(args, log_queue):
 		datefmt="%H:%M:%S",
 	)
 	log_handler.setFormatter(log_formatter)
+	log_handler.setLevel(logging.INFO)
 	logger.addHandler(log_handler)
-	logger.setLevel(logging.INFO)
 
 	try:
 		fastboot(args)

src/snagflash/cli.py

@@ -137,20 +137,22 @@ def cli():
 
 	stdout_formatter = logging.Formatter("[%(levelname)s] %(message)s")
 	stdout_handler = logging.StreamHandler(sys.stdout)
-	stdout_handler.setLevel(logging.INFO)
 	stdout_handler.setFormatter(stdout_formatter)
-	logger.addHandler(stdout_handler)
+	stdout_handler.setLevel(logging.INFO)
 
 	if args.loglevel != "silent":
 		file_formatter = logging.Formatter("%(asctime)s [%(levelname)s] %(message)s")
 		file_handler = logging.FileHandler(args.logfile, encoding="utf-8")
 		file_handler.setFormatter(file_formatter)
 		if args.loglevel == "debug":
 			file_handler.setLevel(logging.DEBUG)
+			stdout_handler.setLevel(logging.DEBUG)
 		elif args.loglevel == "info":
 			file_handler.setLevel(logging.INFO)
 		logger.addHandler(file_handler)
 
+	logger.addHandler(stdout_handler)
+
 	# make sure we don't log into the recovery log when importing its modules
 	recovery_logger = logging.getLogger("snagrecover")
 	recovery_logger.parent = logger

src/snagrecover/cli.py

@@ -118,20 +118,22 @@ def cli():
 
 	stdout_formatter = logging.Formatter("[%(levelname)s] %(message)s")
 	stdout_handler = logging.StreamHandler(sys.stdout)
-	stdout_handler.setLevel(logging.INFO)
 	stdout_handler.setFormatter(stdout_formatter)
-	logger.addHandler(stdout_handler)
+	stdout_handler.setLevel(logging.INFO)
 
 	if args.loglevel != "silent":
 		file_formatter = logging.Formatter("%(asctime)s [%(levelname)s] %(message)s")
 		file_handler = logging.FileHandler(args.logfile, encoding="utf-8")
 		file_handler.setFormatter(file_formatter)
 		if args.loglevel == "debug":
 			logger.setLevel(logging.DEBUG)
+			stdout_handler.setLevel(logging.DEBUG)
 		elif args.loglevel == "info":
 			logger.setLevel(logging.INFO)
 		logger.addHandler(file_handler)
 
+	logger.addHandler(stdout_handler)
+
 	# show version
 	if args.version:
 		logger.info(f"Snagboot v{__version__}")