Merge pull request #304 from bnema/feat/gtk-history-sidebar

feat(history): add native GTK Ctrl+H sidebar

Author: bnema

.mockery.yaml

@@ -65,6 +65,7 @@ packages:
       EntryInputTarget: {}
       HomepageFavorites: {}
       HomepageHistory: {}
+      HistorySidebarHistory: {}
       AllKeybindingsResetter: {}
       KeybindingResetter: {}
       KeybindingSetter: {}

docs/reference/keybindings.md

@@ -83,7 +83,7 @@ These work outside modal modes:
 | Action | Keys |
 |--------|------|
 | Toggle floating pane | `Alt+F` |
-| Toggle History system view in right split (may conflict with the browser's default History shortcut; behavior can vary by browser) | `Ctrl+H` |
+| Toggle History sidebar (native GTK sidebar panel only). Ctrl+H may conflict with the browser's default History shortcut; behavior can vary by browser. | `Ctrl+H` |
 | Toggle Favorites system view in right split | unbound by default |
 | Toggle Config system view in right split | unbound by default |
 | Close pane (or release floating pane) | `Ctrl+W` |
@@ -96,7 +96,7 @@ These work outside modal modes:
 
 - `Alt+F` is the only floating-pane shortcut enabled by default.
 - `Alt+F` toggles floating visibility and keeps floating pane state intact.
-- `Ctrl+H` toggles `dumb://history`: it focuses an existing History pane, opens it in a right split if missing, or closes it when already active. Depending on the browser, the default History shortcut may intercept `Ctrl+H`, so behavior can vary.
+- `Ctrl+H` toggles the native GTK history sidebar. The sidebar shows browsing history grouped by day with search/filter, keyboard navigation (arrows, Home/End, Ctrl+arrows for day jumps), and activation modes (Enter to navigate while keeping the sidebar open, Ctrl+Enter to navigate while keeping the sidebar open, Shift+Enter to open in a new split). If the native sidebar is unavailable, the shortcut returns an error instead of falling back to `dumb://history`.
 - `Ctrl+W` closes the active pane; when the floating pane is active, it fully releases that floating session.
 - Any URL shortcut (for example `Alt+G`) must be defined explicitly in `workspace.floating_pane.profiles`.
 - Floating profile shortcuts support modifier combos with `ctrl`, `shift`, and `alt` (for example `ctrl+shift+y` or `ctrl+alt+m`).

internal/application/port/history_sidebar.go

@@ -0,0 +1,16 @@
+package port
+
+import (
+	"context"
+
+	"github.com/bnema/dumber/internal/application/dto"
+	"github.com/bnema/dumber/internal/domain/entity"
+)
+
+// HistorySidebarHistory provides the narrow history operations needed by the
+// native GTK history sidebar.
+type HistorySidebarHistory interface {
+	GetRecent(ctx context.Context, limit, offset int) ([]*entity.HistoryEntry, error)
+	Search(ctx context.Context, input dto.HistorySearchInput) (*dto.HistorySearchOutput, error)
+	Delete(ctx context.Context, id int64) error
+}

internal/application/usecase/search_history.go

@@ -15,8 +15,10 @@ import (
 	"github.com/bnema/dumber/internal/logging"
 )
 
-// Compile-time check: SearchHistoryUseCase must satisfy port.HomepageHistory.
+// Compile-time checks: SearchHistoryUseCase must satisfy the application
+// history ports used by WebUI handlers and the native GTK history sidebar.
 var _ port.HomepageHistory = (*SearchHistoryUseCase)(nil)
+var _ port.HistorySidebarHistory = (*SearchHistoryUseCase)(nil)
 
 const (
 	historyWindowDuration = 24 * time.Hour

internal/infrastructure/config/defaults.go

@@ -21,7 +21,8 @@ const (
 	defaultMaxLogFiles   = 100 // session log files
 
 	// Appearance defaults
-	defaultFontSize                      = 16 // points
+	defaultSidebarWidth                  = 320 // px, clamped to [280, 380]
+	defaultFontSize                      = 16  // points
 	defaultExternalThemeProvider         = "noctalia"
 	defaultExternalThemeFormat           = "colors-json"
 	defaultExternalThemeColorsFilename   = "colors.json"
@@ -251,8 +252,9 @@ func DefaultConfig() *Config {
 				GLRenderingMode:        GLRenderingModeAuto,
 			},
 		},
-		DefaultWebpageZoom: 1.2,            // 120% default zoom for better readability
-		DefaultUIScale:     defaultUIScale, // 1.0 = 100%, 2.0 = 200%
+		DefaultWebpageZoom: 1.2,                 // 120% default zoom for better readability
+		DefaultUIScale:     defaultUIScale,      // 1.0 = 100%, 2.0 = 200%
+		SidebarWidth:       defaultSidebarWidth, // 320px, clamped to [280, 380]
 		Workspace: WorkspaceConfig{
 			NewPaneURL:        defaultNewPaneURL,
 			SwitchToTabOnMove: true,

internal/infrastructure/config/loader.go

@@ -664,6 +664,7 @@ func (m *Manager) setAppearanceDefaults(defaults *Config) {
 func (m *Manager) setZoomAndScaleDefaults(defaults *Config) {
 	m.viper.SetDefault("default_webpage_zoom", defaults.DefaultWebpageZoom)
 	m.viper.SetDefault("default_ui_scale", defaults.DefaultUIScale)
+	m.viper.SetDefault("sidebar_width", defaults.SidebarWidth)
 }
 
 func (m *Manager) setWorkspaceDefaults(defaults *Config) {

internal/infrastructure/config/migrate.go

@@ -283,10 +283,10 @@ const (
 
 // Config format constants.
 const (
-	configFormatTOML             = "toml"
-	configFormatYAML             = "yaml"
-	configFormatJSON             = "json"
-	databasePathKey = "database.path"
+	configFormatTOML = "toml"
+	configFormatYAML = "yaml"
+	configFormatJSON = "json"
+	databasePathKey  = "database.path"
 )
 
 type defaultActionMap struct {

internal/infrastructure/config/schema.go

@@ -95,6 +95,9 @@ type Config struct {
 	DefaultWebpageZoom float64 `mapstructure:"default_webpage_zoom" yaml:"default_webpage_zoom" toml:"default_webpage_zoom"`
 	// DefaultUIScale sets the default UI scale for GTK widgets (1.0 = 100%, 2.0 = 200%)
 	DefaultUIScale float64 `mapstructure:"default_ui_scale" yaml:"default_ui_scale" toml:"default_ui_scale"`
+	// SidebarWidth sets the preferred width (px) for the history sidebar.
+	// Clamped to [280, 380] at runtime. 0 means use default (320).
+	SidebarWidth int `mapstructure:"sidebar_width" yaml:"sidebar_width" toml:"sidebar_width"`
 	// Workspace defines workspace, pane, and tab handling behavior.
 	Workspace WorkspaceConfig `mapstructure:"workspace" yaml:"workspace" toml:"workspace"`
 	// Session controls session persistence and restoration.

internal/infrastructure/config/schema_provider.go

@@ -161,6 +161,14 @@ func (*SchemaProvider) getAppearanceKeys(defaults *Config) []entity.ConfigKeyInf
 			Range:       "0.5-3.0",
 			Section:     SectionAppearance,
 		},
+		{
+			Key:         "sidebar_width",
+			Type:        "int",
+			Default:     fmt.Sprintf("%d", defaults.SidebarWidth),
+			Description: "Preferred width (px) for the history sidebar. 0 = default",
+			Range:       "0 or 280-380",
+			Section:     SectionAppearance,
+		},
 		{
 			Key:         "appearance.light_palette.*",
 			Type:        "string",

internal/infrastructure/config/validation.go

@@ -104,6 +104,9 @@ func validateAppearance(config *Config) []string {
 	if config.DefaultUIScale < 0.5 || config.DefaultUIScale > 3.0 {
 		validationErrors = append(validationErrors, "default_ui_scale must be between 0.5 and 3.0")
 	}
+	if config.SidebarWidth != 0 && (config.SidebarWidth < 280 || config.SidebarWidth > 380) {
+		validationErrors = append(validationErrors, "sidebar_width must be between 280 and 380, or 0 for default")
+	}
 	validationErrors = append(validationErrors, validateExternalTheme(config)...)
 	return validationErrors
 }