Merge pull request #624 from biojppm/ci/fixes

CI: update to clang-tidy 22, fixes, updates

Author: biojppm

.clang-tidy

@@ -79,7 +79,9 @@ Checks:
   - -modernize-type-traits # use c++17 style variable templates
   - -modernize-use-auto # use auto when initializing with a cast to avoid duplicating the type name
   - -modernize-use-default-member-init # use default member initializer for 'm_pos'
+  - -modernize-use-designated-initializers
   - -modernize-use-nodiscard # function 'valid' should be marked nodiscard
+  - -modernize-use-std-print
   - -modernize-use-trailing-return-type # don't care about this
   - -modernize-use-using # use 'using' instead of 'typedef'
   - -performance-enum-size # enum '_ppstate' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size
@@ -98,6 +100,7 @@ Checks:
   - -readability-redundant-access-specifiers # redundant access specifier has the same accessibility as the previous access specifier
   - -readability-redundant-member-init # initializer for member 'm_arena' is redundant
   - -readability-redundant-parentheses # redundant parentheses around expression
+  - -readability-redundant-typename
   - -readability-simplify-boolean-expr # boolean expression can be simplified by DeMorgan's theorem
   - -readability-suspicious-call-argument # 1st argument 'after' (passed to 'node') looks like it might be swapped with the 2nd, 'node' (passed to 'sib')
   - -readability-uppercase-literal-suffix # integer literal has suffix 'u', which is not uppercase

.github/workflows/bash/clang-checkout.bash

@@ -23,7 +23,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - name: checkout (action)
-      uses: actions/checkout@v4
+      uses: actions/checkout@v6
       with:
         submodules: recursive
         fetch-depth: 0
@@ -61,7 +61,7 @@ jobs:
         export SRC_VERSION=$SRC_VERSION
         EOF
     - name: Save vars.sh
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v7
       with:
         name: vars.sh
         path: ./vars.sh
@@ -123,12 +123,12 @@ jobs:
       OS: ${{matrix.os}}
     steps:
     - name: checkout (action)
-      uses: actions/checkout@v4
+      uses: actions/checkout@v6
       with:
         submodules: recursive
         fetch-depth: 0
     - name: Download vars.sh
-      uses: actions/download-artifact@v4
+      uses: actions/download-artifact@v7
       with:
         name: vars.sh
         path: ./
@@ -196,7 +196,7 @@ jobs:
           mv -vf build/$bl/bm/bm-results/* $dst/.
         done
     - name: upload benchmark result artifacts
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v7
       with:
         name: ryml-benchmark_results-${{strategy.job-index}}
         path: ryml-benchmark_results/

.github/workflows/benchmarks.yml

@@ -70,7 +70,7 @@ jobs:
           mv -vf build/$bl/bm/bm-results/* $dst/.
         done
     - name: upload benchmark result artifacts
-      uses: actions/upload-artifact@v4
+      uses: actions/upload-artifact@v7
       with:
         name: ryml-benchmark_results-${{strategy.job-index}}
         path: ryml-benchmark_results/

.github/workflows/benchmarks.ys

@@ -39,7 +39,7 @@ jobs:
           bitlinks: shared64 static32
     steps:
     - name: checkout (action + docker)
-      uses: actions/checkout@v4
+      uses: actions/checkout@v6
       with:
         submodules: recursive
         fetch-depth: 0
@@ -112,7 +112,7 @@ jobs:
           bitlinks: shared64 static32
     steps:
     - name: checkout (action + docker)
-      uses: actions/checkout@v4
+      uses: actions/checkout@v6
       with:
         submodules: recursive
         fetch-depth: 0
@@ -186,7 +186,7 @@ jobs:
           bitlinks: shared64 static32
     steps:
     - name: checkout (action + docker)
-      uses: actions/checkout@v4
+      uses: actions/checkout@v6
       with:
         submodules: recursive
         fetch-depth: 0
@@ -260,7 +260,7 @@ jobs:
           bitlinks: shared64 static32
     steps:
     - name: checkout (action + docker)
-      uses: actions/checkout@v4
+      uses: actions/checkout@v6
       with:
         submodules: recursive
         fetch-depth: 0
@@ -1303,7 +1303,7 @@ jobs:
       OS: ${{matrix.os}}
     steps:
     - name: checkout (action + docker)
-      uses: actions/checkout@v4
+      uses: actions/checkout@v6
       with:
         submodules: recursive
         fetch-depth: 0

.github/workflows/clang.yml

@@ -219,7 +219,7 @@ jobs:
 #     env:: load('share/env.yaml')
 #
 #     steps:
-#     - {name: checkout, uses: actions/checkout@v4,
+#     - {name: checkout, uses: actions/checkout@v6,
 #       with: {submodules: recursive}}
 #     # needed for running in the docker image.
 #     # see https://github.com/actions/checkout/issues/1169

.github/workflows/clang.ys

@@ -23,14 +23,14 @@ jobs:
     if: always()
     continue-on-error: false
     runs-on: ubuntu-24.04
-    container: ghcr.io/biojppm/c4core/ubuntu22.04:latest
+    container: ghcr.io/biojppm/c4core/ubuntu24.04:latest
     name: clang_tidy/c++${{matrix.std}}/${{matrix.bt}}
     strategy:
       fail-fast: false
       matrix:
         include:
         - std: 11
-          clang: 18
+          clang: 22
           bt: Debug
           bits: 64
     env:
@@ -44,7 +44,7 @@ jobs:
       OS: ${{matrix.os}}
     steps:
     - name: checkout (action + docker)
-      uses: actions/checkout@v4
+      uses: actions/checkout@v6
       with:
         submodules: recursive
         fetch-depth: 0

.github/workflows/clang_tidy.yml

@@ -5,13 +5,13 @@
 
 jobs:
   clang_tidy:
-    :: setup-job('clang_tidy' 'clang_tidy') + runs-on-docker-c4core('22.04')
+    :: setup-job('clang_tidy' 'clang_tidy') + runs-on-docker-c4core('24.04')
     name: clang_tidy/c++${{matrix.std}}/${{matrix.bt}}
     strategy:
       fail-fast: false
       matrix:
         include:
-        - {std: 11, clang: 18, bt: Debug, bits: 64}
+        - {std: 11, clang: 22, bt: Debug, bits: 64}
     env:: load('share/env.yaml')
     steps:
       - :: checkout-action-docker

.github/workflows/clang_tidy.ys

@@ -25,7 +25,7 @@ jobs:
         - cpp
     steps:
     - name: Checkout
-      uses: actions/checkout@v4
+      uses: actions/checkout@v6
       with:
         submodules: recursive
     - name: Initialize CodeQL

.github/workflows/codeql.yml

@@ -24,7 +24,7 @@ jobs:
 
     steps:
     - name: Checkout
-      uses: actions/checkout@v4
+      uses: actions/checkout@v6
       with:
         submodules: recursive