Delete --incompatible_java_common_parameters

The flag has been a no-op for a long while.

Fixes #12373

PiperOrigin-RevId: 702226306
Change-Id: Ie79abdd7a90d404c55d191ba66cfac965ed7a7f5

Author: hvadehra

src/main/java/com/google/devtools/build/lib/packages/semantics/BuildLanguageOptions.java

@@ -642,17 +642,6 @@ public final class BuildLanguageOptions extends OptionsBase {
               + "returns a depset instead.")
   public boolean incompatibleDepsetForLibrariesToLinkGetter;
 
-  @Option(
-      name = "incompatible_java_common_parameters",
-      defaultValue = "true",
-      documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS,
-      effectTags = {OptionEffectTag.BUILD_FILE_SEMANTICS},
-      metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE},
-      help =
-          "If set to true, the output_jar, and host_javabase parameters in pack_sources and "
-              + "host_javabase in compile will all be removed.")
-  public boolean incompatibleJavaCommonParameters;
-
   @Option(
       name = "incompatible_java_info_merge_runtime_module_flags",
       defaultValue = "false",
@@ -885,7 +874,6 @@ public StarlarkSemantics toStarlarkSemantics() {
             .setBool(
                 INCOMPATIBLE_FIX_PACKAGE_GROUP_REPOROOT_SYNTAX,
                 incompatibleFixPackageGroupReporootSyntax)
-            .setBool(INCOMPATIBLE_JAVA_COMMON_PARAMETERS, incompatibleJavaCommonParameters)
             .setBool(
                 INCOMPATIBLE_JAVA_INFO_MERGE_RUNTIME_MODULE_FLAGS,
                 incompatibleJavaInfoMergeRuntimeModuleFlags)
@@ -1001,8 +989,6 @@ public StarlarkSemantics toStarlarkSemantics() {
       FlagConstants.INCOMPATIBLE_FIX_PACKAGE_GROUP_REPOROOT_SYNTAX;
   public static final String INCOMPATIBLE_DO_NOT_SPLIT_LINKING_CMDLINE =
       "+incompatible_do_not_split_linking_cmdline";
-  public static final String INCOMPATIBLE_JAVA_COMMON_PARAMETERS =
-      "+incompatible_java_common_parameters";
   public static final String INCOMPATIBLE_JAVA_INFO_MERGE_RUNTIME_MODULE_FLAGS =
       "-incompatible_java_info_merge_runtime_module_flags";
   public static final String INCOMPATIBLE_NO_ATTR_LICENSE = "+incompatible_no_attr_license";

src/main/java/com/google/devtools/build/lib/starlarkbuildapi/java/JavaCommonApi.java

@@ -21,7 +21,6 @@
 import com.google.devtools.build.lib.collect.nestedset.Depset.TypeException;
 import com.google.devtools.build.lib.packages.Info;
 import com.google.devtools.build.lib.packages.RuleClass.ConfiguredTargetFactory.RuleErrorException;
-import com.google.devtools.build.lib.packages.semantics.BuildLanguageOptions;
 import com.google.devtools.build.lib.starlarkbuildapi.FileApi;
 import com.google.devtools.build.lib.starlarkbuildapi.StarlarkActionFactoryApi;
 import com.google.devtools.build.lib.starlarkbuildapi.StarlarkRuleContextApi;
@@ -77,21 +76,6 @@ default JavaInfoT mergeJavaProviders(Sequence<?> providers /* <JavaInfoT> expect
               + "At least one of parameters output_jar or output_source_jar is required.",
       parameters = {
         @Param(name = "actions", named = true, doc = "ctx.actions"),
-        @Param(
-            name = "output_jar",
-            positional = false,
-            named = true,
-            allowedTypes = {
-              @ParamType(type = FileApi.class),
-              @ParamType(type = NoneType.class),
-            },
-            defaultValue = "None",
-            doc =
-                "Deprecated: The output jar of the rule. Used to name the resulting source jar. "
-                    + "The parameter sets output_source_jar parameter to `{output_jar}-src.jar`."
-                    + "Use output_source_jar parameter directly instead.",
-            disableWithFlag = BuildLanguageOptions.INCOMPATIBLE_JAVA_COMMON_PARAMETERS,
-            valueWhenDisabled = "None"),
         @Param(
             name = "output_source_jar",
             positional = false,
@@ -121,25 +105,13 @@ default JavaInfoT mergeJavaProviders(Sequence<?> providers /* <JavaInfoT> expect
             positional = false,
             named = true,
             doc = "A JavaToolchainInfo to used to find the ijar tool."),
-        @Param(
-            name = "host_javabase",
-            positional = false,
-            named = true,
-            doc =
-                "Deprecated: You can drop this parameter (host_javabase is provided with "
-                    + "java_toolchain)",
-            defaultValue = "None",
-            disableWithFlag = BuildLanguageOptions.INCOMPATIBLE_JAVA_COMMON_PARAMETERS,
-            valueWhenDisabled = "None"),
       })
   default FileApi packSources(
       StarlarkActionFactoryT actions,
-      Object outputJar,
       Object outputSourceJar,
       Sequence<?> sourceFiles, // <FileT> expected.
       Sequence<?> sourceJars, // <FileT> expected.
-      Info javaToolchain,
-      Object hostJavabase)
+      Info javaToolchain)
       throws EvalException {
     throw new UnsupportedOperationException();
   }
@@ -352,16 +324,6 @@ default FileApi runIjar(
             doc =
                 "A BootClassPathInfo to be used for this compilation. If present, overrides the"
                     + " bootclasspath associated with the provided java_toolchain."),
-        @Param(
-            name = "host_javabase",
-            positional = false,
-            named = true,
-            doc =
-                "Deprecated: You can drop this parameter (host_javabase is provided with "
-                    + "java_toolchain)",
-            defaultValue = "None",
-            disableWithFlag = BuildLanguageOptions.INCOMPATIBLE_JAVA_COMMON_PARAMETERS,
-            valueWhenDisabled = "None"),
         @Param(
             name = "sourcepath",
             positional = false,
@@ -462,7 +424,6 @@ default JavaInfoT createJavaCompileAction(
       String strictDepsMode,
       Info javaToolchain,
       Object bootClassPath,
-      Object hostJavabase,
       Sequence<?> sourcepathEntries, // <FileT> expected.
       Sequence<?> resources, // <FileT> expected.
       Sequence<?> resourceJars, // <FileT> expected.

src/test/java/com/google/devtools/build/lib/packages/semantics/ConsistencyTest.java

@@ -142,7 +142,6 @@ private static BuildLanguageOptions buildRandomOptions(Random rand) throws Excep
         "--incompatible_disallow_struct_provider_syntax=" + rand.nextBoolean(),
         "--incompatible_do_not_split_linking_cmdline=" + rand.nextBoolean(),
         "--incompatible_enable_deprecated_label_apis=" + rand.nextBoolean(),
-        "--incompatible_java_common_parameters=" + rand.nextBoolean(),
         "--incompatible_merge_fixed_and_default_shell_env=" + rand.nextBoolean(),
         "--incompatible_no_attr_license=" + rand.nextBoolean(),
         "--incompatible_no_implicit_file_export=" + rand.nextBoolean(),
@@ -194,7 +193,6 @@ private static StarlarkSemantics buildRandomSemantics(Random rand) {
             BuildLanguageOptions.INCOMPATIBLE_DISALLOW_STRUCT_PROVIDER_SYNTAX, rand.nextBoolean())
         .setBool(BuildLanguageOptions.INCOMPATIBLE_DO_NOT_SPLIT_LINKING_CMDLINE, rand.nextBoolean())
         .setBool(BuildLanguageOptions.INCOMPATIBLE_ENABLE_DEPRECATED_LABEL_APIS, rand.nextBoolean())
-        .setBool(BuildLanguageOptions.INCOMPATIBLE_JAVA_COMMON_PARAMETERS, rand.nextBoolean())
         .setBool(
             BuildLanguageOptions.INCOMPATIBLE_MERGE_FIXED_AND_DEFAULT_SHELL_ENV, rand.nextBoolean())
         .setBool(BuildLanguageOptions.INCOMPATIBLE_NO_ATTR_LICENSE, rand.nextBoolean())