From 18dfcec4f25eb8e863f9ff39da85cf028608d3d7 Mon Sep 17 00:00:00 2001 From: Philip Zembrod Date: Fri, 19 Jun 2026 10:43:52 +0200 Subject: [PATCH 1/2] Add feature for param_file_name param of cc_internal.get_link_args() This is needed for a pending LTO indexing improvement. --- features.bzl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/features.bzl b/features.bzl index fb645da..f757aeb 100644 --- a/features.bzl +++ b/features.bzl @@ -61,6 +61,10 @@ _cc = struct( # https://github.com/bazelbuild/bazel/commit/41a36ff029340823700e2f4dec0c7cf71fcbdb31 # https://github.com/bazelbuild/bazel/commit/39386503ad55cfad38290f45a8d3732d5b2cd9ac supports_path_variable_patterns = ge_same_major("9.1.0") or ge("10.0.0-pre.20260408.3"), + # Whether cc_internal.get_link_args() supports the param param_file_name. + # https://github.com/bazelbuild/bazel/commit/d788aa269a3300771696a0f9e00868a43cadf7d3 + get_link_args_has_param_file_name = ge("10.0.0-pre.20260608.1"), + ) _docs = struct( From 4e8d54363ad581e104409882e2bf5426055c084a Mon Sep 17 00:00:00 2001 From: Philip Zembrod Date: Mon, 22 Jun 2026 10:04:15 +0200 Subject: [PATCH 2/2] Mark feature _get_link_args_has_param_file_name as internal only. Addressing review comment from #149 --- features.bzl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/features.bzl b/features.bzl index f757aeb..61bf180 100644 --- a/features.bzl +++ b/features.bzl @@ -61,9 +61,9 @@ _cc = struct( # https://github.com/bazelbuild/bazel/commit/41a36ff029340823700e2f4dec0c7cf71fcbdb31 # https://github.com/bazelbuild/bazel/commit/39386503ad55cfad38290f45a8d3732d5b2cd9ac supports_path_variable_patterns = ge_same_major("9.1.0") or ge("10.0.0-pre.20260408.3"), - # Whether cc_internal.get_link_args() supports the param param_file_name. + # Internal only, don't use outside rules_cc. # https://github.com/bazelbuild/bazel/commit/d788aa269a3300771696a0f9e00868a43cadf7d3 - get_link_args_has_param_file_name = ge("10.0.0-pre.20260608.1"), + _get_link_args_has_param_file_name = ge("10.0.0-pre.20260608.1"), )