From 424fe6f86d6253c1147ac5a56cbbeb11a4bdacb6 Mon Sep 17 00:00:00 2001 From: Shan Tang Date: Tue, 17 Nov 2026 16:21:44 +0800 Subject: [PATCH 1/3] Connect Claim review batches to the evidence workbench --- assets/css/evidence-review.css | 4 + assets/js/evidence-review-decisions.js | 106 ++++++++++++++++++++--- assets/js/evidence-review-workbench.js | 115 ++++++++++++++++++++++--- docs/evidence-review-workbench.md | 52 +++++++++-- evidence-review.md | 39 +++++---- tests/site-smoke.cjs | 59 ++++++++++++- 6 files changed, 327 insertions(+), 48 deletions(-) diff --git a/assets/css/evidence-review.css b/assets/css/evidence-review.css index 1deced8..877f758 100644 --- a/assets/css/evidence-review.css +++ b/assets/css/evidence-review.css @@ -38,3 +38,7 @@ .evidence-workbench .ew-backlog-row span { color: var(--muted, #687386); } .evidence-workbench .ew-backlog-row a { text-decoration: underline; } @media(max-width: 720px) { .evidence-workbench .ew-backlog-row { grid-template-columns: 1fr; gap: .25rem; } } + +.evidence-workbench .ew-backlog-row p { grid-column: 1 / -1; margin: .15rem 0; } +.evidence-workbench .ew-backlog-row .compat-limitations { color: var(--muted, #687386); } +.evidence-workbench [data-ew-ledger] { margin-top: .25rem; } diff --git a/assets/js/evidence-review-decisions.js b/assets/js/evidence-review-decisions.js index bc04669..9ebce41 100644 --- a/assets/js/evidence-review-decisions.js +++ b/assets/js/evidence-review-decisions.js @@ -6,7 +6,7 @@ const ui = { selected:$("[data-ew-selected]"), decision:$("[data-ew-decision]"), decisionNote:$("[data-ew-decision-note]"), decisionStatus:$("[data-ew-decision-status]"), - exportDecisions:$("[data-ew-export-decisions]"), profiles:$("[data-ew-profiles]"), + exportDecisions:$("[data-ew-export-decisions]"), ledger:$("[data-ew-ledger]"), profiles:$("[data-ew-profiles]"), company:$("[data-ew-company]"), existing:$("[data-ew-existing]"), approvalId:$("[data-ew-approval-id]"), evidenceId:$("[data-ew-evidence-id]"), reviewer:$("[data-ew-reviewer]"), reviewed:$("[data-ew-reviewed]"), @@ -19,8 +19,9 @@ }; const SLUG = /^[a-z0-9]+(?:-[a-z0-9]+)*$/; const choices = new Set(["needs_more_evidence", "rejected", "accepted_for_evidence_attachment"]); - let selected = null, profiles = null; + let selected = null, profiles = null, ledgerLoaded = false; const decisions = new Map(); + let existingDecisions = new Map(); const html = (tag, label, value) => { const el = document.createElement(tag); el.textContent = label; @@ -32,6 +33,41 @@ const parsed = new Date(value + "T00:00:00Z"); return Number.isFinite(parsed.valueOf()) && parsed.toISOString().slice(0, 10) === value; }; + const dateIsNotFuture = value => validDate(value) && + new Date(value + "T00:00:00").getTime() <= Date.now(); + const localDateAtNoonIso = value => { + const [year, month, day] = value.split("-").map(Number); + return new Date(year, month - 1, day, 12, 0, 0).toISOString(); + }; + const validateLedger = data => { + const keys = value => value && typeof value === "object" && !Array.isArray(value) ? + Object.keys(value).sort().join(",") : ""; + if (keys(data) !== "decisions,schema_version" || data.schema_version !== "1.0" || + !Array.isArray(data.decisions) || data.decisions.length > 10000) { + throw new Error("Expected the current schema 1.0 decision ledger."); + } + const result = new Map(); + for (const item of data.decisions) { + if (keys(item) !== "claim_id,decided_at,decision,notes,reviewer" || + typeof item.claim_id !== "string" || !item.claim_id.trim() || + result.has(item.claim_id) || !choices.has(item.decision) || + typeof item.reviewer !== "string" || !item.reviewer.trim() || + typeof item.notes !== "string" || item.notes.trim().length < 30 || + typeof item.decided_at !== "string" || + !/(Z|[+-][0-9]{2}:[0-9]{2})$/.test(item.decided_at) || + !Number.isFinite(Date.parse(item.decided_at)) || Date.parse(item.decided_at) > Date.now()) { + throw new Error("Decision ledger contains an invalid, duplicate or future-dated human decision."); + } + result.set(item.claim_id, { + claim_id:item.claim_id, decision:item.decision, reviewer:item.reviewer, + decided_at:new Date(item.decided_at).toISOString(), notes:item.notes + }); + } + return result; + }; + const updateDecisionExport = () => { + ui.exportDecisions.disabled = !ledgerLoaded || decisions.size === 0; + }; const canonical = value => { if (Array.isArray(value)) return "[" + value.map(canonical).join(",") + "]"; if (value && typeof value === "object") { @@ -99,7 +135,7 @@ ui.decisionNote.disabled = true; ui.selected.textContent = "No Claim selected. Use “Review this claim” in a card above."; ui.decisionStatus.textContent = "No review decision recorded. Decisions remain in this browser session."; - ui.exportDecisions.disabled = true; + updateDecisionExport(); clearApprovalConsent(); updateAvailability(); }; @@ -126,19 +162,36 @@ ui.decisionNote.addEventListener("input", clearApprovalConsent); const saveDecision = () => { if (!selected || !choices.has(ui.decision.value)) return; + const reviewer = ui.reviewer.value.trim(); + const reviewDate = ui.reviewed.value; const notes = ui.decisionNote.value.trim(); + if (!reviewer) { + ui.decisionStatus.textContent = "Enter the real reviewer identity before recording a decision."; + return; + } + if (!dateIsNotFuture(reviewDate)) { + ui.decisionStatus.textContent = "Enter a valid review date that is not in the future."; + return; + } if (notes.length < 30) { ui.decisionStatus.textContent = "Please write at least 30 characters of review notes."; return; } + if (!ledgerLoaded) { + ui.decisionStatus.textContent = "Load the current master decision ledger before recording decisions for export."; + return; + } + if (existingDecisions.has(selected.claim_id)) { + ui.decisionStatus.textContent = "This Claim already has a committed decision. Edit the existing ledger entry deliberately instead of creating a duplicate."; + return; + } decisions.set(selected.claim_id, { claim_id:selected.claim_id, decision:ui.decision.value, - notes, original_source_url:selected.source.url, - decision_kind:"local_reviewer_draft_not_formal_approval" + reviewer, decided_at:localDateAtNoonIso(reviewDate), notes }); - ui.exportDecisions.disabled = false; - ui.decisionStatus.textContent = "Local decision recorded for " + selected.claim_id + - ". Decisions can be exported but are not formal approvals."; + updateDecisionExport(); + ui.decisionStatus.textContent = "Decision recorded locally for " + selected.claim_id + + ". Export the merged ledger and commit it to master; no workflow or registry has been changed."; clearApprovalConsent(); updateAvailability(); }; @@ -149,10 +202,39 @@ ui.decisionStatus.before(record); record.addEventListener("click", saveDecision); ui.exportDecisions.addEventListener("click", () => { - saveJson("ai-chip-local-review-decisions.json", { - schema_version:"1.0", status:"local_draft_only", - decisions:[...decisions.values()] + if (!ledgerLoaded || decisions.size === 0) { + ui.decisionStatus.textContent = "Load the current ledger and record at least one valid human decision first."; + return; + } + const merged = [...existingDecisions.values(), ...decisions.values()] + .sort((a,b) => a.claim_id.localeCompare(b.claim_id)); + saveJson("intelligence-review-decisions.json", { + schema_version:"1.0", decisions:merged }); + ui.decisionStatus.textContent = "Valid schema 1.0 ledger exported locally. Commit data/intelligence-review-decisions.json to master; the next discovery run will consume it. No facts or registries were changed."; + }); + ui.ledger.addEventListener("change", async () => { + ledgerLoaded = false; + existingDecisions = new Map(); + decisions.clear(); + updateDecisionExport(); + try { + const file = ui.ledger.files[0]; + if (!file || file.size === 0 || file.size > 2 * 1024 * 1024) { + throw new Error("Choose the current, non-empty decision ledger (maximum 2 MiB)."); + } + const ledger = JSON.parse(await file.text()); + existingDecisions = validateLedger(ledger); + ledgerLoaded = true; + ui.decisionStatus.textContent = "Current ledger loaded: " + existingDecisions.size + + " existing decisions. New decisions will be merged without overwriting them."; + updateDecisionExport(); + } catch (error) { + ui.decisionStatus.textContent = "Cannot load decision ledger: " + error.message; + ledgerLoaded = false; + existingDecisions = new Map(); + updateDecisionExport(); + } }); ui.profiles.addEventListener("change", async () => { profiles = null; @@ -197,7 +279,7 @@ ui.evidenceNotes.value.trim().length === 0 || !ui.title.value.trim() || !ui.publisher.value.trim()) { throw new Error("Provide a real reviewer, publisher, title and meaningful review/evidence notes."); } - if (!validDate(ui.reviewed.value) || !validDate(ui.checked.value) || + if (!dateIsNotFuture(ui.reviewed.value) || !dateIsNotFuture(ui.checked.value) || (ui.published.value && !validDate(ui.published.value))) { throw new Error("Review, checked and publication dates must be valid ISO dates."); } diff --git a/assets/js/evidence-review-workbench.js b/assets/js/evidence-review-workbench.js index 8d3f261..972b3f2 100644 --- a/assets/js/evidence-review-workbench.js +++ b/assets/js/evidence-review-workbench.js @@ -4,7 +4,7 @@ if (!root) return; const $ = selector => root.querySelector(selector); const ui = { - claims: $("[data-ew-claims]"), graph: $("[data-ew-graph]"), triage: $("[data-ew-triage]"), aging: $("[data-ew-aging]"), + claims: $("[data-ew-claims]"), batch: $("[data-ew-batch]"), graph: $("[data-ew-graph]"), triage: $("[data-ew-triage]"), aging: $("[data-ew-aging]"), status: $("[data-ew-status]"), provenance: $("[data-ew-provenance]"), search: $("[data-ew-search]"), topic: $("[data-ew-topic]"), publisher: $("[data-ew-publisher]"), relationship: $("[data-ew-relationship]"), @@ -12,7 +12,7 @@ results: $("[data-ew-results]"), empty: $("[data-ew-empty]"), count: $("[data-ew-result-count]"), summary: $("[data-ew-summary]") }; - let claimData = null, graphData = null, triageData = null, agingData = null; + let claimData = null, graphData = null, triageData = null, agingData = null, batchData = null; const MAX_BYTES = 12 * 1024 * 1024; const element = (tag, cls = "", text) => { const node = document.createElement(tag); @@ -36,8 +36,10 @@ graphData = null; triageData = null; agingData = null; + batchData = null; root.dispatchEvent(new CustomEvent("ew-clear-review")); ui.claims.value = ""; + ui.batch.value = ""; ui.graph.value = ""; ui.triage.value = ""; ui.aging.value = ""; @@ -169,6 +171,82 @@ } return data; }; + const validateBatch = (data, aging) => { + if (!aging) throw new Error("Load the persistent Review-State JSON from the same run before loading a Claim review batch."); + if (!data || data.schema_version !== "1.0" || + !["ready", "partial", "empty", "follow_up_only", "unavailable"].includes(data.status) || + typeof data.batch_id !== "string" || !Number.isSafeInteger(data.batch_size_limit) || + data.batch_size_limit < 1 || data.batch_size_limit > 100 || + !Array.isArray(data.items) || data.items.length > data.batch_size_limit || + data.summary?.selected_for_this_batch !== data.items.length || + data.summary?.pending_claims < data.items.length || + data.policy?.decisions_written !== false || + data.policy?.factual_verification_performed !== false || + data.policy?.priority_is_truth_confidence !== false || + data.generated_at !== aging.generated_at) { + throw new Error("Claim review batch has an incompatible schema, policy or run timestamp."); + } + const backlog = new Map(aging.aging_backlog.map(row => [row.claim_id, row])); + const agingRows = new Map(aging.claim_aging.map(row => [row.claim_id, row])); + const seen = new Set(); + for (const item of data.items) { + const claim = item?.claim; + const row = backlog.get(item?.claim_id); + const age = agingRows.get(item?.claim_id); + if (!item || typeof item.claim_id !== "string" || seen.has(item.claim_id) || + item.review_state !== "pending" || item.priority_score_is_truth_confidence !== false || + !Number.isFinite(item.priority_score) || !Number.isSafeInteger(item.days_since_first_seen) || + item.days_since_first_seen < 0 || !claim || claim.claim_id !== item.claim_id || + claim.review_status !== "unverified_candidate" || typeof claim.statement !== "string" || + !claim.statement.trim() || !safeUrl(claim.source?.url) || + !row || row.review_state !== "pending" || !row.claim_snapshot || + row.claim_snapshot.claim_id !== claim.claim_id || + row.claim_snapshot.statement !== claim.statement || + row.claim_snapshot.source?.url !== claim.source?.url || + !age || age.review_state !== "pending") { + throw new Error("Claim review batch contains an invalid, stale, handled or mismatched Claim."); + } + seen.add(item.claim_id); + } + const template = data.decision_template; + const keys = value => value && typeof value === "object" && !Array.isArray(value) ? + Object.keys(value).sort().join(",") : ""; + if (!template || keys(template) !== "decisions,schema_version" || + template.schema_version !== "1.0" || !Array.isArray(template.decisions) || + template.decisions.length !== data.items.length) { + throw new Error("Claim review batch decision template is malformed."); + } + const templateIds = new Set(); + for (const decision of template.decisions) { + if (keys(decision) !== "claim_id,decided_at,decision,notes,reviewer" || + !seen.has(decision.claim_id) || templateIds.has(decision.claim_id) || + decision.decision !== "" || decision.reviewer !== "" || + decision.decided_at !== "" || decision.notes !== "") { + throw new Error("Claim review batch decision template must contain one blank row per selected Claim."); + } + templateIds.add(decision.claim_id); + } + return data; + }; + const mergeBatchClaims = (claims, batch) => { + if (!batch) return claims; + const combined = [...claims.claims]; + const byId = new Map(combined.map(claim => [claim.claim_id, claim])); + for (const item of batch.items) { + const existing = byId.get(item.claim_id); + if (existing) { + if (existing.statement !== item.claim.statement || + existing.candidate_id !== item.claim.candidate_id || + existing.source?.url !== item.claim.source?.url) { + throw new Error("Batch Claim conflicts with the current Claim report: " + item.claim_id); + } + } else { + combined.push(item.claim); + byId.set(item.claim_id, item.claim); + } + } + return {...claims, claim_count:combined.length, claims:combined}; + }; const renderBacklog = () => { const panel = $("[data-ew-aging-panel]"); panel.hidden = !agingData; @@ -191,10 +269,13 @@ list.replaceChildren(); for (const item of historical.slice(0, 100)) { const row = element("div", "ew-backlog-row"); + const claim = item.claim_snapshot || null; row.append(element("strong", "", item.claim_id)); row.append(element("span", "", item.days_since_first_seen + " days · " + item.review_state + " · last observed " + item.last_seen_at)); - const url = safeUrl(item.source_url); + if (claim?.statement) row.append(element("p", "", claim.statement)); + if (claim?.evidence_quote) row.append(element("p", "compat-limitations", "Source excerpt: " + claim.evidence_quote)); + const url = safeUrl(claim?.source?.url || item.source_url); if (url) { const link = element("a", "", "Original source ↗"); link.href = url; link.target = "_blank"; link.rel = "noopener noreferrer"; @@ -205,7 +286,7 @@ if (!historical.length) list.append(element("p", "", "No historical claims absent from this run.")); $("[data-ew-historical-summary]").textContent = "Showing " + Math.min(100, historical.length) + " / " + historical.length + - " previously observed records (historical details require their original Claim report)."; + " previously observed records. Recovered Claim text is shown when retained; load the bounded batch to review its selected Claims below."; }; const readJson = async file => { if (!file || file.size === 0 || file.size > MAX_BYTES) { @@ -317,9 +398,14 @@ return !query || haystack.includes(query); }); const priorities = new Map(); - if (triageData) { - for (const group of triageData.queue) { - for (const id of group.related_claim_ids) priorities.set(id, group.score); + if (triageData || batchData) { + if (triageData) { + for (const group of triageData.queue) { + for (const id of group.related_claim_ids) priorities.set(id, group.score); + } + } + if (batchData) { + for (const item of batchData.items) priorities.set(item.claim_id, item.priority_score); } matches.sort((a,b) => (priorities.get(b.claim_id) ?? -1) - (priorities.get(a.claim_id) ?? -1) || a.claim_id.localeCompare(b.claim_id)); @@ -351,20 +437,22 @@ const graph = ui.graph.files.length ? validateGraph(await readJson(ui.graph.files[0]), claims) : null; const triage = ui.triage.files.length ? validateTriage(await readJson(ui.triage.files[0]), claims) : null; const aging = ui.aging.files.length ? validateAging(await readJson(ui.aging.files[0]), claims) : null; - claimData = claims; + const batch = ui.batch.files.length ? validateBatch(await readJson(ui.batch.files[0]), aging) : null; + claimData = mergeBatchClaims(claims, batch); graphData = graph; triageData = triage; agingData = aging; + batchData = batch; root.dispatchEvent(new CustomEvent("ew-clear-review")); - options(ui.topic, claims.claims.map(item => item.topic), "topics"); - options(ui.publisher, claims.claims.map(item => item.source?.publisher || item.source?.source_name || "Unknown source"), "publishers"); + options(ui.topic, claimData.claims.map(item => item.topic), "topics"); + options(ui.publisher, claimData.claims.map(item => item.source?.publisher || item.source?.source_name || "Unknown source"), "publishers"); [ui.search, ui.topic, ui.publisher, ui.relationship].forEach(node => { node.disabled = false; }); [ui.ageFilter, ui.stateFilter].forEach(node => { node.disabled = !aging; node.value = ""; }); renderBacklog(); ui.search.value = ""; ui.relationship.value = ""; - const sources = new Set(claims.claims.map(item => safeUrl(item.source.url)).filter(Boolean)); - $("[data-ew-stat='claims']").textContent = String(claims.claims.length); + const sources = new Set(claimData.claims.map(item => safeUrl(item.source.url)).filter(Boolean)); + $("[data-ew-stat='claims']").textContent = String(claimData.claims.length); $("[data-ew-stat='sources']").textContent = String(sources.size); $("[data-ew-stat='duplicates']").textContent = graph ? String(graph.duplicate_clusters.length) : "—"; $("[data-ew-stat='conflicts']").textContent = graph ? @@ -374,6 +462,7 @@ "No graph loaded: duplicate/conflict filters are unavailable") + " · " + (triage ? "Sorted by review urgency, not truth confidence" : "Default source order") + " · " + (aging ? "Persistent review snapshot loaded (not factual verification)" : "No aging snapshot loaded") + + " · " + (batch ? batch.items.length + " bounded batch Claims merged" : "No bounded batch loaded") + " · All candidates stay unverified. Files remain in this browser session."; ui.provenance.hidden = false; status("Artifacts loaded locally. Nothing was uploaded or approved."); @@ -383,6 +472,7 @@ graphData = null; triageData = null; agingData = null; + batchData = null; $("[data-ew-aging-panel]").hidden = true; root.dispatchEvent(new CustomEvent("ew-clear-review")); ui.results.replaceChildren(); @@ -396,6 +486,7 @@ } }; ui.claims.addEventListener("change", load); + ui.batch.addEventListener("change", load); ui.graph.addEventListener("change", load); ui.triage.addEventListener("change", load); ui.aging.addEventListener("change", load); diff --git a/docs/evidence-review-workbench.md b/docs/evidence-review-workbench.md index 0b303cd..93ac547 100644 --- a/docs/evidence-review-workbench.md +++ b/docs/evidence-review-workbench.md @@ -1,16 +1,24 @@ # Evidence Review Workbench — reviewer decisions and manifest export (PR #96) At /evidence-review/, users load local intelligence Claim JSON and optional -Evidence Graph JSON from a weekly GitHub Actions artifact. +Evidence Graph, Triage, Review-State and bounded Claim Review Batch JSON from +the same weekly GitHub Actions artifact. All files are read locally in the +browser; no upload or automatic approval occurs. ## Local review decisions -Select "Review this claim". Record a local outcome: needs more evidence, -reject, or accept for evidence attachment review. At least 30 characters of -review notes are required. Export a local decision log if useful. +Select "Review this claim". Record an outcome: needs more evidence, reject, +or accept for evidence attachment review. Enter the real reviewer identity, +review date and at least 30 characters of rationale. Load the current +`data/intelligence-review-decisions.json` from master before exporting; the +workbench validates it and merges new decisions without discarding prior ones. -The log remains a session-local draft, never an authoritative status change. -Browser refresh clears it. No approval is inferred from the extracted source. +The exported file uses the exact schema consumed by +`track_intelligence_review_state.py`. It remains a local file until a human +commits the updated ledger to master. The next weekly Discovery run consumes +that committed ledger. Browser refresh clears unexported decisions. No +approval or factual verification is inferred from the extracted source. +Decision dates are exported as timezone-aware ISO-8601 timestamps. ## Human-reviewed Approval Manifest @@ -89,3 +97,35 @@ write occurs. The manually gated Evidence-to-PR approval is unchanged. The browser smoke test uses synthetic Claim/Graph/Triage/Review-State snapshots, covers old-but-not-observed backlog, aging counters, review-state and age filters, and rejects a fabricated \`state_is_approval: true\` file. + + +## Bounded historical Claim review batches (PR #127) + +The weekly artifact now includes +`ai-chip-intelligence-claim-review-batch.json`. Load it alongside the Claim +report and the Review-State JSON from the **same run**. The workbench checks +the batch timestamp, selected Claim IDs, unresolved state, source URL, +retained Claim snapshot and blank decision-template rows before merging the +selected Claims into the review cards. + +This makes recovered historical Claims reviewable even when they no longer +appear in the current discovery's Claim extraction report. The persistent +backlog panel also displays retained historical statements and source excerpts +when present. The batch remains bounded (default 25); the workbench does not +silently load the entire historical backlog into the card list. + +## Exporting the formal human decision ledger (PR #127) + +The workbench requires the current master decision ledger before export. +Existing entries are preserved; duplicate Claim IDs are rejected. Every new +decision requires a reviewer identity, a valid non-future review date and at +least 30 characters of rationale. The exported JSON has exactly the +`schema_version` and `decisions` fields, with each decision containing +exactly `claim_id`, `decision`, `reviewer`, `decided_at` and `notes`. + +The export is still local. Commit the reviewed file as +`data/intelligence-review-decisions.json`; no browser action writes to GitHub. +The next Discovery run will update operational review states from this ledger. +`accepted_for_evidence_attachment` remains only a request to prepare a +separate, explicitly reviewed Evidence-to-PR manifest. It is not a verified +technical claim or permission to update a formal registry. diff --git a/evidence-review.md b/evidence-review.md index ed2645c..7a4f48c 100644 --- a/evidence-review.md +++ b/evidence-review.md @@ -22,12 +22,19 @@ description: Local-only review of unverified intelligence claim and evidence gra

01 / LOAD

Open a review artifact

-

Download the ai-chip-intelligence-discovery artifact. Choose its Claim JSON and optional Evidence Graph JSON from the same run. The workbench does not fetch data automatically.

+

Download the ai-chip-intelligence-discovery artifact. Choose its Claim JSON, optional bounded Claim review batch and optional Evidence Graph / Triage / Review-State JSON from the same run. The batch adds recovered historical Claims that may be absent from the current discovery. The workbench does not fetch data automatically.

+

Before exporting formal review decisions, also load the current decision ledger from master. This preserves earlier decisions when you export the updated ledger.

-

Not observed in the current discovery

-

These historical IDs remain in the cached backlog even though the current Claim JSON no longer contains their full extracted statements. They cannot be reviewed or approved from this page without retrieving the original report.

+

These historical IDs remain in the cached backlog even when the current Claim JSON no longer contains them. Restored Claim statements and source excerpts are shown when available. Load the bounded Claim review batch from the same run to open its selected historical Claims as review cards. Nothing is approved automatically.

@@ -116,11 +123,11 @@ description: Local-only review of unverified intelligence claim and evidence gra

04 / HUMAN DECISION

Review selected Claim

- Local draft only + Local until committed

No Claim selected. Use “Review this claim” in a card above.

-
-

No review decision recorded. Decisions remain in this browser session.

- +

Load the current decision ledger, then record a review. Decisions remain local until the exported ledger is committed.

+
@@ -158,12 +171,6 @@ description: Local-only review of unverified intelligence claim and evidence gra - - diff --git a/tests/site-smoke.cjs b/tests/site-smoke.cjs index 7466a93..ce54ac4 100644 --- a/tests/site-smoke.cjs +++ b/tests/site-smoke.cjs @@ -1264,6 +1264,18 @@ const { chromium } = require("playwright"); review_state:"pending",alert_level:"overdue_30d",review_is_factual_verification:false, source_url:"https://example.org/old-claim"} ]; + const historicalBatchClaim = { + ...reviewClaims[0], + claim_id:"claim-test-old",candidate_id:"candidate-test-old", + statement:"Historical restored Claim: Example accelerator reaches 160 GB HBM per GPU.", + evidence_quote:"The archived source lists 160 GB HBM per accelerator.", + source:{url:"https://example.org/historical-source",publisher:"Historical Vendor", + published_at:"2026-10-01",evidence_scope:"official_vendor_feed_metadata_and_excerpt"} + }; + const historicalBacklogRow = { + ...historyFixture[3],claim_snapshot:historicalBatchClaim, + priority:{score:65,score_factors:{high_impact_topic:18},risk_flags:["vendor_primary_not_independent_corroboration"]} + }; const historyJson = { schema_version:"1.0",generated_at:"2026-11-14T00:00:00Z", observation_state:"cache_persisted",state_is_approval:false, @@ -1271,11 +1283,30 @@ const { chromium } = require("playwright"); unknown_first_seen_if_cache_reset:true, review_states:{pending:2,needs_more_evidence:1,rejected:1,accepted_for_evidence_attachment:0}}, claim_aging:historyFixture, - aging_backlog:[historyFixture[0],historyFixture[1],historyFixture[3]], + aging_backlog:[historyFixture[0],historyFixture[1],historicalBacklogRow], queue:[] }; await page.locator("[data-ew-aging]").setInputFiles(artifact("ai-chip-intelligence-review-state.json",historyJson)); await page.waitForFunction(() => document.querySelector("[data-ew-aging-count='tracked']")?.textContent === "4"); + const reviewBatchFixture = { + schema_version:"1.0",generated_at:historyJson.generated_at,status:"ready", + batch_id:"claim-review-smoke",batch_size_limit:25, + summary:{pending_claims:2,selected_for_this_batch:1}, + policy:{decisions_written:false,factual_verification_performed:false,priority_is_truth_confidence:false}, + items:[{claim_id:"claim-test-old",review_state:"pending",first_seen_at:"2026-09-23T00:00:00Z", + days_since_first_seen:52,priority_score:65,priority_score_is_truth_confidence:false, + priority_score_factors:{high_impact_topic:18},risk_flags:["vendor_primary_not_independent_corroboration"], + claim:historicalBatchClaim}], + decision_template:{schema_version:"1.0",decisions:[{ + claim_id:"claim-test-old",decision:"",reviewer:"",decided_at:"",notes:"" + }]} + }; + await page.locator("[data-ew-batch]").setInputFiles(artifact("ai-chip-intelligence-claim-review-batch.json",reviewBatchFixture)); + await page.waitForFunction(() => document.querySelector("[data-ew-stat='claims']")?.textContent === "4"); + if (!(await page.locator("[data-ew-results]").textContent()).includes("Historical restored Claim") || + !(await page.locator("[data-ew-historical-list]").textContent()).includes("Historical restored Claim")) { + throw new Error("Evidence Workbench did not load restored historical Claim details from the bounded batch"); + } if (await page.locator("[data-ew-aging-count='fourteen']").textContent() !== "3" || await page.locator("[data-ew-aging-count='thirty']").textContent() !== "2" || !(await page.locator("[data-ew-historical-list]").textContent()).includes("claim-test-old")) { @@ -1307,13 +1338,37 @@ const { chromium } = require("playwright"); } // PR #96 review-decision and Approval Manifest Builder exercise. await page.locator("[data-ew-clear-filters]").click(); + await page.locator("[data-ew-ledger]").setInputFiles(artifact("intelligence-review-decisions.json",{ + schema_version:"1.0",decisions:[] + })); await page.locator("[data-ew-review-claim='claim-test-a']").click(); await page.locator("[data-ew-decision]").selectOption("accepted_for_evidence_attachment"); + await page.locator("[data-ew-reviewer]").fill("ci-synthetic-fixture-not-a-real-reviewer"); + await page.locator("[data-ew-reviewed]").fill("2026-11-14"); await page.locator("[data-ew-decision-note]").fill("CI synthetic fixture: manual review would be required for a real Claim and exact source."); await page.locator("[data-ew-record-decision]").click(); - if (!(await page.locator("[data-ew-decision-status]").textContent()).includes("Local decision recorded")) { + if (!(await page.locator("[data-ew-decision-status]").textContent()).includes("Decision recorded locally")) { throw new Error("Workbench did not record an explicit local review decision"); } + const [ledgerDownload] = await Promise.all([ + page.waitForEvent("download"), + page.locator("[data-ew-export-decisions]").click() + ]); + if (ledgerDownload.suggestedFilename() !== "intelligence-review-decisions.json") { + throw new Error("Workbench downloaded an unexpected decision ledger name"); + } + const ledgerPath = require("path").join(require("os").tmpdir(), "ai-chip-review-ledger-smoke.json"); + await ledgerDownload.saveAs(ledgerPath); + const exportedLedger = JSON.parse(require("fs").readFileSync(ledgerPath, "utf8")); + const ledgerDecision = exportedLedger.decisions.find(item => item.claim_id === "claim-test-a"); + if (Object.keys(exportedLedger).sort().join(",") !== "decisions,schema_version" || + Object.keys(ledgerDecision || {}).sort().join(",") !== "claim_id,decided_at,decision,notes,reviewer" || + ledgerDecision.decision !== "accepted_for_evidence_attachment" || + ledgerDecision.reviewer !== "ci-synthetic-fixture-not-a-real-reviewer" || + ledgerDecision.notes.length < 30 || !Number.isFinite(Date.parse(ledgerDecision.decided_at))) { + throw new Error("Workbench did not export a tracker-compatible human decision ledger"); + } + require("fs").unlinkSync(ledgerPath); const profileFixture = { schema_version:"1.0", companies:[{id:"test-company",name:"Test Company",evidence:[],claims:[{ From f268d1f1ae2b114c4e6e20eff409183a47128533 Mon Sep 17 00:00:00 2001 From: Shan Tang Date: Tue, 17 Nov 2026 16:23:51 +0800 Subject: [PATCH 2/3] Adjust review age smoke assertion for historical batch items --- tests/site-smoke.cjs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/site-smoke.cjs b/tests/site-smoke.cjs index ce54ac4..1e1f3e7 100644 --- a/tests/site-smoke.cjs +++ b/tests/site-smoke.cjs @@ -1313,8 +1313,8 @@ const { chromium } = require("playwright"); throw new Error("Persistent review state dashboard did not show accurate historical backlog"); } await page.locator("[data-ew-age-filter]").selectOption("overdue_30d"); - if (Number(await page.locator("[data-ew-result-count]").textContent()) !== 2) { - throw new Error("Evidence Review Workbench 30+ day review age filter failed"); + if (Number(await page.locator("[data-ew-result-count]").textContent()) !== 3) { + throw new Error("Evidence Review Workbench 30+ day review age filter failed after adding the restored batch Claim"); } await page.locator("[data-ew-age-filter]").selectOption(""); await page.locator("[data-ew-state-filter]").selectOption("needs_more_evidence"); From 1977317fa2878de5da444fe672498266765bd3d7 Mon Sep 17 00:00:00 2001 From: Shan Tang Date: Tue, 17 Nov 2026 16:24:31 +0800 Subject: [PATCH 3/3] Render restored historical Claim text in the backlog list --- assets/js/evidence-review-workbench.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/assets/js/evidence-review-workbench.js b/assets/js/evidence-review-workbench.js index 972b3f2..ea8a3e7 100644 --- a/assets/js/evidence-review-workbench.js +++ b/assets/js/evidence-review-workbench.js @@ -263,13 +263,15 @@ " · First observed in a best-effort Actions cache; eviction or changed Claim IDs can reset age. " + "These are operational review states, never verified facts."; const list = $("[data-ew-historical-list]"); + const retainedClaims = new Map((agingData.aging_backlog || []).map(item => + [item.claim_id, item.claim_snapshot || null])); const historical = entries.filter(x => !x.observed_this_run); historical.sort((a,b) => b.days_since_first_seen - a.days_since_first_seen || a.claim_id.localeCompare(b.claim_id)); list.replaceChildren(); for (const item of historical.slice(0, 100)) { const row = element("div", "ew-backlog-row"); - const claim = item.claim_snapshot || null; + const claim = item.claim_snapshot || retainedClaims.get(item.claim_id) || null; row.append(element("strong", "", item.claim_id)); row.append(element("span", "", item.days_since_first_seen + " days · " + item.review_state + " · last observed " + item.last_seen_at));