Skip to content

feat(TBAEF-1634): Add signature discount validator#146

Merged
stevieraykatz merged 19 commits into
mainfrom
signature-discount-validator
Nov 10, 2025
Merged

feat(TBAEF-1634): Add signature discount validator#146
stevieraykatz merged 19 commits into
mainfrom
signature-discount-validator

Conversation

@stevieraykatz

Copy link
Copy Markdown
Member

No description provided.

@linear

linear Bot commented Oct 22, 2025

Copy link
Copy Markdown

@cb-heimdall

cb-heimdall commented Oct 22, 2025

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Comment thread src/L2/discounts/SignatureDiscountValidator.sol Fixed
Comment thread src/L2/discounts/SignatureDiscountValidator.sol Fixed
@stevieraykatz stevieraykatz marked this pull request as ready for review October 28, 2025 18:30
@amiecorso amiecorso self-requested a review October 29, 2025 22:44

@amiecorso amiecorso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than the docs and test nits!

Comment thread src/L2/discounts/SignatureDiscountValidator.sol Outdated
Comment thread src/L2/discounts/SignatureDiscountValidator.sol Outdated
Comment thread src/L2/discounts/SignatureDiscountValidator.sol Outdated
Comment thread test/discounts/SignatureDiscountValidator/IsValidDiscountRegistration.t.sol Outdated
Comment thread test/discounts/SignatureDiscountValidator/SetSigner.t.sol Outdated
stevieraykatz and others added 4 commits October 30, 2025 14:08
Co-authored-by: Amie <amie.corso@coinbase.com>
Co-authored-by: Amie <amie.corso@coinbase.com>
Co-authored-by: Amie <amie.corso@coinbase.com>
amiecorso
amiecorso previously approved these changes Oct 30, 2025

@amiecorso amiecorso left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cb-heimdall

Copy link
Copy Markdown
Collaborator

Review Error for amiecorso @ 2025-10-30 22:28:59 UTC
User cannot review their own commit

@cb-heimdall

Copy link
Copy Markdown
Collaborator

Review Error for OGraham-cb @ 2025-11-05 21:20:27 UTC
User failed mfa authentication, see go/mfa-help

OGraham-cb
OGraham-cb previously approved these changes Nov 5, 2025
@cb-heimdall

Copy link
Copy Markdown
Collaborator

Review Error for OGraham-cb @ 2025-11-10 17:56:13 UTC
User failed mfa authentication, see go/mfa-help

@stevieraykatz stevieraykatz merged commit b43d20c into main Nov 10, 2025
5 of 7 checks passed
@stevieraykatz stevieraykatz deleted the signature-discount-validator branch November 10, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants