release: v0.5.21 - add recursion guards across all parsers

bartolli · bartolli · commit 28883a39a992 · 2025-10-03T19:12:28.000-04:00
- add check_recursion_depth() call to all language parsers (TypeScript, Python, Rust, Go, PHP, C++, C#)
- each parser now accepts depth parameter in extract_symbols_from_node()
- prevents stack overflow on deeply nested AST structures
- MCP tools tested: semantic_search_with_context, find_symbol, analyze_impact, find_callers, get_calls verified
- CLI retrieve commands tested: symbol, calls, callers, search, describe, implementations with --json flag
- cross-file resolution working correctly in all scenarios
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,23 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.5.21] - 2025-10-03
+
+### Added
+- Recursion depth guards across all language parsers
+  - `check_recursion_depth()` prevents stack overflow on deeply nested AST structures
+  - All parsers (TypeScript, Python, Rust, Go, PHP, C++, C#) now track depth in `extract_symbols_from_node()`
+  - Safely handles pathological code with excessive nesting (tested on Qt keyboard at depth 3521)
+
+### Changed
+- **PERFORMANCE**: Optimized resolution pipeline for large codebases
+  - Indexed method calls as HashMap for O(1) lookup instead of linear search
+  - Added symbol lookup cache to eliminate duplicate Tantivy queries
+  - Qt qtbase (8,508 files, 413K symbols): 7m38s total, relationship resolution processes 4.68M relationships with 4,778 resolved, 4.39M skipped
+  - Skipped relationships: external symbols not in index (Qt framework dependencies, system libraries)
+- Parser method signatures updated to accept depth parameter
+- Audit reports and grammar analysis regenerated for all languages
+
 ## [0.5.20] - 2025-10-02
 
 ### Added
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/Cargo.toml b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "codanna"
-version = "0.5.20"
+version = "0.5.21"
 authors = ["Angel Bartolli <bartolli@gmail.com>"]
 edition = "2024"
 description = "Code Intelligence for Large Language Models"
@@ -14,10 +14,10 @@ categories = ["development-tools", "command-line-utilities", "parsing", "text-pr
 autoexamples = false
 
 [profile.release]
-# opt-level = 3
-# lto = true
-# codegen-units = 1
-# strip = true
+opt-level = 3
+lto = true
+codegen-units = 1
+strip = true
 
 [dependencies]
 anyhow = "1.0.98"
diff --git a/contributing/parsers/c/AUDIT_REPORT.md b/contributing/parsers/c/AUDIT_REPORT.md
@@ -1,6 +1,6 @@
 # C Parser Coverage Report
 
-*Generated: 2025-10-02 22:34:05 UTC*
+*Generated: 2025-10-03 21:46:34 UTC*
 
 ## Summary
 - Nodes in file: 145
diff --git a/contributing/parsers/c/GRAMMAR_ANALYSIS.md b/contributing/parsers/c/GRAMMAR_ANALYSIS.md
@@ -1,6 +1,6 @@
 # C Grammar Analysis
 
-*Generated: 2025-10-02 22:34:05 UTC*
+*Generated: 2025-10-03 21:46:34 UTC*
 
 ## Statistics
 - Total nodes in grammar JSON: 132
diff --git a/contributing/parsers/c/node_discovery.txt b/contributing/parsers/c/node_discovery.txt
@@ -1,5 +1,5 @@
 === C Language ABI-15 COMPREHENSIVE NODE MAPPING ===
-  Generated: 2025-10-02 22:34:05 UTC
+  Generated: 2025-10-03 21:46:34 UTC
   ABI Version: 15
   Node kind count: 145
 
diff --git a/contributing/parsers/cpp/AUDIT_REPORT.md b/contributing/parsers/cpp/AUDIT_REPORT.md
@@ -1,6 +1,6 @@
 # C++ Parser Coverage Report
 
-*Generated: 2025-10-02 22:34:05 UTC*
+*Generated: 2025-10-03 21:46:34 UTC*
 
 ## Summary
 - Nodes in file: 131
diff --git a/contributing/parsers/cpp/GRAMMAR_ANALYSIS.md b/contributing/parsers/cpp/GRAMMAR_ANALYSIS.md
@@ -1,6 +1,6 @@
 # C++ Grammar Analysis
 
-*Generated: 2025-10-02 22:34:05 UTC*
+*Generated: 2025-10-03 21:46:34 UTC*
 
 ## Statistics
 - Total nodes in grammar JSON: 223
diff --git a/contributing/parsers/cpp/node_discovery.txt b/contributing/parsers/cpp/node_discovery.txt
@@ -1,5 +1,5 @@
 === C++ Language ABI-15 COMPREHENSIVE NODE MAPPING ===
-  Generated: 2025-10-02 22:34:05 UTC
+  Generated: 2025-10-03 21:46:34 UTC
   ABI Version: 14
   Node kind count: 131
 
diff --git a/contributing/parsers/csharp/AUDIT_REPORT.md b/contributing/parsers/csharp/AUDIT_REPORT.md
@@ -1,6 +1,6 @@
 # C# Parser Coverage Report
 
-*Generated: 2025-10-02 22:46:39 UTC*
+*Generated: 2025-10-03 21:46:34 UTC*
 
 ## Summary
 - Nodes in file: 108
diff --git a/contributing/parsers/csharp/GRAMMAR_ANALYSIS.md b/contributing/parsers/csharp/GRAMMAR_ANALYSIS.md
@@ -1,6 +1,6 @@
 # C# Grammar Analysis
 
-*Generated: 2025-10-02 22:46:39 UTC*
+*Generated: 2025-10-03 21:46:34 UTC*
 
 ## Statistics
 - Total nodes in grammar JSON: 220
diff --git a/contributing/parsers/csharp/node_discovery.txt b/contributing/parsers/csharp/node_discovery.txt
@@ -1,5 +1,5 @@
 === C# Language ABI-15 COMPREHENSIVE NODE MAPPING ===
-  Generated: 2025-10-02 22:46:39 UTC
+  Generated: 2025-10-03 21:46:34 UTC
   ABI Version: 14
   Node kind count: 108
 
diff --git a/contributing/parsers/go/AUDIT_REPORT.md b/contributing/parsers/go/AUDIT_REPORT.md
@@ -1,6 +1,6 @@
 # Go Parser Symbol Extraction Coverage Report
 
-*Generated: 2025-10-02 22:34:05 UTC*
+*Generated: 2025-10-03 21:46:34 UTC*
 
 ## Summary
 - Nodes in file: 115
diff --git a/contributing/parsers/go/GRAMMAR_ANALYSIS.md b/contributing/parsers/go/GRAMMAR_ANALYSIS.md
@@ -1,6 +1,6 @@
 # Go Grammar Analysis
 
-*Generated: 2025-10-02 22:34:05 UTC*
+*Generated: 2025-10-03 21:46:34 UTC*
 
 ## Statistics
 - Total nodes in grammar JSON: 112
diff --git a/contributing/parsers/go/node_discovery.txt b/contributing/parsers/go/node_discovery.txt
@@ -1,5 +1,5 @@
 === Go Language ABI-15 COMPREHENSIVE NODE MAPPING ===
-  Generated: 2025-10-02 22:34:05 UTC
+  Generated: 2025-10-03 21:46:34 UTC
   ABI Version: 15
   Node kind count: 115
 
diff --git a/contributing/parsers/php/AUDIT_REPORT.md b/contributing/parsers/php/AUDIT_REPORT.md
@@ -1,6 +1,6 @@
 # PHP Parser Coverage Report
 
-*Generated: 2025-10-02 22:34:05 UTC*
+*Generated: 2025-10-03 21:46:34 UTC*
 
 ## Summary
 - Nodes in file: 177
diff --git a/contributing/parsers/php/GRAMMAR_ANALYSIS.md b/contributing/parsers/php/GRAMMAR_ANALYSIS.md
@@ -1,6 +1,6 @@
 # PHP Grammar Analysis
 
-*Generated: 2025-10-02 22:34:05 UTC*
+*Generated: 2025-10-03 21:46:34 UTC*
 
 ## Statistics
 - Total nodes in grammar JSON: 161
diff --git a/contributing/parsers/python/AUDIT_REPORT.md b/contributing/parsers/python/AUDIT_REPORT.md
@@ -1,6 +1,6 @@
 # Python Parser Symbol Extraction Coverage Report
 
-*Generated: 2025-10-02 22:34:05 UTC*
+*Generated: 2025-10-03 21:46:34 UTC*
 
 ## Summary
 - Nodes in file: 121
diff --git a/contributing/parsers/python/GRAMMAR_ANALYSIS.md b/contributing/parsers/python/GRAMMAR_ANALYSIS.md
@@ -1,6 +1,6 @@
 # Python Grammar Analysis
 
-*Generated: 2025-10-02 22:34:05 UTC*
+*Generated: 2025-10-03 21:46:34 UTC*
 
 ## Statistics
 - Total nodes in grammar JSON: 129
diff --git a/contributing/parsers/python/node_discovery.txt b/contributing/parsers/python/node_discovery.txt
@@ -1,5 +1,5 @@
 === Python Language ABI-15 COMPREHENSIVE NODE MAPPING ===
-  Generated: 2025-10-02 22:34:05 UTC
+  Generated: 2025-10-03 21:46:34 UTC
   ABI Version: 15
   Node kind count: 121
 
diff --git a/contributing/parsers/rust/AUDIT_REPORT.md b/contributing/parsers/rust/AUDIT_REPORT.md
@@ -1,6 +1,6 @@
 # Rust Parser Coverage Report
 
-*Generated: 2025-10-02 22:34:05 UTC*
+*Generated: 2025-10-03 21:46:34 UTC*
 
 ## Summary
 - Nodes in file: 143
diff --git a/contributing/parsers/rust/GRAMMAR_ANALYSIS.md b/contributing/parsers/rust/GRAMMAR_ANALYSIS.md
@@ -1,6 +1,6 @@
 # Rust Grammar Analysis
 
-*Generated: 2025-10-02 22:34:05 UTC*
+*Generated: 2025-10-03 21:46:34 UTC*
 
 ## Statistics
 - Total nodes in grammar JSON: 169
diff --git a/contributing/parsers/rust/node_discovery.txt b/contributing/parsers/rust/node_discovery.txt
@@ -1,5 +1,5 @@
 === Rust Language ABI-15 COMPREHENSIVE NODE MAPPING ===
-  Generated: 2025-10-02 22:34:05 UTC
+  Generated: 2025-10-03 21:46:34 UTC
   ABI Version: 15
   Node kind count: 143
 
diff --git a/contributing/parsers/typescript/AUDIT_REPORT.md b/contributing/parsers/typescript/AUDIT_REPORT.md
@@ -1,6 +1,6 @@
 # TypeScript Parser Coverage Report
 
-*Generated: 2025-10-02 22:34:05 UTC*
+*Generated: 2025-10-03 21:46:34 UTC*
 
 ## Summary
 - Nodes in file: 203
diff --git a/contributing/parsers/typescript/GRAMMAR_ANALYSIS.md b/contributing/parsers/typescript/GRAMMAR_ANALYSIS.md
@@ -1,6 +1,6 @@
 # TypeScript Grammar Analysis
 
-*Generated: 2025-10-02 22:34:05 UTC*
+*Generated: 2025-10-03 21:46:34 UTC*
 
 ## Statistics
 - Total nodes in grammar JSON: 183
diff --git a/contributing/parsers/typescript/node_discovery.txt b/contributing/parsers/typescript/node_discovery.txt
@@ -1,5 +1,5 @@
 === TypeScript Language ABI-15 COMPREHENSIVE NODE MAPPING ===
-  Generated: 2025-10-02 22:34:05 UTC
+  Generated: 2025-10-03 21:46:34 UTC
   ABI Version: 14
   Node kind count: 198
 
diff --git a/src/parsing/cpp/parser.rs b/src/parsing/cpp/parser.rs
@@ -1,6 +1,7 @@
 //! C++ language parser implementation
 
 use crate::parsing::method_call::MethodCall;
+use crate::parsing::parser::check_recursion_depth;
 use crate::parsing::{Import, Language, LanguageParser, NodeTracker, NodeTrackingState};
 use crate::types::{Range, SymbolCounter};
 use crate::{FileId, Symbol, SymbolKind};
@@ -83,7 +84,13 @@ impl CppParser {
         file_id: FileId,
         symbols: &mut Vec<Symbol>,
         counter: &mut SymbolCounter,
+        depth: usize,
     ) {
+        // Guard against stack overflow
+        if !check_recursion_depth(depth, node) {
+            return;
+        }
+
         match node.kind() {
             "function_definition" => {
                 self.register_handled_node(node.kind(), node.kind_id());
@@ -184,7 +191,7 @@ impl CppParser {
         // Process children
         for i in 0..node.child_count() {
             if let Some(child) = node.child(i) {
-                self.extract_symbols_from_node(child, code, file_id, symbols, counter);
+                self.extract_symbols_from_node(child, code, file_id, symbols, counter, depth + 1);
             }
         }
     }
@@ -539,7 +546,7 @@ impl LanguageParser for CppParser {
         let root_node = tree.root_node();
         let mut symbols = Vec::new();
 
-        self.extract_symbols_from_node(root_node, code, file_id, &mut symbols, symbol_counter);
+        self.extract_symbols_from_node(root_node, code, file_id, &mut symbols, symbol_counter, 0);
 
         symbols
     }
diff --git a/src/parsing/csharp/parser.rs b/src/parsing/csharp/parser.rs
diff --git a/src/parsing/go/parser.rs b/src/parsing/go/parser.rs
diff --git a/src/parsing/php/parser.rs b/src/parsing/php/parser.rs
diff --git a/src/parsing/python/parser.rs b/src/parsing/python/parser.rs
diff --git a/src/parsing/rust/parser.rs b/src/parsing/rust/parser.rs
diff --git a/src/parsing/typescript/parser.rs b/src/parsing/typescript/parser.rs
